# Migrate storage from SQLite to PostgreSQL — full dashboard cutover Migrates Fusion's storage layer to the embedded PostgreSQL `AsyncDataLayer` (the default backend) and **completes the satellite-store + feature cutover** so every dashboard and Command Center surface works in PG mode. ## Status — every surface works in embedded-PG mode Verified live against a running embedded-Postgres dashboard (all **200**, zero 5xx) and gate-tested (**23 files / 99 tests** on embedded PG, plus engine-core 294 and ci-shape 63 in the blocking merge gate; core/engine/cli/dashboard typecheck clean). | Area | Surfaces | State | |---|---|---| | Satellite stores | workflows, todos, insights, research, missions, goals, mailbox | ✅ | | Views | artifacts, documents, evals | ✅ | | Command Center | activity, productivity, team, tokens, tools, **workflows**, **github**, **signals**, **plugin-activations**, **live** (all 10) | ✅ | | Run execution | insight generation, research run execution | ✅ (store-path; AI step needs a provider) | | Live updates | SSE push for mission/research/insight events | ✅ | | Workflow editing | create / update / delete / select (+ id counter) | ✅ | | Engine | mission autopilot, incident-signal ingestion, regression storm-guard, agent wake-on-message | ✅ | | Core | tasks, agents, secrets, automations, memory, chat, usage, PRs, git | ✅ | ## Approach Each satellite store gets an `Async<Store>` wrapper exposing the sync store's method names over the existing `async-*-store.ts` helpers; `get<Store>Store()` returns a `Sync | Async` union; consumers `await` (harmless on sync), and engine/CLI paths that can't convert use `instanceof Sync` graceful fallback. Analytics aggregators branch on `"ping" in dbOrLayer` to run schema-qualified raw SQL over `project.*` (snake_case) in PG. Executors/orchestrators/autopilot are await-converted to drive the union store; the async store wrappers extend `EventEmitter` so SSE live-push fires in both backends. Not-yet-ported capabilities degrade gracefully (never 500) and are individually called out in commits. ## Sync with main The branch is kept continuously merged with `main` (currently through FN-7845, 2026-07-12); the earlier "final rebase deferred" note no longer applies. Use **Create a merge commit** (or squash) to land it — GitHub's rebase-merge cannot replay a merge-maintained branch. ## Residual Review Findings Multi-agent code review of the PostgreSQL satellite-store ports (U1–U5) applied 3 safe fixes (see `fix(review): apply autofix feedback`). The following are **real but gated** — recorded here as follow-up work rather than auto-applied. All are SQLite→PostgreSQL **concurrency/atomicity regressions**: the sync stores were immune only by SQLite's single-writer, single-threaded-handler execution; the async ports open multi-await read-modify-write windows. **Reachability is low today** because the execution engines that generate concurrent same-run mutations (insight run executor, research orchestrator/dispatcher) are `instanceof`-gated to sync mode in PG. No process-crash class survived (all engine fallbacks correctly guard the sync store). - **[P1] Research `appendResearchEvent` dual-write is non-atomic** (`packages/core/src/async-research-store.ts`, corroborated: adversarial + reliability). The `research_run_events` insert (own transaction) and the `run.events` jsonb update are separate writes — a crash between them, or two concurrent appends, splits the table count from the jsonb array. **Fix:** perform the seq-insert and the jsonb update in one `layer.transactionImmediate`. - **[P1] Research run terminal-reversion via stale full-row persist** (`async-research-store.ts` `persistResearchRun`/`updateResearchStatus`). Concurrent `PATCH /runs/:id/status` + `POST /runs/:id/events` can revert a terminal run to `running` by overwriting the whole row, bypassing the transition guard. **Fix:** scoped column `UPDATE`s with a `WHERE status …` guard, or optimistic version column. - **[P2] `updateResearchRun`/`updateInsightRun` read-then-write TOCTOU** — concurrent PATCHes last-writer-wins on the lifecycle merge. **Fix:** `SELECT … FOR UPDATE` / enclosing transaction. - **[P2] `upsertRun`/`createRunOrThrowConflict` check-then-create race** (`async-insight-store.ts`) — two callers can each create an "active" run. **Fix:** partial unique index on `(projectId, trigger) WHERE status IN ('pending','running')`. - **[P3] `createResearchRetryRun` return-value divergence** — sync returns the pre-update `queued` snapshot; async returns the reloaded `retry_waiting` run (persisted state is identical). Pick one side for cross-backend parity. - **[P2/perf] Mission `getMissionWithHierarchy`/`getMissionHealth` N+1 fan-out** — O(milestones×slices) sequential round-trips hold one pool slot per request; can starve the pool for large hierarchies. **Fix:** batched/joined reads. - **Testing gaps:** no PG-mode concurrency tests (interleaved status/event mutations), no sync↔async parity assertion for the lifecycle-error codes, and no mission status/health rollup parity test vs the sync `MissionStore`. ~~Out of scope (deferred): AI run *execution* (insight/research) + mission autopilot + live SSE mission events remain sync-gated/degraded in PG mode.~~ **Since ported** — insight/research run execution, mission autopilot, and SSE live push all run on the async layer now, which also makes the concurrency findings above genuinely reachable; they remain open follow-ups. --- ## Update — 2026-07-12: production-readiness hardening & live acceptance Everything below landed on this branch since the description above was written: **Production blockers from review — fixed** - `recoverStaleTransitionPending` ported to the async layer (backend moves write + clear the crash-safe marker; startup/maintenance sweeps no longer throw). - Lost-update class fixed: `atomicWriteTaskJson`/`WithAudit` write changed columns only (full-row upserts silently resurrected stale fields across concurrent store instances — the "task stuck unplanned forever" bug). - First-boot **auto-migration**: booting the PG backend over a project with a legacy `fusion.db` migrates it automatically (loud failure, SQLite kept as backup), and the dashboard shows a one-time **"your data was migrated" banner** with the backup paths and a Need-help Discord link. - `pg_dump`/`pg_restore` discovered from common install locations for embedded-mode backups. - The PG suite is part of the blocking merge gate (`test:pg-gate`). **Multi-project isolation (PR #2007, merged into this branch)** - `project_id` partition key on tasks / archived tasks / config, `taskProjectScope` threaded through every scan/claim/count, per-project config rows, layer bound to the project at startup. - Review P1 follow-up: the shared cold-storage `archive.archived_tasks` table is also partitioned and all archived-board reads/counts/searches are scoped. - Schema drift self-heal generalized to schema-qualified columns so existing databases upgrade in place. **Other changes** - Node settings sync **removed** in PG mode (409 `settings-sync-disabled-postgres`) — nodes share state by connecting to the same database; auth sync kept (per-machine file). - Perf (review findings): `listTasks` pushes column filter + ORDER BY + LIMIT/OFFSET into SQL; `getConversation` capped to the most recent 200 messages. - Fixed a false "operator action required" pause-abort log fired on every successfully auto-merged task. **Live acceptance — PASSED (2026-07-12)** A sandboxed instance (isolated HOME, embedded PG, real Opus executor) ran a task through the complete cycle: create → triage (AI spec) → execute → in-review → AI squash-merge landed on the project's `main` → done. A write+read sweep of every data surface (settings, comments, documents, attachments + artifact bridge + artifact edit, chat with real generation, goals, missions, agent mail, secrets, workflows, memory, CC analytics) was green on embedded PG. **Known remaining work** - The per-project `config` PK re-key has no upgrade path for pre-isolation embedded-PG databases (needs a real `DROP CONSTRAINT`/re-key migration; fresh databases are fine). - `pg_dump`/`pg_restore` binaries are not yet bundled in release artifacts (PATH/common-location discovery only). - The satellite-store concurrency findings listed above. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Phil Larson <hello@phillarson.xyz> Co-authored-by: fusion-merge <fusion-merge@local>
143 lines
5.7 KiB
TypeScript
143 lines
5.7 KiB
TypeScript
/**
|
|
* Credential redaction for PostgreSQL connection strings.
|
|
*
|
|
* FNXC:PostgresConnection 2026-06-24-01:40:
|
|
* The password portion of DATABASE_URL must never be written to logs.
|
|
* Connection-error messages and log-safe representations of connection strings
|
|
* must redact credentials so that a misconfigured or leaking log sink cannot
|
|
* expose the database password. This module provides pure-string helpers used
|
|
* by the connection layer and any diagnostic surface that references a URL.
|
|
*
|
|
* Supports two URL shapes:
|
|
* 1. `postgresql://user:password@host:port/db?params` (URL with userinfo)
|
|
* 2. Space-delimited key=value connection strings (e.g. `host=localhost password=secret`)
|
|
*
|
|
* Only the password/secret material is redacted. The host, port, database, and
|
|
* username are preserved because they are needed for actionable error messages
|
|
* and debugging without exposing credentials.
|
|
*/
|
|
|
|
/** The replacement text used in place of the actual password. */
|
|
export const REDACTED_PASSWORD_PLACEHOLDER = "********";
|
|
|
|
/**
|
|
* Redact the password from a standard `postgresql://` or `postgres://`
|
|
* connection string (URL form with userinfo).
|
|
*
|
|
* Returns the input unchanged if no userinfo password is present.
|
|
*
|
|
* @example
|
|
* redactUrlPassword("postgresql://user:s3cr3t@localhost:5432/fusion")
|
|
* // → "postgresql://user:********@localhost:5432/fusion"
|
|
*/
|
|
export function redactUrlPassword(url: string): string {
|
|
// Match the userinfo section of a postgres/postgresql scheme URL.
|
|
// userinfo = [user [: password]] @
|
|
// We only redact the password (after the first colon within userinfo).
|
|
// The regex captures:
|
|
// scheme:// + username + :password@ + rest
|
|
const urlPasswordRe =
|
|
/((?:postgres|postgresql):\/\/[^/\s:@]+):([^@\s]+)(@[^\s]*)/;
|
|
let result = url;
|
|
const match = urlPasswordRe.exec(result);
|
|
if (match) {
|
|
result = `${match[1]}:${REDACTED_PASSWORD_PLACEHOLDER}${match[3]}`;
|
|
}
|
|
// FNXC:CredentialRedact 2026-06-26-10:40:
|
|
// P1 fix (review #22): also redact `?password=` / `&password=` query-param
|
|
// passwords in URL-form connection strings. Some drivers/tools accept the
|
|
// password as a query parameter (e.g. postgresql://host:5432/db?password=secret)
|
|
// and the userinfo regex above does not cover that shape, so the password
|
|
// was logged verbatim by DatabaseConnectionError / describeBackendForLog.
|
|
result = redactUrlQueryPassword(result);
|
|
return result;
|
|
}
|
|
|
|
/**
|
|
* Redact a `password=` query parameter from a URL's query string.
|
|
*
|
|
* Handles both `?password=value` (first param) and `&password=value` (subsequent
|
|
* param). Only the value is redacted; the key and other params are preserved so
|
|
* the URL remains actionable for debugging.
|
|
*
|
|
* @example
|
|
* redactUrlQueryPassword("postgresql://h:5432/db?password=s3cr3t&sslmode=require")
|
|
* // → "postgresql://h:5432/db?password=********&sslmode=require"
|
|
*/
|
|
export function redactUrlQueryPassword(url: string): string {
|
|
// Match `password=` preceded by `?` or `&`, followed by a bare value that
|
|
// stops at `&`, `#`, or end of string. Query-param values are never quoted.
|
|
return url.replace(
|
|
/([?&]password=)([^&#\s]*)/gi,
|
|
`$1${REDACTED_PASSWORD_PLACEHOLDER}`,
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Redact the password from a space-delimited key=value connection string
|
|
* (the libpq keyword/value format: `host=localhost password=secret dbname=fusion`).
|
|
*
|
|
* @example
|
|
* redactKeywordPassword("host=localhost password=s3cr3t dbname=fusion")
|
|
* // → "host=localhost password=******** dbname=fusion"
|
|
*/
|
|
export function redactKeywordPassword(connStr: string): string {
|
|
// Match `password=` followed by a value that is either quoted or bare
|
|
// (stopping at whitespace or end of string).
|
|
return connStr.replace(
|
|
/((?:^|\s)password\s*=\s*)(?:"([^"]*)"|'([^']*)'|([^\s]+))/gi,
|
|
(_full, prefix: string) => `${prefix}${REDACTED_PASSWORD_PLACEHOLDER}`,
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Redact credentials from any connection string, handling both URL form
|
|
* (`postgresql://...`) and keyword/value form (`host=... password=...`).
|
|
*
|
|
* This is the primary safe-display entry point: use it whenever a connection
|
|
* string or URL fragment might be logged, included in an error message, or
|
|
* rendered in any diagnostic output.
|
|
*
|
|
* @example
|
|
* redactConnectionString("postgresql://user:pass@host/db")
|
|
* // → "postgresql://user:********@host/db"
|
|
*
|
|
* @example
|
|
* redactConnectionString("host=h password=p port=5432")
|
|
* // → "host=h password=******** port=5432"
|
|
*/
|
|
export function redactConnectionString(connStr: string): string {
|
|
const isUrlForm = /(postgres|postgresql):\/\//i.test(connStr);
|
|
if (isUrlForm) {
|
|
return redactUrlPassword(connStr);
|
|
}
|
|
return redactKeywordPassword(connStr);
|
|
}
|
|
|
|
/**
|
|
* Redact any plaintext password value that appears in an arbitrary error
|
|
* message or log text. This is the defensive fallback for connection errors
|
|
* thrown by the driver, which may embed the full connection string.
|
|
*
|
|
* It handles both URL-embedded passwords and keyword/value passwords, as well
|
|
* as bare password fragments that may appear in driver error messages.
|
|
*/
|
|
export function redactCredentialsFromMessage(text: string): string {
|
|
let result = text;
|
|
// URL form — userinfo password
|
|
result = result.replace(
|
|
/((?:postgres|postgresql):\/\/[^/\s:@]+):([^@\s]+)(@[^\s]*)/gi,
|
|
`$1:${REDACTED_PASSWORD_PLACEHOLDER}$3`,
|
|
);
|
|
// FNXC:CredentialRedact 2026-06-26-10:40:
|
|
// URL form — query-param password (?password= / &password=). Same gap as
|
|
// redactUrlPassword (review #22): driver errors can embed the full URL.
|
|
result = redactUrlQueryPassword(result);
|
|
// keyword/value form
|
|
result = result.replace(
|
|
/((?:^|\s)password\s*=\s*)(?:"([^"]*)"|'([^']*)'|([^\s]+))/gi,
|
|
`$1${REDACTED_PASSWORD_PLACEHOLDER}`,
|
|
);
|
|
return result;
|
|
}
|