Make Quick Chat and task popups honor their most recent interaction order. - Place Quick Chat in the task-detail peer stack while retaining higher utility windows. - Raise Create Room dialogs above Chat on each open, including mobile sheets. - Add stacking regression coverage and operator documentation with screenshots. Files changed: docs/assets/fn-8248-chat-above-task.png | Bin 0 -> 55108 bytes docs/assets/fn-8248-mobile-create-room.png | Bin 0 -> 56699 bytes docs/assets/fn-8248-task-above-chat.png | Bin 0 -> 74263 bytes docs/dashboard-guide.md | 5 +- packages/dashboard/app/App.tsx | 13 +++- .../dashboard/app/components/CreateRoomModal.tsx | 15 ++++- .../dashboard/app/components/FloatingWindow.tsx | 11 +++- .../components/__tests__/CreateRoomModal.test.tsx | 72 +++++++++++++++++++++ .../FloatingWindowStack.cross-type.test.tsx | 37 +++++++---- .../app/components/floatingWindowStack.ts | 10 +-- 10 files changed, 139 insertions(+), 24 deletions(-) Fusion-Task-Id: FN-8248 Fusion-Task-Lineage: 94ef20f1-96da-4249-9812-169f780c9451 Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
179 lines
7.3 KiB
TypeScript
179 lines
7.3 KiB
TypeScript
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
|
|
import { describe, expect, it, vi, beforeEach } from "vitest";
|
|
import { userEvent } from "@testing-library/user-event";
|
|
import { CreateRoomModal, validateRoomName } from "../CreateRoomModal";
|
|
import { FloatingWindow } from "../FloatingWindow";
|
|
import * as apiModule from "../../api";
|
|
|
|
vi.mock("../../api", () => ({
|
|
fetchAgents: vi.fn(),
|
|
}));
|
|
|
|
const mockFetchAgents = vi.mocked(apiModule.fetchAgents);
|
|
|
|
describe("validateRoomName", () => {
|
|
it.each([
|
|
["engineering", true],
|
|
["#engineering", true],
|
|
["team-1", true],
|
|
["a", true],
|
|
["Engineering", false],
|
|
["team room", false],
|
|
["-team", false],
|
|
["team-", false],
|
|
["_team", false],
|
|
["team_", false],
|
|
["", false],
|
|
["team😀", false],
|
|
["a".repeat(81), false],
|
|
])("validates %s", (value, expectedOk) => {
|
|
expect(validateRoomName(value).ok).toBe(expectedOk);
|
|
});
|
|
|
|
it("handles duplicate names case-insensitively", () => {
|
|
expect(validateRoomName("Engineering", ["engineering"]).ok).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("CreateRoomModal", () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
mockFetchAgents.mockResolvedValue([
|
|
{ id: "agent-1", name: "Alpha", role: "executor", state: "idle", metadata: {}, createdAt: "", updatedAt: "" },
|
|
{ id: "agent-2", name: "Beta", role: "reviewer", state: "idle", metadata: {}, createdAt: "", updatedAt: "" },
|
|
] as any);
|
|
});
|
|
|
|
it("renders nothing when closed", () => {
|
|
const { container } = render(<CreateRoomModal isOpen={false} onClose={vi.fn()} onCreate={vi.fn()} />);
|
|
expect(container).toBeEmptyDOMElement();
|
|
});
|
|
|
|
it("requires valid name and member before submit", async () => {
|
|
render(<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />);
|
|
const submit = await screen.findByRole("button", { name: "Create room" });
|
|
expect(submit).toBeDisabled();
|
|
|
|
await userEvent.type(screen.getByLabelText("Room name"), "engineering");
|
|
expect(submit).toBeDisabled();
|
|
|
|
await userEvent.click(screen.getByRole("button", { name: /Alpha/i }));
|
|
expect(submit).toBeEnabled();
|
|
});
|
|
|
|
it("submits selected draft payload", async () => {
|
|
const onCreate = vi.fn().mockResolvedValue(undefined);
|
|
render(<CreateRoomModal isOpen onClose={vi.fn()} onCreate={onCreate} />);
|
|
|
|
await userEvent.type(screen.getByLabelText("Room name"), "engineering");
|
|
await userEvent.click(await screen.findByRole("button", { name: /Alpha/i }));
|
|
await userEvent.click(screen.getByRole("button", { name: "Create room" }));
|
|
|
|
await waitFor(() => expect(onCreate).toHaveBeenCalledTimes(1));
|
|
expect(onCreate).toHaveBeenCalledWith({ name: "engineering", displayName: "#engineering", memberAgentIds: ["agent-1"] });
|
|
});
|
|
|
|
it("claims a fresh top layer above floating Chat on open and reopen", async () => {
|
|
const { rerender } = render(
|
|
<>
|
|
<FloatingWindow windowKey="chat-modal" title="Chat" onClose={() => {}} layer="task-detail" className="floating-window--chat">
|
|
<div>floating chat representative</div>
|
|
</FloatingWindow>
|
|
<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />
|
|
</>,
|
|
);
|
|
|
|
const chatPanel = screen.getByTestId("floating-window-chat-modal");
|
|
const firstOverlay = document.querySelector(".create-room-modal")?.parentElement as HTMLElement;
|
|
expect(Number(firstOverlay.style.zIndex)).toBeGreaterThan(Number(chatPanel.style.zIndex));
|
|
await screen.findByRole("button", { name: /Alpha/i });
|
|
|
|
// Another Chat interaction can claim its peer stack while the dialog is closed.
|
|
rerender(
|
|
<>
|
|
<FloatingWindow windowKey="chat-modal" title="Chat" onClose={() => {}} layer="task-detail" className="floating-window--chat">
|
|
<div>floating chat representative</div>
|
|
</FloatingWindow>
|
|
<CreateRoomModal isOpen={false} onClose={vi.fn()} onCreate={vi.fn()} />
|
|
</>,
|
|
);
|
|
fireEvent.pointerDown(chatPanel);
|
|
|
|
rerender(
|
|
<>
|
|
<FloatingWindow windowKey="chat-modal" title="Chat" onClose={() => {}} layer="task-detail" className="floating-window--chat">
|
|
<div>floating chat representative</div>
|
|
</FloatingWindow>
|
|
<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />
|
|
</>,
|
|
);
|
|
|
|
const reopenedOverlay = document.querySelector(".create-room-modal")?.parentElement as HTMLElement;
|
|
expect(Number(reopenedOverlay.style.zIndex)).toBeGreaterThan(Number(chatPanel.style.zIndex));
|
|
expect(Number(reopenedOverlay.style.zIndex)).toBeGreaterThan(Number(firstOverlay.style.zIndex));
|
|
});
|
|
|
|
it("stays above floating Chat while agent data is loading or empty", async () => {
|
|
mockFetchAgents.mockImplementation(() => new Promise(() => {}));
|
|
const loading = render(
|
|
<>
|
|
<FloatingWindow windowKey="chat-loading" title="Chat" onClose={() => {}} layer="task-detail" className="floating-window--chat">
|
|
<div>floating chat representative</div>
|
|
</FloatingWindow>
|
|
<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />
|
|
</>,
|
|
);
|
|
|
|
const loadingOverlay = document.querySelector(".create-room-modal")?.parentElement as HTMLElement;
|
|
expect(screen.getByRole("status")).toHaveTextContent("Loading agents...");
|
|
expect(Number(loadingOverlay.style.zIndex)).toBeGreaterThan(Number(screen.getByTestId("floating-window-chat-loading").style.zIndex));
|
|
loading.unmount();
|
|
|
|
mockFetchAgents.mockResolvedValueOnce([]);
|
|
render(
|
|
<>
|
|
<FloatingWindow windowKey="chat-empty" title="Chat" onClose={() => {}} layer="task-detail" className="floating-window--chat">
|
|
<div>floating chat representative</div>
|
|
</FloatingWindow>
|
|
<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />
|
|
</>,
|
|
);
|
|
|
|
const emptyOverlay = document.querySelector(".create-room-modal")?.parentElement as HTMLElement;
|
|
expect(await screen.findByText("No agents in this project yet.")).toBeInTheDocument();
|
|
expect(Number(emptyOverlay.style.zIndex)).toBeGreaterThan(Number(screen.getByTestId("floating-window-chat-empty").style.zIndex));
|
|
});
|
|
|
|
it("closes on escape and overlay click", async () => {
|
|
const onClose = vi.fn();
|
|
render(<CreateRoomModal isOpen onClose={onClose} onCreate={vi.fn()} />);
|
|
|
|
fireEvent.keyDown(document, { key: "Escape" });
|
|
expect(onClose).toHaveBeenCalledTimes(1);
|
|
|
|
fireEvent.click(document.querySelector(".modal-overlay.open") as Element);
|
|
expect(onClose).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it("shows search-specific empty state copy", async () => {
|
|
render(<CreateRoomModal isOpen onClose={vi.fn()} onCreate={vi.fn()} />);
|
|
|
|
await screen.findByRole("button", { name: /Alpha/i });
|
|
await userEvent.type(screen.getByLabelText("Members"), "zzz");
|
|
|
|
expect(screen.getByText("No agents match your search.")).toBeInTheDocument();
|
|
});
|
|
|
|
it("keeps open and shows error when create fails", async () => {
|
|
const onCreate = vi.fn().mockRejectedValue(new Error("boom"));
|
|
render(<CreateRoomModal isOpen onClose={vi.fn()} onCreate={onCreate} />);
|
|
|
|
await userEvent.type(screen.getByLabelText("Room name"), "engineering");
|
|
await userEvent.click(await screen.findByRole("button", { name: /Alpha/i }));
|
|
await userEvent.click(screen.getByRole("button", { name: "Create room" }));
|
|
|
|
expect(await screen.findByText("boom")).toBeInTheDocument();
|
|
expect(screen.getByRole("dialog")).toBeInTheDocument();
|
|
});
|
|
});
|