Files
fusion/packages/dashboard/app/components/__tests__/SetupWarningBanner.test.tsx
gsxdsm 50786f29d4 FN-7475: delay GitHub setup warnings
Delay dashboard GitHub setup warnings until the project grace period expires while keeping AI setup warnings immediate.

- Add per-project GitHub warning delay state and persistence.
- Route dashboard GitHub warnings to Settings → Authentication with a Connect GitHub action.
- Hide non-actionable GitHub-only warnings in the New Task modal and update localized copy, docs, and tests.

Files changed:
 .changeset/fn-7475-github-setup-warning.md         |   7 ++
 docs/dashboard-guide.md                            |   6 +
 packages/dashboard/app/App.tsx                     |  11 +-
 packages/dashboard/app/components/NewTaskModal.tsx |   8 +-
 .../app/components/SetupWarningBanner.css          |  10 ++
 .../app/components/SetupWarningBanner.tsx          |  18 ++-
 .../app/components/__tests__/NewTaskModal.test.tsx |  46 ++++++-
 .../__tests__/SetupWarningBanner.test.tsx          |  40 ++++++
 .../app/components/dashboard/DashboardBanners.tsx  |   3 +
 .../dashboard/__tests__/DashboardBanners.test.tsx  | 125 ++++++++++++++++++-
 .../dashboard/app/components/dashboard/types.ts    |   1 +
 .../__tests__/useGithubSetupWarningDelay.test.ts   | 134 +++++++++++++++++++++
 .../app/hooks/useGithubSetupWarningDelay.ts        |  96 +++++++++++++++
 packages/dashboard/app/utils/projectStorage.ts     |   1 +
 packages/i18n/locales/en/app.json                  |   5 +-
 packages/i18n/locales/es/app.json                  |   5 +-
 packages/i18n/locales/fr/app.json                  |   5 +-
 packages/i18n/locales/ko/app.json                  |   5 +-
 packages/i18n/locales/zh-CN/app.json               |   5 +-
 packages/i18n/locales/zh-TW/app.json               |   5 +-
 packages/i18n/src/resources.d.ts                   | 127 +++++++++++++------
 21 files changed, 606 insertions(+), 57 deletions(-)

Fusion-Task-Id: FN-7475
Fusion-Task-Lineage: 5bf1fffa-b58c-42a1-b170-367a4c20eaaf
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
2026-07-03 21:45:21 -07:00

180 lines
6.1 KiB
TypeScript

import { describe, it, expect, vi } from "vitest";
import { fireEvent, render, screen } from "@testing-library/react";
import { SetupWarningBanner } from "../SetupWarningBanner";
describe("SetupWarningBanner", () => {
it("returns null when both hasAiProvider and hasGithub are true", () => {
const { container } = render(
<SetupWarningBanner hasAiProvider hasGithub />,
);
expect(container.firstChild).toBeNull();
});
it("shows AI provider warning when hasAiProvider is false and hasGithub is true", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub />);
expect(screen.getByText("No AI provider connected")).toBeInTheDocument();
expect(
screen.getByText(
"AI agents won't be able to work on tasks until you connect a provider. Set one up in Settings → AI Setup.",
),
).toBeInTheDocument();
expect(screen.queryByText("GitHub not connected")).toBeNull();
});
it("shows GitHub warning when hasGithub is false and hasAiProvider is true", () => {
render(<SetupWarningBanner hasAiProvider hasGithub={false} />);
expect(screen.getByText("GitHub not connected")).toBeInTheDocument();
expect(
screen.getByText(
"You won't be able to import issues from GitHub, but you can still create tasks manually.",
),
).toBeInTheDocument();
expect(screen.queryByText("No AI provider connected")).toBeNull();
});
it("omits GitHub warning and empty shell when the grace period has not elapsed", () => {
const { container } = render(<SetupWarningBanner hasAiProvider hasGithub={false} showGithubWarning={false} />);
expect(container.firstChild).toBeNull();
expect(screen.queryByText("GitHub not connected")).toBeNull();
});
it("preserves the AI warning while GitHub is hidden by the grace period", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub={false} showGithubWarning={false} />);
expect(screen.getByText("No AI provider connected")).toBeInTheDocument();
expect(screen.queryByText("GitHub not connected")).toBeNull();
});
it("shows both warnings when both providers are missing", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub={false} />);
expect(screen.getByText("No AI provider connected")).toBeInTheDocument();
expect(screen.getByText("GitHub not connected")).toBeInTheDocument();
});
it("compact mode renders a single-line summary", () => {
render(
<SetupWarningBanner hasAiProvider={false} hasGithub compact />,
);
expect(
screen.getByText("⚠ Setup incomplete — AI and/or GitHub features will be limited."),
).toBeInTheDocument();
expect(screen.queryByText("No AI provider connected")).toBeNull();
});
it("full mode renders setup-warning-banner class with expected structure", () => {
const { container } = render(
<SetupWarningBanner hasAiProvider={false} hasGithub={false} />,
);
const banner = container.querySelector(".setup-warning-banner");
const items = container.querySelectorAll(".setup-warning-banner__item");
expect(banner).toBeTruthy();
expect(items).toHaveLength(2);
});
it("has role=status and aria-live=polite for accessibility", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub />);
const banner = screen.getByRole("status");
expect(banner).toHaveAttribute("aria-live", "polite");
});
it("does not render dismiss button when onDismiss is not provided", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub />);
expect(
screen.queryByRole("button", { name: "Dismiss setup warning" }),
).toBeNull();
});
it("renders dismiss button when onDismiss is provided (full mode)", () => {
const onDismiss = vi.fn();
render(
<SetupWarningBanner
hasAiProvider={false}
hasGithub
onDismiss={onDismiss}
/>,
);
const dismissButton = screen.getByRole("button", {
name: "Dismiss setup warning",
});
expect(dismissButton).toBeInTheDocument();
fireEvent.click(dismissButton);
expect(onDismiss).toHaveBeenCalledTimes(1);
});
it("renders dismiss button when onDismiss is provided (compact mode)", () => {
const onDismiss = vi.fn();
render(
<SetupWarningBanner
hasAiProvider={false}
hasGithub
compact
onDismiss={onDismiss}
/>,
);
const dismissButton = screen.getByRole("button", {
name: "Dismiss setup warning",
});
expect(dismissButton).toBeInTheDocument();
fireEvent.click(dismissButton);
expect(onDismiss).toHaveBeenCalledTimes(1);
});
it("renders a GitHub connect button only when GitHub warning is visible and action is available", () => {
const onConnectGithub = vi.fn();
render(<SetupWarningBanner hasAiProvider hasGithub={false} onConnectGithub={onConnectGithub} />);
const connectButton = screen.getByRole("button", { name: "Connect GitHub" });
expect(connectButton).toHaveAttribute("type", "button");
fireEvent.click(connectButton);
expect(onConnectGithub).toHaveBeenCalledTimes(1);
});
it("does not render an empty GitHub connect shell when action is unavailable", () => {
const { container } = render(<SetupWarningBanner hasAiProvider hasGithub={false} />);
expect(screen.queryByRole("button", { name: "Connect GitHub" })).toBeNull();
expect(container.querySelector(".setup-warning-banner__actions")).toBeNull();
});
it("does not render hidden GitHub connect controls during the grace period", () => {
render(<SetupWarningBanner hasAiProvider={false} hasGithub={false} showGithubWarning={false} onConnectGithub={vi.fn()} />);
expect(screen.queryByText("GitHub not connected")).toBeNull();
expect(screen.queryByRole("button", { name: "Connect GitHub" })).toBeNull();
});
it("clicking dismiss button calls onDismiss", () => {
const onDismiss = vi.fn();
render(
<SetupWarningBanner
hasAiProvider={false}
hasGithub={false}
onDismiss={onDismiss}
/>,
);
fireEvent.click(screen.getByRole("button", { name: "Dismiss setup warning" }));
expect(onDismiss).toHaveBeenCalledTimes(1);
});
});