Files
fusion/packages/dashboard/app/hooks/__tests__/useGithubSetupWarningDelay.test.ts
gsxdsm 50786f29d4 FN-7475: delay GitHub setup warnings
Delay dashboard GitHub setup warnings until the project grace period expires while keeping AI setup warnings immediate.

- Add per-project GitHub warning delay state and persistence.
- Route dashboard GitHub warnings to Settings → Authentication with a Connect GitHub action.
- Hide non-actionable GitHub-only warnings in the New Task modal and update localized copy, docs, and tests.

Files changed:
 .changeset/fn-7475-github-setup-warning.md         |   7 ++
 docs/dashboard-guide.md                            |   6 +
 packages/dashboard/app/App.tsx                     |  11 +-
 packages/dashboard/app/components/NewTaskModal.tsx |   8 +-
 .../app/components/SetupWarningBanner.css          |  10 ++
 .../app/components/SetupWarningBanner.tsx          |  18 ++-
 .../app/components/__tests__/NewTaskModal.test.tsx |  46 ++++++-
 .../__tests__/SetupWarningBanner.test.tsx          |  40 ++++++
 .../app/components/dashboard/DashboardBanners.tsx  |   3 +
 .../dashboard/__tests__/DashboardBanners.test.tsx  | 125 ++++++++++++++++++-
 .../dashboard/app/components/dashboard/types.ts    |   1 +
 .../__tests__/useGithubSetupWarningDelay.test.ts   | 134 +++++++++++++++++++++
 .../app/hooks/useGithubSetupWarningDelay.ts        |  96 +++++++++++++++
 packages/dashboard/app/utils/projectStorage.ts     |   1 +
 packages/i18n/locales/en/app.json                  |   5 +-
 packages/i18n/locales/es/app.json                  |   5 +-
 packages/i18n/locales/fr/app.json                  |   5 +-
 packages/i18n/locales/ko/app.json                  |   5 +-
 packages/i18n/locales/zh-CN/app.json               |   5 +-
 packages/i18n/locales/zh-TW/app.json               |   5 +-
 packages/i18n/src/resources.d.ts                   | 127 +++++++++++++------
 21 files changed, 606 insertions(+), 57 deletions(-)

Fusion-Task-Id: FN-7475
Fusion-Task-Lineage: 5bf1fffa-b58c-42a1-b170-367a4c20eaaf
Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
2026-07-03 21:45:21 -07:00

135 lines
4.4 KiB
TypeScript

import { renderHook } from "@testing-library/react";
import { beforeEach, describe, expect, it, vi } from "vitest";
import {
GITHUB_SETUP_WARNING_DELAY_MS,
GITHUB_SETUP_WARNING_MISSING_SINCE_KEY,
useGithubSetupWarningDelay,
} from "../useGithubSetupWarningDelay";
import { scopedKey } from "../../utils/projectStorage";
function renderDelay(options: {
projectId?: string;
hasGithub?: boolean;
loading?: boolean;
nowMs?: number;
}) {
const now = vi.fn(() => options.nowMs ?? 1_000_000);
return renderHook(
({ projectId, hasGithub, loading, nowMs }) => useGithubSetupWarningDelay({
projectId,
hasGithub: hasGithub ?? false,
loading: loading ?? false,
now: () => nowMs ?? now(),
}),
{ initialProps: options },
);
}
describe("useGithubSetupWarningDelay", () => {
beforeEach(() => {
vi.useRealTimers();
window.localStorage.clear();
});
it("does not show immediately and records the first missing timestamp for the project", () => {
const { result } = renderDelay({ projectId: "proj-a", hasGithub: false, nowMs: 10_000 });
expect(result.current).toBe(false);
expect(window.localStorage.getItem(scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"))).toBe("10000");
});
it("shows after GitHub has been missing for the full 24-hour threshold", () => {
window.localStorage.setItem(
scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"),
String(10_000),
);
const { result } = renderDelay({
projectId: "proj-a",
hasGithub: false,
nowMs: 10_000 + GITHUB_SETUP_WARNING_DELAY_MS,
});
expect(result.current).toBe(true);
});
it("keeps separate timestamps when switching projects", () => {
window.localStorage.setItem(
scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"),
String(10_000),
);
const { result, rerender } = renderDelay({
projectId: "proj-a",
hasGithub: false,
nowMs: 10_000 + GITHUB_SETUP_WARNING_DELAY_MS,
});
expect(result.current).toBe(true);
rerender({ projectId: "proj-b", hasGithub: false, loading: false, nowMs: 20_000 });
expect(result.current).toBe(false);
expect(window.localStorage.getItem(scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-b"))).toBe("20000");
});
it("clears the missing timestamp and hides the warning when GitHub becomes connected", () => {
window.localStorage.setItem(
scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"),
String(10_000),
);
const { result, rerender } = renderDelay({
projectId: "proj-a",
hasGithub: false,
nowMs: 10_000 + GITHUB_SETUP_WARNING_DELAY_MS,
});
expect(result.current).toBe(true);
rerender({ projectId: "proj-a", hasGithub: true, loading: false, nowMs: 10_000 + GITHUB_SETUP_WARNING_DELAY_MS });
expect(result.current).toBe(false);
expect(window.localStorage.getItem(scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"))).toBeNull();
});
it("does not start the grace period while readiness is loading", () => {
const { result } = renderDelay({ projectId: "proj-a", hasGithub: false, loading: true, nowMs: 10_000 });
expect(result.current).toBe(false);
expect(window.localStorage.getItem(scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"))).toBeNull();
});
it("does not leak undefined project state into project-scoped storage", () => {
const { result } = renderDelay({ hasGithub: false, nowMs: 10_000 });
expect(result.current).toBe(false);
expect(window.localStorage.getItem(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY)).toBeNull();
});
it("keeps a young missing timestamp hidden before the threshold", () => {
window.localStorage.setItem(
scopedKey(GITHUB_SETUP_WARNING_MISSING_SINCE_KEY, "proj-a"),
String(10_000),
);
const { result } = renderDelay({
projectId: "proj-a",
hasGithub: false,
nowMs: 10_000 + GITHUB_SETUP_WARNING_DELAY_MS - 1,
});
expect(result.current).toBe(false);
});
it("falls back without crashing when scoped storage reads fail", () => {
const getItemSpy = vi.spyOn(Storage.prototype, "getItem").mockImplementation(() => {
throw new Error("storage denied");
});
const { result } = renderDelay({ projectId: "proj-a", hasGithub: false, nowMs: 10_000 });
expect(result.current).toBe(false);
getItemSpy.mockRestore();
});
});