Files
fusion/packages/dashboard/app/components/__tests__/SettingsModal.cliBinaryVisibility.test.tsx
gsxdsm cc97970b1d test: use fast user-event instance in SettingsModal CLI-binary tests
Align SettingsModal.cliBinaryVisibility.test.tsx with the harness's
documented fast user-event options ({ delay: null, pointerEventsCheck: 0 },
FN-6612 velocity convention). Removes default inter-keystroke delay and
pointer-events tree walks; file test-time dropped ~1.9s -> ~0.5s.
2026-08-06 17:06:37 -07:00

130 lines
5.7 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
import { render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import { SettingsModal } from "../SettingsModal";
const mockFetchSettings = vi.fn();
const mockFetchSettingsByScope = vi.fn();
vi.mock("../../api", async (importOriginal) => {
const { createDashboardApiMock } = await import("../../test/mockApi");
return createDashboardApiMock(() => importOriginal<typeof import("../../api")>(), {
fetchSettings: (...args: unknown[]) => mockFetchSettings(...args),
fetchSettingsByScope: (...args: unknown[]) => mockFetchSettingsByScope(...args),
});
});
vi.mock("../../api/legacy", () => ({
fetchCodebaseMetrics: vi.fn().mockResolvedValue({ tokenEstimate: 0, sourceFileCount: 0, sourceByteCount: 0, diskBytes: 0, diskFileCount: 0, method: "local", truncated: false }),
fetchFnBinaryStatus: vi.fn(() => Promise.resolve({
binary: { binary: "fn", installed: false, path: null, version: null },
expectedVersion: "1.2.3",
state: "missing",
install: { command: "npm install -g runfusion.ai" },
})),
installFnBinary: vi.fn(),
}));
vi.mock("../../hooks/useMemoryBackendStatus", () => ({
useMemoryBackendStatus: () => ({ status: null, capabilities: null, loading: false, error: null, refresh: vi.fn() }),
}));
vi.mock("../../hooks/useViewportMode", () => ({
MOBILE_MEDIA_QUERY: "(max-width: 768px), (max-height: 480px)",
isFullScreenSheetViewport: () => false,
isShortViewport: () => false,
isTabletTouchViewport: (mode?: string) => mode === "tablet",
useViewportMode: () => "desktop",
getViewportMode: () => "desktop",
isMobileViewport: () => false,
}));
vi.mock("../../hooks/useMobileKeyboard", () => ({
useMobileKeyboard: () => ({ keyboardOverlap: 0, viewportHeight: null, viewportOffsetTop: 0, keyboardOpen: false }),
}));
vi.mock("../../hooks/useMobileScrollLock", () => ({
useMobileScrollLock: vi.fn(),
useMobileKeyboardViewportLock: vi.fn(),
useMobileViewportRestoreReset: vi.fn(),
}));
vi.mock("../../hooks/useConfirm", () => ({ useConfirm: () => ({ confirm: vi.fn() }) }));
vi.mock("../../hooks/useWorkspaceFileBrowser", () => ({
useWorkspaceFileBrowser: () => ({ entries: [], currentPath: ".", setPath: vi.fn(), loading: false, error: null, refresh: vi.fn() }),
}));
vi.mock("../../hooks/useWorktrunkInstallStatus", () => ({
useWorktrunkInstallStatus: () => ({ status: "idle", requestInstall: vi.fn() }),
}));
function buildSettings() {
return {
autoMerge: true,
maxConcurrent: 2,
maxWorktrees: 4,
pollIntervalMs: 15000,
heartbeatMultiplier: 1,
groupOverlappingFiles: true,
overlapIgnorePaths: [],
mergeStrategy: "direct",
mergeIntegrationWorktree: "reuse-task-worktree",
recycleWorktrees: false,
executorAllowSiblingBranchRename: false,
worktreeNaming: "random",
worktreesDir: "",
worktrunk: { enabled: false, binaryPath: "", onFailure: "fail" },
includeTaskIdInCommit: true,
ntfyEnabled: false,
failureNotificationMode: "sticky-only",
failureNotificationDelayMs: 30000,
webhookEnabled: false,
experimentalFeatures: {},
};
}
async function renderBasicSettings() {
const view = render(<SettingsModal onClose={vi.fn()} addToast={vi.fn()} />);
await waitFor(() => expect(mockFetchSettings).toHaveBeenCalled());
return view;
}
describe("SettingsModal CLI Binary visibility", () => {
beforeEach(() => {
vi.clearAllMocks();
localStorage.removeItem("fusion:settings:show-advanced");
mockFetchSettings.mockResolvedValue(buildSettings());
mockFetchSettingsByScope.mockResolvedValue({ global: {}, project: {} });
});
it("keeps CLI Binary reachable from the Basic-mode desktop nav", async () => {
// FNXC:SettingsModalTests 2026-08-07-00:06: match the harness's fast user-event instance (FN-6612 feedback-loop velocity); the SettingsModal split files are the dashboard's slowest tests when they use default user-event delays and pointer-events tree walks.
const user = userEvent.setup({ delay: null, pointerEventsCheck: 0 });
await renderBasicSettings();
expect(screen.getByRole("checkbox", { name: "Advanced settings" })).not.toBeChecked();
// FNXC:SettingsModalTests 2026-07-28-17:20: FN-8606 portals the modal branch (FloatingWindow) to document.body, so modal-internal nodes resolve from the document root, not the render container.
expect(document.querySelector(".settings-mobile-section-picker")).toBeNull();
await user.click(screen.getByRole("button", { name: /CLI Binary$/ }));
expect(await screen.findByText(/Installing the global CLI lets you run fn and fusion/)).toBeInTheDocument();
expect(document.querySelector(".cli-binary-panel")).toBeTruthy();
});
it("returns CLI Binary for a Basic-mode search and lets operators open it", async () => {
const user = userEvent.setup({ delay: null, pointerEventsCheck: 0 });
await renderBasicSettings();
expect(document.querySelector(".settings-mobile-section-picker")).toBeNull();
await user.type(screen.getByTestId("settings-search-input"), "binary check");
const cliBinaryNav = await screen.findByRole("button", { name: /CLI Binary$/ });
await user.click(cliBinaryNav);
expect(await screen.findByText(/Installing the global CLI lets you run fn and fusion/)).toBeInTheDocument();
});
it("keeps CLI Binary available after Advanced settings is enabled", async () => {
const user = userEvent.setup({ delay: null, pointerEventsCheck: 0 });
await renderBasicSettings();
await user.click(screen.getByRole("checkbox", { name: "Advanced settings" }));
expect(screen.getByRole("checkbox", { name: "Advanced settings" })).toBeChecked();
expect(screen.getByRole("button", { name: /CLI Binary$/ })).toBeInTheDocument();
});
});