An 11-reviewer pass over f157bf7460..f5163d8351 found defects in the mobile tab-discard change set itself. This fixes them. Silent data loss (the recurring defect class): - AgentDetailView reconnect refetched limit:100 and replaced wholesale, so 380 displayed lines vanished with no "Load older" and no indicator; it now reconciles through the shared logStreamReconcile helper. - useActivityLog.loadMore past the cap discarded the page it had just fetched while advancing the cursor and leaving hasMore true, so the feed silently stopped paginating behind a live-looking button. - useAgentLogs: loadMore and resyncFromServer had no mutual exclusion, a no-overlap resync discarded explicitly paged-back history, a resync outliving the reconnect delay left an unmarked gap, and the live-tail trim could evict the gap marker itself. - useLiveTranscript's resync overwrote live entries that raced the refetch. The premise itself was not fully delivered: - useProjects, useNodes, and useMeshState never called clearInterval, so they polled the whole time the tab was hidden. useProjects is mounted for the entire session, so the page never went idle -- the primary mechanism this work depends on. All three now use the shared visibility gate. - sse-bus fired onReconnect twice per reconnect cycle and fanned out ~28 subscribers in one tick, against a ~6-connection-per-origin cap on a waking radio. The successful open is now the single authority, and the fan-out uses the same exported stagger primitive as the polling path rather than a second copy of the slot formula. - A channel first subscribed during the hidden window opened a live EventSource and keepalive; suspension is now a module-level condition openChannel consults, and a channel opened inside the grace window re-arms it. Credentials and correctness: - The service worker persisted every GET /api/* to durable Cache Storage, including /api/settings with daemonToken, githubAuthToken, gitlabAuthToken and ntfyAccessToken in plaintext, with no exclusion and no purge path -- "Clear all cached data" only walked localStorage. Now gated, bounded, and genuinely purgeable. - useTasks cleared its own snapshot when the mount revalidation failed on a waking radio, so the board blanked and the next restore was empty too. Suspension-class failures no longer destroy the cache. - A single-row SSE update reset lastFetchTimeMs to now while an hours-old hydrated snapshot was on screen, re-marking every in-progress card stuck. - ListView's "Select all visible tasks" acted on the full filtered set while only 50 rows rendered, so a bulk delete reached rows the operator could not see. Column's search window reset keyed on a boolean, so refining a query kept the expanded window. Tests that could not fail: - App.test.tsx mocked TerminalModal as isOpen ? <div/> : null, making the unmount-on-close invariant unobservable; MockEventSource kept its listeners after close(), so cases passed with their onReconnect handlers deleted. - The SSE resync ratchet scanned only hooks/, exempting ~13 component call sites -- the exact regression it exists to prevent. - MissionControlPanel's bespoke poll and the xterm scrollback constants and WebGL disposal had no coverage at all. Verified: tsc -p tsconfig.app.json clean, pnpm lint clean, pnpm check:changesets clean, 877 tests passing across 36 scoped files. Known unrelated red: MailboxView.test.tsx's FN-8407 CSS guard fails at HEAD too -- this diff adds no @media rule and no .mailbox-view--mobile selector, the only two things that assertion inspects. Left alone deliberately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
204 lines
7.4 KiB
TypeScript
204 lines
7.4 KiB
TypeScript
import { useState, useEffect, useCallback, useRef } from "react";
|
|
import type { ActivityFeedEntry } from "../api";
|
|
import { fetchActivityFeed, fetchActivityLog } from "../api";
|
|
import { useVisibilityAwarePoll } from "./visibilitySuspension";
|
|
|
|
export interface UseActivityLogResult {
|
|
/** Activity log entries */
|
|
entries: ActivityFeedEntry[];
|
|
/** Loading state */
|
|
loading: boolean;
|
|
/** Error message if fetch failed */
|
|
error: string | null;
|
|
/** Manually refresh activity log */
|
|
refresh: () => Promise<void>;
|
|
/** Clear all entries from state */
|
|
clear: () => void;
|
|
/** Whether there are more entries to load */
|
|
hasMore: boolean;
|
|
/** Load more (older) entries */
|
|
loadMore: () => Promise<void>;
|
|
}
|
|
|
|
const POLL_INTERVAL_MS = 5000; // 5 seconds
|
|
/** Upper bound on retained activity entries; matches the 500-line cap in useMultiAgentLogs. */
|
|
const MAX_RETAINED_ENTRIES = 500;
|
|
|
|
export interface UseActivityLogOptions {
|
|
/** Filter by project ID (used with unified central feed) */
|
|
projectId?: string;
|
|
/** Filter by event type */
|
|
type?: ActivityFeedEntry["type"];
|
|
/** Number of entries to fetch per page */
|
|
limit?: number;
|
|
/** Whether to auto-refresh */
|
|
autoRefresh?: boolean;
|
|
/**
|
|
* When true, fetch from the unified central activity feed (/api/activity-feed).
|
|
* When false (default), fetch from the per-project activity log (/api/activity).
|
|
*
|
|
* Set to true when the modal operates in a multi-project context (projects
|
|
* list provided) so it reads from the unified feed. Default (false) reads
|
|
* from the per-project log which is always populated with task events.
|
|
*/
|
|
useCentralFeed?: boolean;
|
|
}
|
|
|
|
/**
|
|
* Hook for fetching and managing the activity log.
|
|
* Automatically polls for updates every 5 seconds when enabled.
|
|
* Supports filtering by project and event type.
|
|
*
|
|
* Data source selection:
|
|
* - Default (single-project): reads from per-project activity log (/api/activity)
|
|
* which is always populated with task lifecycle events for the current project.
|
|
* - Multi-project (useCentralFeed=true): reads from unified activity feed
|
|
* (/api/activity-feed) which aggregates activity across all registered projects.
|
|
*/
|
|
export function useActivityLog(options: UseActivityLogOptions = {}): UseActivityLogResult {
|
|
const { projectId, type, limit = 50, autoRefresh = true, useCentralFeed = false } = options;
|
|
|
|
const [entries, setEntries] = useState<ActivityFeedEntry[]>([]);
|
|
const [loading, setLoading] = useState(false);
|
|
const [error, setError] = useState<string | null>(null);
|
|
const [hasMore, setHasMore] = useState(false);
|
|
const lastTimestampRef = useRef<string | undefined>(undefined);
|
|
|
|
/**
|
|
* Fetch entries using the appropriate data source.
|
|
*
|
|
* Per-project log (/api/activity) — the default — reads directly from the
|
|
* project's own SQLite database and always contains task lifecycle events.
|
|
*
|
|
* Unified feed (/api/activity-feed) reads from the central database and
|
|
* supports cross-project aggregation.
|
|
*/
|
|
const refresh = useCallback(async () => {
|
|
try {
|
|
setLoading(true);
|
|
setError(null);
|
|
|
|
let data: ActivityFeedEntry[];
|
|
|
|
if (useCentralFeed) {
|
|
data = await fetchActivityFeed({ limit, projectId, type });
|
|
} else {
|
|
// Per-project: fetchActivityLog returns ActivityLogEntry[] which is a
|
|
// subset of ActivityFeedEntry (missing projectId/projectName). Map to
|
|
// the full shape so downstream consumers see a uniform interface.
|
|
const logEntries = await fetchActivityLog({ limit, type, projectId });
|
|
data = logEntries.map((entry) => ({
|
|
...entry,
|
|
projectId: projectId ?? "",
|
|
projectName: "",
|
|
}));
|
|
}
|
|
|
|
setEntries(data);
|
|
setHasMore(data.length === limit);
|
|
|
|
if (data.length > 0) {
|
|
lastTimestampRef.current = data[data.length - 1].timestamp;
|
|
}
|
|
} catch (err) {
|
|
setError(err instanceof Error ? err.message : "Failed to load activity log");
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, [limit, projectId, type, useCentralFeed]);
|
|
|
|
const loadMore = useCallback(async () => {
|
|
if (!lastTimestampRef.current) return;
|
|
|
|
try {
|
|
setLoading(true);
|
|
|
|
let data: ActivityFeedEntry[];
|
|
|
|
if (useCentralFeed) {
|
|
data = await fetchActivityFeed({
|
|
limit,
|
|
projectId,
|
|
type,
|
|
since: lastTimestampRef.current,
|
|
});
|
|
} else {
|
|
const logEntries = await fetchActivityLog({
|
|
limit,
|
|
type,
|
|
since: lastTimestampRef.current,
|
|
projectId,
|
|
});
|
|
data = logEntries.map((entry) => ({
|
|
...entry,
|
|
projectId: projectId ?? "",
|
|
projectName: "",
|
|
}));
|
|
}
|
|
|
|
/*
|
|
FNXC:MobileTabRetention 2026-07-26-10:22:
|
|
loadMore appended pages unbounded, so a long session grew the entry array without limit and inflated
|
|
the page's resident set — large-memory pages are the second discard trigger on mobile. Cap retained
|
|
entries at MAX_RETAINED_ENTRIES (same bound as useMultiAgentLogs).
|
|
|
|
FNXC:ActivityLogPaging 2026-07-26-18:30:
|
|
CORRECTION to the note above, which claimed "the cap truncates the tail rather than evicting what is
|
|
on screen" and used `merged.slice(0, MAX_RETAINED_ENTRIES)`. That was wrong in the only case where
|
|
the cap actually bites: the tail being truncated IS the page loadMore just fetched. At the cap
|
|
(limit 50 -> the 11th click) every further click fetched 50 older entries, dropped all 50, advanced
|
|
`lastTimestampRef` past them, and left `hasMore` true — so the feed stopped paginating while still
|
|
offering a "Load more" button that provably did nothing, and the skipped entries became unreachable
|
|
because the cursor had already moved beyond them.
|
|
Drop from the HEAD instead (`slice(-MAX)`): the appended older page survives, so the control keeps
|
|
doing what it exists for — paging backwards. Evicting the newest entries is the recoverable
|
|
direction: `refresh` (manual, and the 5s visibility-aware poll) refetches the newest page from
|
|
offset 0 and resets the buffer, so anything dropped off the head comes straight back.
|
|
*/
|
|
setEntries((prev) => {
|
|
const merged = [...prev, ...data];
|
|
return merged.length > MAX_RETAINED_ENTRIES ? merged.slice(-MAX_RETAINED_ENTRIES) : merged;
|
|
});
|
|
setHasMore(data.length === limit);
|
|
|
|
if (data.length > 0) {
|
|
lastTimestampRef.current = data[data.length - 1].timestamp;
|
|
}
|
|
} catch (err) {
|
|
setError(err instanceof Error ? err.message : "Failed to load more entries");
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, [limit, projectId, type, useCentralFeed]);
|
|
|
|
const clear = useCallback(() => {
|
|
setEntries([]);
|
|
setHasMore(false);
|
|
lastTimestampRef.current = undefined;
|
|
}, []);
|
|
|
|
// Initial fetch
|
|
useEffect(() => {
|
|
refresh();
|
|
}, [refresh]);
|
|
|
|
/*
|
|
FNXC:MobileTabRetention 2026-07-26-10:18:
|
|
Auto-refresh polling must stop while the tab is backgrounded. A page that keeps fetching in the
|
|
background is a primary discard signal on iOS Safari/PWA and Chrome Android, which is what made the
|
|
dashboard white-splash reload on return. `useVisibilityAwarePoll` suspends the interval while hidden
|
|
and issues exactly one refresh when the tab becomes visible again.
|
|
*/
|
|
useVisibilityAwarePoll(refresh, POLL_INTERVAL_MS, { enabled: autoRefresh });
|
|
|
|
return {
|
|
entries,
|
|
loading,
|
|
error,
|
|
refresh,
|
|
clear,
|
|
hasMore,
|
|
loadMore,
|
|
};
|
|
}
|