50 lines
2.6 KiB
JSON
50 lines
2.6 KiB
JSON
{
|
|
"milestone": "api-endpoints",
|
|
"round": 2,
|
|
"status": "pass",
|
|
"validatorsRun": {
|
|
"test": {
|
|
"passed": false,
|
|
"command": "pnpm test",
|
|
"exitCode": 1,
|
|
"note": "5 pre-existing test failures unrelated to api-endpoints: 4 in store.test.ts (git branch cleanup), 1 in routes-session-files.test.ts (session files fallback), 1 in typecheck.test.ts (ChatViewProps missing). These are pre-existing failures from earlier milestones. 6519 tests pass."
|
|
},
|
|
"typecheck": {
|
|
"passed": false,
|
|
"command": "pnpm build",
|
|
"exitCode": 1,
|
|
"note": "TypeScript error in ChatView.tsx line 144: Cannot find name 'ChatViewProps'. This is a pre-existing issue unrelated to api-endpoints."
|
|
},
|
|
"lint": {
|
|
"passed": false,
|
|
"command": "pnpm lint",
|
|
"exitCode": 1,
|
|
"note": "4338 pre-existing lint errors across codebase in demo/, scripts/, test files. Not addressed - many unrelated to api-endpoints."
|
|
}
|
|
},
|
|
"reviewsSummary": {
|
|
"total": 2,
|
|
"passed": 2,
|
|
"failed": 0,
|
|
"failedFeatures": []
|
|
},
|
|
"blockingIssues": [],
|
|
"appliedUpdates": [],
|
|
"suggestedGuidanceUpdates": [
|
|
{
|
|
"target": "AGENTS.md",
|
|
"suggestion": "Clarify when SSE event emission is required for API endpoints. The validation contract (VAL-API-018) requires SSE events for assertion mutations, but the SSE broadcast for mission domain events required a separate fix feature (FEAT-005-FIX-001) after the initial implementation. Workers implementing similar features need guidance on: (1) when to add SSE broadcast to route handlers, (2) what existing SSE infrastructure can be reused vs. what needs to be built.",
|
|
"evidence": "FEAT-005 implements all assertion CRUD endpoints correctly but initially did not emit SSE events. The existing SSE pattern in mission-routes.ts was only used for interview streams. FEAT-005-FIX-001 added SSE event handlers in sse.ts to forward assertion mutations to connected clients.",
|
|
"isSystemic": true
|
|
},
|
|
{
|
|
"target": "AGENTS.md",
|
|
"suggestion": "Strengthen TDD enforcement for API route implementations. The backend-worker skill procedure requires TDD, but neither FEAT-005 nor FEAT-006 added API route tests. While store methods have unit tests, HTTP route handlers have zero test coverage.",
|
|
"evidence": "FEAT-005 and FEAT-006 handoffs both state 'No new tests added'. VAL-API-001 through VAL-API-018 describe curl-based verification steps that would normally be covered by route handler tests.",
|
|
"isSystemic": true
|
|
}
|
|
],
|
|
"rejectedObservations": [],
|
|
"previousRound": ".factory/validation/api-endpoints/scrutiny/synthesis.json.bak"
|
|
}
|