Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
116 lines
4.6 KiB
TypeScript
116 lines
4.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { loadAllAppCss } from "../test/cssFixture";
|
|
import { readFileSync } from "fs";
|
|
import { resolve } from "path";
|
|
|
|
function extractRuleBlock(css: string, selector: string): string {
|
|
const escapedSelector = selector.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
|
|
const match = css.match(new RegExp(`${escapedSelector}\\s*\\{([\\s\\S]*?)\\}`));
|
|
return match?.[1] ?? "";
|
|
}
|
|
|
|
function extractMobileMediaBlocks(content: string): string {
|
|
const blocks: string[] = [];
|
|
const regex = /@media\s*\(\s*max-width:\s*768px\s*\)\s*\{/g;
|
|
let match;
|
|
|
|
while ((match = regex.exec(content)) !== null) {
|
|
const startIdx = match.index + match[0].length;
|
|
let braceCount = 1;
|
|
let endIdx = startIdx;
|
|
|
|
while (braceCount > 0 && endIdx < content.length) {
|
|
if (content[endIdx] === "{") braceCount += 1;
|
|
if (content[endIdx] === "}") braceCount -= 1;
|
|
endIdx += 1;
|
|
}
|
|
|
|
if (braceCount === 0) {
|
|
blocks.push(content.slice(startIdx, endIdx - 1));
|
|
}
|
|
}
|
|
|
|
return blocks.join("\n");
|
|
}
|
|
|
|
describe("mobile-nav-bar.css", () => {
|
|
const cssContent = loadAllAppCss();
|
|
const mobileMediaBlock = extractMobileMediaBlocks(cssContent);
|
|
|
|
it("tab bar has fixed position", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-nav-bar");
|
|
expect(block).toContain("position: fixed");
|
|
expect(block).toContain("bottom: 0");
|
|
});
|
|
|
|
it("tab bar display toggles in mobile media query", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-nav-bar");
|
|
expect(block).toContain("display: none");
|
|
expect(cssContent).toContain("@media (max-width: 768px)");
|
|
expect(cssContent).toMatch(/@media\s*\(max-width:\s*768px\)\s*\{[\s\S]*?\.mobile-nav-bar\s*\{[\s\S]*?display:\s*flex[;\s]/);
|
|
});
|
|
|
|
it("tab touch targets are at least 36px", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-nav-tab");
|
|
expect(block).toContain("min-height: 36px");
|
|
});
|
|
|
|
it("footer-aware positioning keeps nav at bottom: 0 when footer is visible", () => {
|
|
expect(cssContent).toContain(".mobile-nav-bar--with-footer");
|
|
// Nav bar stays at bottom: 0 (no longer shifts up)
|
|
// ExecutorStatusBar is positioned above via its own bottom offset
|
|
expect(mobileMediaBlock).toContain(".mobile-nav-bar--with-footer");
|
|
expect(mobileMediaBlock).toContain("bottom: 0");
|
|
});
|
|
|
|
it("executor status bar has bottom offset above nav bar on mobile", () => {
|
|
// ExecutorStatusBar mobile override positions it above the mobile nav bar
|
|
// Uses --mobile-nav-height variable for consistent nav-height contract
|
|
expect(mobileMediaBlock).toMatch(
|
|
/\.executor-status-bar\s*\{[^}]*bottom:\s*calc\(var\(--mobile-nav-height\)/,
|
|
);
|
|
});
|
|
|
|
it("defines bottom sheet animation", () => {
|
|
expect(cssContent).toContain("@keyframes mobile-more-sheet-in");
|
|
});
|
|
|
|
it("uses safe-area inset for bottom spacing", () => {
|
|
expect(cssContent).toContain("env(safe-area-inset-bottom");
|
|
});
|
|
|
|
it("tab bar includes z-index", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-nav-bar");
|
|
expect(block).toContain("z-index: 45");
|
|
});
|
|
|
|
it("sheet items maintain 36px touch targets", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-more-item");
|
|
expect(block).toContain("min-height: 36px");
|
|
});
|
|
|
|
it("defines content padding rule for mobile nav", () => {
|
|
expect(mobileMediaBlock).toContain(".project-content--with-mobile-nav");
|
|
expect(cssContent).toContain(".project-content--with-footer.project-content--with-mobile-nav");
|
|
});
|
|
|
|
it("mobile-more-sheet uses additive safe-area padding (not max) to prevent Settings clipping", () => {
|
|
// FN-1545: The mobile More sheet bottom padding must ADD safe-area inset to the
|
|
// base padding, not use max() which could collapse spacing on devices with large insets.
|
|
// This ensures the Settings item at the bottom is fully reachable on real mobile viewports.
|
|
const block = extractRuleBlock(cssContent, ".mobile-more-sheet");
|
|
// Must contain calc() with + operator for additive safe-area handling
|
|
expect(block).toMatch(/padding-bottom:\s*calc\([^)]+\s*\+\s*env\(safe-area-inset-bottom/);
|
|
// Must NOT use max() which would replace rather than add
|
|
expect(block).not.toContain("max(16px, env(safe-area-inset-bottom");
|
|
});
|
|
|
|
it("mobile-more-sheet has scrollable content to reach Settings on short viewports", () => {
|
|
const block = extractRuleBlock(cssContent, ".mobile-more-sheet");
|
|
// Must be scrollable so users can scroll to the last item (Settings)
|
|
expect(block).toContain("overflow-y: auto");
|
|
// Must have max-height to constrain but allow scrolling
|
|
expect(block).toMatch(/max-height:\s*\d+vh/);
|
|
});
|
|
});
|