root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
bc348345a469e07cb4e2cd008a87fddbb725e79a
fusion/packages/desktop/electron-builder.yml
gsxdsm c15c78feeb feat: migrate storage from SQLite to PostgreSQL (#1793) 
# Migrate storage from SQLite to PostgreSQL — full dashboard cutover

Migrates Fusion's storage layer to the embedded PostgreSQL
`AsyncDataLayer` (the default backend) and **completes the
satellite-store + feature cutover** so every dashboard and Command
Center surface works in PG mode.

## Status — every surface works in embedded-PG mode

Verified live against a running embedded-Postgres dashboard (all
**200**, zero 5xx) and gate-tested (**23 files / 99 tests** on embedded
PG, plus engine-core 294 and ci-shape 63 in the blocking merge gate;
core/engine/cli/dashboard typecheck clean).

| Area | Surfaces | State |
|---|---|---|
| Satellite stores | workflows, todos, insights, research, missions,
goals, mailbox | ✅ |
| Views | artifacts, documents, evals | ✅ |
| Command Center | activity, productivity, team, tokens, tools,
**workflows**, **github**, **signals**, **plugin-activations**, **live**
(all 10) | ✅ |
| Run execution | insight generation, research run execution | ✅
(store-path; AI step needs a provider) |
| Live updates | SSE push for mission/research/insight events | ✅ |
| Workflow editing | create / update / delete / select (+ id counter) |
✅ |
| Engine | mission autopilot, incident-signal ingestion, regression
storm-guard, agent wake-on-message | ✅ |
| Core | tasks, agents, secrets, automations, memory, chat, usage, PRs,
git | ✅ |

## Approach

Each satellite store gets an `Async<Store>` wrapper exposing the sync
store's method names over the existing `async-*-store.ts` helpers;
`get<Store>Store()` returns a `Sync | Async` union; consumers `await`
(harmless on sync), and engine/CLI paths that can't convert use
`instanceof Sync` graceful fallback. Analytics aggregators branch on
`"ping" in dbOrLayer` to run schema-qualified raw SQL over `project.*`
(snake_case) in PG. Executors/orchestrators/autopilot are
await-converted to drive the union store; the async store wrappers
extend `EventEmitter` so SSE live-push fires in both backends.

Not-yet-ported capabilities degrade gracefully (never 500) and are
individually called out in commits.

## Sync with main

The branch is kept continuously merged with `main` (currently through
FN-7845, 2026-07-12); the earlier "final rebase deferred" note no longer
applies. Use **Create a merge commit** (or squash) to land it — GitHub's
rebase-merge cannot replay a merge-maintained branch.

## Residual Review Findings

Multi-agent code review of the PostgreSQL satellite-store ports (U1–U5)
applied 3 safe fixes (see `fix(review): apply autofix feedback`). The
following are **real but gated** — recorded here as follow-up work
rather than auto-applied. All are SQLite→PostgreSQL
**concurrency/atomicity regressions**: the sync stores were immune only
by SQLite's single-writer, single-threaded-handler execution; the async
ports open multi-await read-modify-write windows. **Reachability is low
today** because the execution engines that generate concurrent same-run
mutations (insight run executor, research orchestrator/dispatcher) are
`instanceof`-gated to sync mode in PG. No process-crash class survived
(all engine fallbacks correctly guard the sync store).

- **[P1] Research `appendResearchEvent` dual-write is non-atomic**
(`packages/core/src/async-research-store.ts`, corroborated: adversarial
+ reliability). The `research_run_events` insert (own transaction) and
the `run.events` jsonb update are separate writes — a crash between
them, or two concurrent appends, splits the table count from the jsonb
array. **Fix:** perform the seq-insert and the jsonb update in one
`layer.transactionImmediate`.
- **[P1] Research run terminal-reversion via stale full-row persist**
(`async-research-store.ts` `persistResearchRun`/`updateResearchStatus`).
Concurrent `PATCH /runs/:id/status` + `POST /runs/:id/events` can revert
a terminal run to `running` by overwriting the whole row, bypassing the
transition guard. **Fix:** scoped column `UPDATE`s with a `WHERE status
…` guard, or optimistic version column.
- **[P2] `updateResearchRun`/`updateInsightRun` read-then-write TOCTOU**
— concurrent PATCHes last-writer-wins on the lifecycle merge. **Fix:**
`SELECT … FOR UPDATE` / enclosing transaction.
- **[P2] `upsertRun`/`createRunOrThrowConflict` check-then-create race**
(`async-insight-store.ts`) — two callers can each create an "active"
run. **Fix:** partial unique index on `(projectId, trigger) WHERE status
IN ('pending','running')`.
- **[P3] `createResearchRetryRun` return-value divergence** — sync
returns the pre-update `queued` snapshot; async returns the reloaded
`retry_waiting` run (persisted state is identical). Pick one side for
cross-backend parity.
- **[P2/perf] Mission `getMissionWithHierarchy`/`getMissionHealth` N+1
fan-out** — O(milestones×slices) sequential round-trips hold one pool
slot per request; can starve the pool for large hierarchies. **Fix:**
batched/joined reads.
- **Testing gaps:** no PG-mode concurrency tests (interleaved
status/event mutations), no sync↔async parity assertion for the
lifecycle-error codes, and no mission status/health rollup parity test
vs the sync `MissionStore`.

~~Out of scope (deferred): AI run *execution* (insight/research) +
mission autopilot + live SSE mission events remain sync-gated/degraded
in PG mode.~~ **Since ported** — insight/research run execution, mission
autopilot, and SSE live push all run on the async layer now, which also
makes the concurrency findings above genuinely reachable; they remain
open follow-ups.







---

## Update — 2026-07-12: production-readiness hardening & live acceptance

Everything below landed on this branch since the description above was
written:

**Production blockers from review — fixed**
- `recoverStaleTransitionPending` ported to the async layer (backend
moves write + clear the crash-safe marker; startup/maintenance sweeps no
longer throw).
- Lost-update class fixed: `atomicWriteTaskJson`/`WithAudit` write
changed columns only (full-row upserts silently resurrected stale fields
across concurrent store instances — the "task stuck unplanned forever"
bug).
- First-boot **auto-migration**: booting the PG backend over a project
with a legacy `fusion.db` migrates it automatically (loud failure,
SQLite kept as backup), and the dashboard shows a one-time **"your data
was migrated" banner** with the backup paths and a Need-help Discord
link.
- `pg_dump`/`pg_restore` discovered from common install locations for
embedded-mode backups.
- The PG suite is part of the blocking merge gate (`test:pg-gate`).

**Multi-project isolation (PR #2007, merged into this branch)**
- `project_id` partition key on tasks / archived tasks / config,
`taskProjectScope` threaded through every scan/claim/count, per-project
config rows, layer bound to the project at startup.
- Review P1 follow-up: the shared cold-storage `archive.archived_tasks`
table is also partitioned and all archived-board reads/counts/searches
are scoped.
- Schema drift self-heal generalized to schema-qualified columns so
existing databases upgrade in place.

**Other changes**
- Node settings sync **removed** in PG mode (409
`settings-sync-disabled-postgres`) — nodes share state by connecting to
the same database; auth sync kept (per-machine file).
- Perf (review findings): `listTasks` pushes column filter + ORDER BY +
LIMIT/OFFSET into SQL; `getConversation` capped to the most recent 200
messages.
- Fixed a false "operator action required" pause-abort log fired on
every successfully auto-merged task.

**Live acceptance — PASSED (2026-07-12)**
A sandboxed instance (isolated HOME, embedded PG, real Opus executor)
ran a task through the complete cycle: create → triage (AI spec) →
execute → in-review → AI squash-merge landed on the project's `main` →
done. A write+read sweep of every data surface (settings, comments,
documents, attachments + artifact bridge + artifact edit, chat with real
generation, goals, missions, agent mail, secrets, workflows, memory, CC
analytics) was green on embedded PG.

**Known remaining work**
- The per-project `config` PK re-key has no upgrade path for
pre-isolation embedded-PG databases (needs a real `DROP
CONSTRAINT`/re-key migration; fresh databases are fine).
- `pg_dump`/`pg_restore` binaries are not yet bundled in release
artifacts (PATH/common-location discovery only).
- The satellite-store concurrency findings listed above.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Phil Larson <hello@phillarson.xyz>
Co-authored-by: fusion-merge <fusion-merge@local>
2026-07-13 19:07:58 -07:00

172 lines
5.1 KiB
YAML
Raw Blame History

appId: com.gsxdsm.fusion.desktop
productName: Fusion
artifactName: "${productName}-${version}-${os}-${arch}.${ext}"
directories:
output: dist-electron
buildResources: src/icons
# The desktop app bundles no native addon that needs an Electron-ABI rebuild: it
# uses Node's built-in `node:sqlite`, and the only native modules in the dependency
# tree (keytar, @homebridge/node-pty-prebuilt-multiarch via @fusion/dashboard) are
# loaded optionally and are NOT in the `files` list, so they're never packaged.
# electron-builder's default rebuild walks the whole tree and tries to source-build
# node-pty (it ships Node-ABI prebuilds only, none for Electron) via node-gyp, which
# fails on the Windows runner ("Could not find any Visual Studio installation").
# Disabling the rebuild skips that pointless, platform-fragile compile entirely.
npmRebuild: false
files:
# pnpm installs workspace/runtime deps as symlinked package entries backed by the
# virtual store. These flat node_modules/X/**/* patterns only work when electron-builder
# follows the symlink chain from the published package entry, so every @fusion/core
# runtime dependency group that the desktop app can load must be listed here.
# If @fusion/core gains a new runtime dependency, add it (and any required leaf deps)
# here or packaged desktop builds can fail at startup/runtime with missing-module errors.
- dist/**/*
- package.json
- node_modules/@fusion/core/**/*
- node_modules/@fusion/dashboard/**/*
- node_modules/electron-updater/**/*
- node_modules/builder-util-runtime/**/*
- node_modules/fs-extra/**/*
- node_modules/jsonfile/**/*
- node_modules/graceful-fs/**/*
- node_modules/universalify/**/*
- node_modules/js-yaml/**/*
- node_modules/argparse/**/*
- node_modules/sprintf-js/**/*
- node_modules/lazy-val/**/*
- node_modules/lodash.escaperegexp/**/*
- node_modules/lodash.isequal/**/*
- node_modules/semver/**/*
- node_modules/tiny-typed-emitter/**/*
- node_modules/debug/**/*
- node_modules/ms/**/*
- node_modules/sax/**/*
# @fusion/core archive parsing deps
- node_modules/extract-zip/**/*
- node_modules/get-stream/**/*
- node_modules/pump/**/*
- node_modules/end-of-stream/**/*
- node_modules/once/**/*
- node_modules/wrappy/**/*
- node_modules/yauzl/**/*
- node_modules/fd-slicer/**/*
- node_modules/pend/**/*
- node_modules/buffer-crc32/**/*
- node_modules/tar/**/*
- node_modules/@isaacs/fs-minipass/**/*
- node_modules/chownr/**/*
- node_modules/minipass/**/*
- node_modules/minizlib/**/*
- node_modules/yallist/**/*
- node_modules/yaml/**/*
# @fusion/core scheduling/automation deps
- node_modules/cron-parser/**/*
- node_modules/luxon/**/*
# @fusion/core discovery/system deps
- node_modules/bonjour-service/**/*
- node_modules/fast-deep-equal/**/*
- node_modules/multicast-dns/**/*
- node_modules/dns-packet/**/*
- node_modules/thunky/**/*
- node_modules/@leichtgewicht/ip-codec/**/*
- node_modules/check-disk-space/**/*
# @fusion/core optional docker runtime deps
- node_modules/dockerode/**/*
- node_modules/@balena/dockerignore/**/*
- node_modules/@grpc/grpc-js/**/*
- node_modules/@grpc/proto-loader/**/*
- node_modules/docker-modem/**/*
- node_modules/protobufjs/**/*
- node_modules/tar-fs/**/*
- node_modules/uuid/**/*
asarUnpack: []
extraMetadata:
main: dist/main.js
extraResources:
- from: src/icons
to: icons
filter:
- "tray-*.png"
protocols:
- name: Fusion Deep Links
schemes:
- fusion
fileAssociations:
- ext: fusion
name: Fusion Task Link
description: Fusion desktop deep link
role: Viewer
mimeType: x-scheme-handler/fusion
publish:
provider: github
owner: gsxdsm
repo: fusion
mac:
category: public.app-category.developer-tools
minimumSystemVersion: "10.15"
target:
- target: dmg
- target: zip
hardenedRuntime: true
gatekeeperAssess: false
entitlements: build/entitlements.mac.plist
entitlementsInherit: build/entitlements.mac.plist
notarize: true
win:
target:
- target: nsis
arch:
- x64
- arm64
- target: portable
arch:
- x64
- arm64
signtoolOptions:
signingHashAlgorithms:
- sha256
rfc3161TimeStampServer: http://timestamp.digicert.com
publisherName: Fusion
nsis:
# FNXC:WindowsDesktopPackaging 2026-07-01-08:02:
# NSIS is the installable Windows artifact and must keep the 0.50-style
# Fusion-<version>-win-<arch>.exe name so updater/install docs remain stable.
# The portable target writes a separate -portable EXE below to avoid colliding
# with or overwriting the NSIS installer during x64/arm64 packaging.
artifactName: "${productName}-${version}-${os}-${arch}.${ext}"
oneClick: false
perMachine: false
allowElevation: false
allowToChangeInstallationDirectory: true
portable:
artifactName: "${productName}-${version}-${os}-${arch}-portable.${ext}"
linux:
category: Development
target:
- target: AppImage
arch:
- x64
- arm64
- target: deb
arch:
- x64
- arm64
- target: tar.gz
arch:
- x64
- arm64
Reference in New Issue View Git Blame Copy Permalink