Files
fusion/packages/dashboard/app/components/NodesView.tsx
gsxdsm f11800f2c6 refactor(dashboard): split monolithic styles.css into per-component files
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).

- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
  React.lazy + Suspense; prefetch all chunks on idle so first navigation is
  instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
  635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.

- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
  so CSS regression tests load the full per-component bundle (mirroring Vite
  source order). Migrate 30+ tests off direct readFileSync('../styles.css').

- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
  imports actually inject styles in jsdom (fixes getComputedStyle assertions).

- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
  dashboard test files; points at loadAllAppCss() instead.

- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
  .form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.

- Mobile fixes along the way: scroll containment for view containers
  (min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
  mobile (with safe-area-inset for iOS home bar), AgentsView single-row
  header layout, ActivityLogModal close button on right, model-combobox
  z-index above the mobile quick-chat panel.

- Bug fix: SkillsView toggle was display:none which hid the input from the
  accessibility tree; replaced with the visually-hidden pattern so screen
  readers + getByRole still find the checkbox.

- Bug fix: standalone Delete button in TaskDetailModal for triage-column
  tasks (Actions dropdown is hidden in triage state, so previously no way
  to delete a freshly-created task without status change first).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 19:39:20 -07:00

216 lines
7.8 KiB
TypeScript

import { useCallback, useEffect, useMemo, useState } from "react";
import { Plus, Server, Wifi, WifiOff, Globe, RefreshCw, X } from "lucide-react";
import "./NodesView.css";
import { useNodes } from "../hooks/useNodes";
import { useProjects } from "../hooks/useProjects";
import { useNodeSettingsSync, computeSyncState } from "../hooks/useNodeSettingsSync";
import type { NodeInfo, NodeUpdateInput } from "../api";
import { NodeCard } from "./NodeCard";
import { MeshTopology } from "./MeshTopology";
import { AddNodeModal, type AddNodeInput } from "./AddNodeModal";
import { NodeDetailModal } from "./NodeDetailModal";
import type { ToastType } from "../hooks/useToast";
interface NodesViewProps {
addToast: (message: string, type?: ToastType) => void;
onClose: () => void;
}
export function NodesView({ addToast, onClose }: NodesViewProps) {
const { nodes, loading, error, refresh, register, update, unregister, healthCheck } = useNodes();
const { projects } = useProjects();
const { syncStatusMap, pushSettings, pullSettings, syncAuth, trackNode, getAuthSyncState, getAuthProviders } = useNodeSettingsSync();
const [addModalOpen, setAddModalOpen] = useState(false);
const [selectedNode, setSelectedNode] = useState<NodeInfo | null>(null);
// Track remote nodes for sync status polling
useEffect(() => {
const remoteNodes = nodes.filter((node) => node.type === "remote");
for (const node of remoteNodes) {
trackNode(node.id);
}
}, [nodes, trackNode]);
useEffect(() => {
if (!selectedNode) return;
const latest = nodes.find((node) => node.id === selectedNode.id) ?? null;
setSelectedNode(latest);
}, [nodes, selectedNode]);
const stats = useMemo(() => {
const total = nodes.length;
const online = nodes.filter((node) => node.status === "online").length;
const offline = nodes.filter((node) => node.status === "offline" || node.status === "error").length;
const remote = nodes.filter((node) => node.type === "remote").length;
const synced = nodes.filter(
(node) => node.type === "remote" && syncStatusMap[node.id] && computeSyncState(syncStatusMap[node.id]).syncState === "synced"
).length;
return { total, online, offline, remote, synced };
}, [nodes, syncStatusMap]);
const handleRegister = useCallback(async (input: AddNodeInput) => {
await register(input);
}, [register]);
const handleRefresh = useCallback(async () => {
try {
await refresh();
} catch {
addToast("Failed to refresh nodes", "error");
}
}, [addToast, refresh]);
const handleHealthCheck = useCallback(async (id: string) => {
try {
await healthCheck(id);
addToast("Node health check complete", "success");
} catch (err) {
const message = err instanceof Error ? err.message : "Health check failed";
addToast(message, "error");
}
}, [addToast, healthCheck]);
const handleUnregister = useCallback(async (id: string) => {
try {
await unregister(id);
addToast("Node removed", "success");
if (selectedNode?.id === id) {
setSelectedNode(null);
}
} catch (err) {
const message = err instanceof Error ? err.message : "Failed to remove node";
addToast(message, "error");
}
}, [addToast, selectedNode?.id, unregister]);
const handleUpdate = useCallback(async (id: string, updates: NodeUpdateInput) => {
await update(id, updates);
}, [update]);
return (
<div className="nodes-view" data-testid="nodes-view">
<div className="nodes-view-header">
<div className="nodes-view-title">
<h2>
<Server size={20} />
Nodes
</h2>
<span className="nodes-view-count">{nodes.length} registered</span>
</div>
<div className="nodes-view-actions">
<button
className="btn-icon nodes-view-close"
onClick={onClose}
aria-label="Close nodes view"
>
<X size={16} />
</button>
<button className="btn btn-sm" onClick={() => void handleRefresh()} disabled={loading}>
<RefreshCw size={14} className={loading ? "spin" : ""} />
Refresh
</button>
<button className="btn btn-primary btn-sm" onClick={() => setAddModalOpen(true)}>
<Plus size={14} />
Add Node
</button>
</div>
</div>
<div className="nodes-view-stats">
<div className="nodes-view-stat" data-testid="nodes-stat-total">
<span>Total</span>
<strong>{stats.total}</strong>
</div>
<div className="nodes-view-stat nodes-view-stat--online" data-testid="nodes-stat-online">
<span><Wifi size={14} /> Online</span>
<strong>{stats.online}</strong>
</div>
<div className="nodes-view-stat nodes-view-stat--offline" data-testid="nodes-stat-offline">
<span><WifiOff size={14} /> Offline</span>
<strong>{stats.offline}</strong>
</div>
<div className="nodes-view-stat" data-testid="nodes-stat-remote">
<span><Globe size={14} /> Remote</span>
<strong>{stats.remote}</strong>
</div>
<div className="nodes-view-stat nodes-view-stat--synced" data-testid="nodes-stat-synced">
<span><RefreshCw size={14} /> Synced</span>
<strong>{stats.synced}</strong>
</div>
</div>
{error && <div className="nodes-view-error">{error}</div>}
{/* Mesh Topology Visualization */}
{!loading && nodes.length > 0 && (
<section className="nodes-view-topology" aria-label="Mesh Topology">
<h3 className="nodes-view-section-title">Mesh Topology</h3>
<MeshTopology nodes={nodes} />
</section>
)}
{loading ? (
<div className="nodes-view-grid">
{Array.from({ length: 4 }).map((_, index) => (
<div key={index} className="node-card node-card--loading" aria-hidden />
))}
</div>
) : nodes.length === 0 ? (
<div className="nodes-view-empty">
<p>No nodes are registered yet.</p>
<button className="btn btn-primary" onClick={() => setAddModalOpen(true)}>
<Plus size={14} />
Add First Node
</button>
</div>
) : (
<div className="nodes-view-grid">
{nodes.map((node) => {
const nodeSyncStatus = node.type === "remote" && syncStatusMap[node.id]
? computeSyncState(syncStatusMap[node.id])
: undefined;
return (
<NodeCard
key={node.id}
node={node}
projects={projects}
onHealthCheck={(id) => { void handleHealthCheck(id); }}
onEdit={(selected) => setSelectedNode(selected)}
onRemove={(id) => { void handleUnregister(id); }}
isLoading={loading}
syncStatus={nodeSyncStatus}
authSyncState={node.type === "remote" ? getAuthSyncState(node.id) : undefined}
authSyncProviders={node.type === "remote" ? getAuthProviders(node.id) : undefined}
/>
);
})}
</div>
)}
<AddNodeModal
isOpen={addModalOpen}
onClose={() => setAddModalOpen(false)}
onSubmit={handleRegister}
addToast={addToast}
/>
<NodeDetailModal
isOpen={selectedNode !== null}
onClose={() => setSelectedNode(null)}
node={selectedNode}
projects={projects}
onUpdate={handleUpdate}
onHealthCheck={handleHealthCheck}
addToast={addToast}
syncStatus={selectedNode?.type === "remote" && selectedNode && syncStatusMap[selectedNode.id]
? computeSyncState(syncStatusMap[selectedNode.id])
: undefined}
onPushSettings={pushSettings}
onPullSettings={pullSettings}
onSyncAuth={syncAuth}
/>
</div>
);
}