c3d1716fdd
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
55 lines
2.2 KiB
TypeScript
55 lines
2.2 KiB
TypeScript
import { describe, it, expect, beforeAll } from "vitest";
|
|
import { loadAllAppCss } from "../test/cssFixture";
|
|
import fs from "fs";
|
|
import path from "path";
|
|
|
|
describe("Git Manager light-theme tokenization", () => {
|
|
let css: string;
|
|
|
|
beforeAll(() => {
|
|
css = loadAllAppCss();
|
|
});
|
|
|
|
function getGitManagerLightBlock(): string {
|
|
const startMarker = "/* ── Light Theme Overrides ── */";
|
|
const endMarker = "/* ── Task Changes Tab Styles";
|
|
|
|
const startIdx = css.indexOf(startMarker);
|
|
const endIdx = css.indexOf(endMarker);
|
|
|
|
if (startIdx === -1 || endIdx === -1 || endIdx <= startIdx) {
|
|
throw new Error("Could not locate Git Manager light-theme override block boundaries");
|
|
}
|
|
|
|
return css.slice(startIdx, endIdx);
|
|
}
|
|
|
|
it("uses semantic neutral surface tokens for scoped Git Manager light-theme backgrounds", () => {
|
|
const block = getGitManagerLightBlock();
|
|
|
|
expect(block).toContain('[data-theme="light"] .gm-sidebar {\n background: var(--surface-subtle);');
|
|
expect(block).toContain('[data-theme="light"] .gm-nav-item:hover {\n background: var(--surface-hover);');
|
|
expect(block).toContain('[data-theme="light"] .gm-commit-header:hover {\n background: var(--surface-muted);');
|
|
expect(block).toContain('[data-theme="light"] .gm-hash {\n background: var(--surface-emphasis);');
|
|
expect(block).toContain('[data-theme="light"] .gm-icon-btn:hover {\n background: var(--surface-hover-strong);');
|
|
});
|
|
|
|
it("does not reintroduce direct neutral rgba(0,0,0,0.02-0.06) backgrounds in scoped Git Manager light-theme rules", () => {
|
|
const block = getGitManagerLightBlock();
|
|
|
|
expect(block).not.toMatch(/background:\s*rgba\(0,\s*0,\s*0,\s*0\.0[2-6]\)/);
|
|
});
|
|
|
|
it("uses token-based accent states for selected/default Git Manager light-theme rules", () => {
|
|
const block = getGitManagerLightBlock();
|
|
|
|
expect(block).toContain("color-mix(in srgb, var(--todo) 8%, transparent)");
|
|
expect(block).toContain("color-mix(in srgb, var(--todo) 12%, transparent)");
|
|
expect(block).toContain("color-mix(in srgb, var(--todo) 10%, transparent)");
|
|
expect(block).toContain("color: var(--todo);");
|
|
|
|
expect(block).not.toContain("rgba(9, 105, 218");
|
|
expect(block).not.toContain("#0969da");
|
|
});
|
|
});
|