- Add Step types to core data model (command, validation, approval steps) - Update AutomationStore CRUD operations for step management - Refactor CronRunner for sequential step execution with per-step config - Add Dashboard API routes for step CRUD and step-aware schedule updates - Create ScheduleStepsEditor component for visual step configuration - Add StepTypeBadge component for step type visualization - Update ScheduleCard and ScheduleForm to display and manage steps - Add comprehensive test coverage for stores, runner, and components - Add changeset for patch release
231 lines
9.1 KiB
TypeScript
231 lines
9.1 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import { render, screen, fireEvent } from "@testing-library/react";
|
|
import { ScheduleStepsEditor } from "../ScheduleStepsEditor";
|
|
import type { AutomationStep } from "@kb/core";
|
|
|
|
// Mock @kb/core
|
|
vi.mock("@kb/core", () => ({}));
|
|
|
|
// Mock lucide-react
|
|
vi.mock("lucide-react", () => ({
|
|
Plus: () => <span data-testid="icon-plus">+</span>,
|
|
Trash2: () => <span data-testid="icon-trash">🗑</span>,
|
|
ChevronUp: () => <span data-testid="icon-up">▲</span>,
|
|
ChevronDown: () => <span data-testid="icon-down">▼</span>,
|
|
Pencil: () => <span data-testid="icon-pencil">✎</span>,
|
|
GripVertical: () => <span data-testid="icon-grip">≡</span>,
|
|
Terminal: () => <span data-testid="icon-terminal">$</span>,
|
|
Sparkles: () => <span data-testid="icon-sparkles">✨</span>,
|
|
}));
|
|
|
|
// Mock crypto.randomUUID for deterministic tests
|
|
let uuidCounter = 0;
|
|
vi.stubGlobal("crypto", {
|
|
randomUUID: () => `test-uuid-${++uuidCounter}`,
|
|
});
|
|
|
|
function makeStep(overrides: Partial<AutomationStep> = {}): AutomationStep {
|
|
return {
|
|
id: `step-${++uuidCounter}`,
|
|
type: "command",
|
|
name: "Test Step",
|
|
command: "echo hello",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("ScheduleStepsEditor", () => {
|
|
const onChange = vi.fn();
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
uuidCounter = 0;
|
|
});
|
|
|
|
describe("step addition", () => {
|
|
it("renders add buttons for command and AI prompt", () => {
|
|
render(<ScheduleStepsEditor steps={[]} onChange={onChange} />);
|
|
expect(screen.getByText("Add Command Step")).toBeDefined();
|
|
expect(screen.getByText("Add AI Prompt Step")).toBeDefined();
|
|
});
|
|
|
|
it("adds a command step when clicking Add Command Step", () => {
|
|
render(<ScheduleStepsEditor steps={[]} onChange={onChange} />);
|
|
fireEvent.click(screen.getByText("Add Command Step"));
|
|
expect(onChange).toHaveBeenCalledTimes(1);
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps).toHaveLength(1);
|
|
expect(newSteps[0].type).toBe("command");
|
|
expect(newSteps[0].name).toBe("New Command Step");
|
|
});
|
|
|
|
it("adds an AI prompt step when clicking Add AI Prompt Step", () => {
|
|
render(<ScheduleStepsEditor steps={[]} onChange={onChange} />);
|
|
fireEvent.click(screen.getByText("Add AI Prompt Step"));
|
|
expect(onChange).toHaveBeenCalledTimes(1);
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps).toHaveLength(1);
|
|
expect(newSteps[0].type).toBe("ai-prompt");
|
|
expect(newSteps[0].name).toBe("New AI Prompt Step");
|
|
});
|
|
|
|
it("appends to existing steps", () => {
|
|
const existing = [makeStep({ name: "Existing" })];
|
|
render(<ScheduleStepsEditor steps={existing} onChange={onChange} />);
|
|
fireEvent.click(screen.getByText("Add Command Step"));
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps).toHaveLength(2);
|
|
expect(newSteps[0].name).toBe("Existing");
|
|
});
|
|
});
|
|
|
|
describe("step deletion", () => {
|
|
it("removes a step when delete button is clicked", () => {
|
|
const steps = [
|
|
makeStep({ id: "s1", name: "First" }),
|
|
makeStep({ id: "s2", name: "Second" }),
|
|
];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
const deleteButtons = screen.getAllByTitle("Delete");
|
|
fireEvent.click(deleteButtons[0]);
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps).toHaveLength(1);
|
|
expect(newSteps[0].name).toBe("Second");
|
|
});
|
|
});
|
|
|
|
describe("step reordering", () => {
|
|
it("moves a step up", () => {
|
|
const steps = [
|
|
makeStep({ id: "s1", name: "First" }),
|
|
makeStep({ id: "s2", name: "Second" }),
|
|
];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
// Click "Move up" on the second step
|
|
const moveUpButtons = screen.getAllByTitle("Move up");
|
|
fireEvent.click(moveUpButtons[1]); // second step's move up button
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps[0].name).toBe("Second");
|
|
expect(newSteps[1].name).toBe("First");
|
|
});
|
|
|
|
it("moves a step down", () => {
|
|
const steps = [
|
|
makeStep({ id: "s1", name: "First" }),
|
|
makeStep({ id: "s2", name: "Second" }),
|
|
];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
// Click "Move down" on the first step
|
|
const moveDownButtons = screen.getAllByTitle("Move down");
|
|
fireEvent.click(moveDownButtons[0]); // first step's move down button
|
|
const newSteps = onChange.mock.calls[0][0] as AutomationStep[];
|
|
expect(newSteps[0].name).toBe("Second");
|
|
expect(newSteps[1].name).toBe("First");
|
|
});
|
|
|
|
it("disables Move Up on the first step", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Only" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
const moveUpBtn = screen.getByLabelText("Move Only up");
|
|
expect(moveUpBtn.hasAttribute("disabled")).toBe(true);
|
|
});
|
|
|
|
it("disables Move Down on the last step", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Only" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
const moveDownBtn = screen.getByLabelText("Move Only down");
|
|
expect(moveDownBtn.hasAttribute("disabled")).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("step editing", () => {
|
|
it("shows step editor when edit button is clicked", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
fireEvent.click(screen.getByLabelText("Edit Build"));
|
|
// Editor should show form fields
|
|
expect(screen.getByLabelText("Step Name")).toBeDefined();
|
|
expect(screen.getByText("Save Step")).toBeDefined();
|
|
});
|
|
|
|
it("closes editor on cancel", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
fireEvent.click(screen.getByLabelText("Edit Build"));
|
|
expect(screen.getByText("Save Step")).toBeDefined();
|
|
fireEvent.click(screen.getByText("Cancel"));
|
|
// Editor should be closed; step card should be visible again
|
|
expect(screen.queryByText("Save Step")).toBeNull();
|
|
expect(screen.getByText("Build")).toBeDefined();
|
|
});
|
|
});
|
|
|
|
describe("form validation", () => {
|
|
it("shows error when step name is empty", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
fireEvent.click(screen.getByLabelText("Edit Build"));
|
|
// Clear the name
|
|
fireEvent.change(screen.getByLabelText("Step Name"), { target: { value: "" } });
|
|
fireEvent.click(screen.getByText("Save Step"));
|
|
expect(screen.getByText("Step name is required")).toBeDefined();
|
|
expect(onChange).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("shows error when command step has no command", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build", command: "echo test" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
fireEvent.click(screen.getByLabelText("Edit Build"));
|
|
// Clear the command
|
|
fireEvent.change(screen.getByDisplayValue("echo test"), { target: { value: "" } });
|
|
fireEvent.click(screen.getByText("Save Step"));
|
|
expect(screen.getByText("Command is required")).toBeDefined();
|
|
});
|
|
});
|
|
|
|
describe("empty state", () => {
|
|
it("shows empty state message when no steps", () => {
|
|
render(<ScheduleStepsEditor steps={[]} onChange={onChange} />);
|
|
expect(screen.getByText(/No steps added yet/)).toBeDefined();
|
|
});
|
|
|
|
it("does not show empty state when steps exist", () => {
|
|
const steps = [makeStep()];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
expect(screen.queryByText(/No steps added yet/)).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("step display", () => {
|
|
it("shows step index numbers", () => {
|
|
const steps = [
|
|
makeStep({ id: "s1", name: "First" }),
|
|
makeStep({ id: "s2", name: "Second" }),
|
|
];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
expect(screen.getByText("1")).toBeDefined();
|
|
expect(screen.getByText("2")).toBeDefined();
|
|
});
|
|
|
|
it("shows step names", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build project" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
expect(screen.getByText("Build project")).toBeDefined();
|
|
});
|
|
|
|
it("shows continueOnFailure flag", () => {
|
|
const steps = [makeStep({ id: "s1", name: "Build", continueOnFailure: true })];
|
|
const { container } = render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
const flag = container.querySelector(".step-card-flag");
|
|
expect(flag).not.toBeNull();
|
|
expect(flag?.textContent).toBe("⚡");
|
|
});
|
|
|
|
it("shows step count in header", () => {
|
|
const steps = [makeStep(), makeStep({ id: "s2" })];
|
|
render(<ScheduleStepsEditor steps={steps} onChange={onChange} />);
|
|
expect(screen.getByText("Steps (2)")).toBeDefined();
|
|
});
|
|
});
|
|
});
|