Encourage dashboard chat agents to turn option sets into selectable ask-question cards. - Expand chat-lane prompt guidance so options, choices, and alternatives use `fn_ask_question` instead of prose-only lists. - Cover the guidance in chat manager tests and assert the prompt is passed to resolved sessions. - Record the patch changeset and quarantine unrelated flaky dashboard tests observed during verification. Files changed: .changeset/fn-6633-chat-question-guidance.md | 5 +++++ packages/dashboard/src/__tests__/chat-manager.test.ts | 14 +++++++++++++- packages/dashboard/src/chat.ts | 5 ++++- packages/dashboard/vitest.config.ts | 9 ++++++++- scripts/lib/test-quarantine.json | 10 ++++++++++ 5 files changed, 40 insertions(+), 3 deletions(-) Fusion-Task-Id: FN-6633 Fusion-Task-Lineage: e59371d3-b198-4fe8-a70c-b94994060c59
21 lines
2.1 KiB
JSON
21 lines
2.1 KiB
JSON
{
|
|
"$comment": "Flaky-test quarantine ledger (deletion ratchet — see AGENTS.md 'Flaky tests: quarantine on sight' and docs/testing.md 'Quarantine ledger and the deletion ratchet'). A test observed failing without a corresponding real bug is quarantined ON SIGHT: add an entry here AND a matching one-line `exclude` entry in that package's vitest config, in the same commit. Every entry needs a non-empty `reason` (link the failing run) and a `quarantinedAt` date — the entry expires 14 days later, at which point the test file is DELETED unless someone rescues it with evidence it catches real regressions plus a root-cause fix (never appeasement). There is deliberately no loader module and no automation around this file: it is a dated record, the vitest config exclude is the mechanism, and the sweep is policy executed by whoever touches the suite.",
|
|
"entries": [
|
|
{
|
|
"file": "plugins/fusion-plugin-paperclip-runtime/src/__tests__/paperclip-client.test.ts",
|
|
"reason": "FN-6631 broad `pnpm test` run observed unrelated Paperclip CLI spawn-mock timeouts and unhandled ENOENT errors in mintAgentApiKeyViaCli coverage; targeted Command Center/core checks, lint, typecheck, build, and engine tests passed. Quarantined per deletion-ratchet policy pending Paperclip runtime owner rescue.",
|
|
"quarantinedAt": "2026-06-18"
|
|
},
|
|
{
|
|
"file": "packages/dashboard/app/components/__tests__/QuickEntryBox.test.tsx",
|
|
"reason": "FN-6633 workspace pnpm test observed focus-restoration assertion flake after this task's targeted chat-manager coverage passed; unrelated dashboard jsdom focus race, quarantined under deletion ratchet instead of appeasement.",
|
|
"quarantinedAt": "2026-06-18"
|
|
},
|
|
{
|
|
"file": "packages/dashboard/src/__tests__/chat-routes.test.ts",
|
|
"reason": "FN-6633 workspace pnpm test observed SSE lifecycle test timeout after this task's targeted chat-manager coverage passed; unrelated dashboard route timing flake, quarantined under deletion ratchet instead of broadening this prompt-only change.",
|
|
"quarantinedAt": "2026-06-18"
|
|
}
|
|
]
|
|
}
|