Code review (8 reviewers) fixes: - P1: embedded board task-detail now passes onRequestClose so delete/merge/retry dismiss the panel (no ghost task). - P1: RightDock + TerminalModal drag handlers add pointercancel + unmount teardown (no leaked document listeners / rAF / stuck userSelect); remove dead onOpenChange prop. - Planning slot DOM-poll interval now caps (self-cancels on mobile); heartbeat slider persist debounced + mounted-guarded. - Cleanup: remove dead ViewHeader-migration CSS (Skills/Insights), extract shared GithubIcon, move Activity Log embedded CSS to ActivityLogModal.css, FNXC date-format fixes, AGENTS lazy-view note. - Update stale RightDock roster tests + LeftSidebarNav 'Compound Eng' test to current behavior. Live UI tweaks: - Default load lands on board, never the Command Center Dashboard. - View Board/View Agents moved to the Command Center Overview tab (under the live-activity strip). - Heartbeat card full-width with spaced, wrapping controls. - Dev Server panel scrolls in the dock; ChatView right-pane title takes the full line. - Files pop-out renders deterministic left-right two-pane. - Mailbox list pane narrower + narrow by default; Add Goal button height matches the Compound stage button; Memory Working-Memory tab no longer overlaps; Skills view fills full width. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
442 lines
9.6 KiB
CSS
442 lines
9.6 KiB
CSS
/* === Skills View === */
|
|
/*
|
|
FNXC:SkillsView 2026-06-22-16:15:
|
|
Skills mounts as a flex child of the flex-row .project-content. A flex item with no flex-grow collapses to its intrinsic content width, so the Skills content rendered narrow instead of spanning the main panel. Grow into available space, zero the min-width floor, and pin width:100% — mirroring the GoalsView/SecretsView (FN-6446/FN-6789) fix — so the view fills the full panel width.
|
|
*/
|
|
.skills-view {
|
|
display: flex;
|
|
flex: 1 1 auto;
|
|
flex-direction: column;
|
|
height: 100%;
|
|
min-width: 0;
|
|
width: 100%;
|
|
overflow: hidden;
|
|
}
|
|
|
|
.skills-view-count {
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
/*
|
|
FNXC:Navigation 2026-06-22-02:00:
|
|
The shared ViewHeader already supplies the top + side --space-lg padding, so the content area must NOT repeat the top padding (that doubled the gap under the header). Side + bottom padding only, aligned with the header.
|
|
*/
|
|
.skills-view-content {
|
|
flex: 1;
|
|
overflow-y: auto;
|
|
padding: 0 var(--space-lg) var(--space-lg);
|
|
}
|
|
|
|
.skills-view-section {
|
|
margin-bottom: var(--space-xl);
|
|
}
|
|
|
|
.skills-view-section-title {
|
|
font-weight: 600;
|
|
color: var(--text);
|
|
margin-bottom: var(--space-md);
|
|
padding-bottom: var(--space-sm);
|
|
border-bottom: 1px solid var(--border);
|
|
display: flex;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
/* Discovered skills list */
|
|
.skills-view-list {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.skills-view-item {
|
|
display: flex;
|
|
align-items: center;
|
|
justify-content: space-between;
|
|
gap: var(--space-md);
|
|
padding: var(--space-sm) var(--space-md);
|
|
background: var(--card);
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-md);
|
|
cursor: pointer;
|
|
transition: background var(--transition-fast), border-color var(--transition-fast);
|
|
}
|
|
|
|
.skills-view-item:hover {
|
|
background: var(--card-hover);
|
|
border-color: var(--text-muted);
|
|
}
|
|
|
|
.skills-view-item-info {
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: var(--space-xs);
|
|
min-width: 0;
|
|
flex: 1;
|
|
}
|
|
|
|
.skills-view-item-name {
|
|
font-weight: 500;
|
|
color: var(--text);
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.skills-view-item-path {
|
|
color: var(--text-muted);
|
|
font-family: var(--font-mono);
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.skills-view-item-source {
|
|
color: var(--text-dim);
|
|
text-transform: uppercase;
|
|
letter-spacing: calc(var(--space-xs) / 8);
|
|
}
|
|
|
|
/* Toggle switch */
|
|
.skills-view-item-toggle {
|
|
position: relative;
|
|
display: flex;
|
|
align-items: center;
|
|
cursor: pointer;
|
|
user-select: none;
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.skills-view-item-toggle input {
|
|
position: absolute;
|
|
width: calc(var(--space-xs) / 4);
|
|
height: calc(var(--space-xs) / 4);
|
|
padding: 0;
|
|
margin: calc(var(--space-xs) / -4);
|
|
overflow: hidden;
|
|
clip: rect(0, 0, 0, 0);
|
|
white-space: nowrap;
|
|
border: 0;
|
|
}
|
|
|
|
.skills-view-toggle-slider {
|
|
position: relative;
|
|
width: calc(var(--space-xl) + var(--space-lg));
|
|
height: calc(var(--space-xl) - (var(--space-xs) / 2));
|
|
background: var(--border);
|
|
border-radius: var(--radius-md);
|
|
transition: background var(--transition-normal);
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.skills-view-toggle-slider::after {
|
|
content: "";
|
|
position: absolute;
|
|
top: calc(var(--space-xs) / 2);
|
|
left: calc(var(--space-xs) / 2);
|
|
width: calc(var(--space-lg) + (var(--space-xs) / 2));
|
|
height: calc(var(--space-lg) + (var(--space-xs) / 2));
|
|
background: var(--card);
|
|
border-radius: 50%;
|
|
transition: transform var(--transition-normal);
|
|
}
|
|
|
|
.skills-view-item-toggle input:checked + .skills-view-toggle-slider {
|
|
background: var(--color-success);
|
|
}
|
|
|
|
.skills-view-item-toggle input:checked + .skills-view-toggle-slider::after {
|
|
transform: translateX(calc(var(--space-lg) + (var(--space-xs) / 2)));
|
|
}
|
|
|
|
/* Skills search — at top */
|
|
.skills-view-search {
|
|
margin-bottom: var(--space-lg);
|
|
}
|
|
|
|
.skills-view-search .form-input {
|
|
width: 100%;
|
|
max-width: calc(var(--space-2xl) * 12 + var(--space-md));
|
|
}
|
|
|
|
/* Catalog grid */
|
|
.skills-view-grid {
|
|
display: grid;
|
|
grid-template-columns: repeat(auto-fill, minmax(calc(var(--space-2xl) * 8 + var(--space-lg)), 1fr));
|
|
gap: var(--space-md);
|
|
}
|
|
|
|
.skills-view-card {
|
|
background: var(--card);
|
|
border: 1px solid var(--border);
|
|
border-radius: var(--radius-md);
|
|
padding: var(--space-md);
|
|
min-height: calc(var(--space-2xl) * 3 + var(--space-xl));
|
|
display: flex;
|
|
flex-direction: column;
|
|
gap: var(--space-sm);
|
|
transition: background var(--transition-fast), border-color var(--transition-fast);
|
|
}
|
|
|
|
.skills-view-card:hover {
|
|
background: var(--card-hover);
|
|
border-color: var(--text-muted);
|
|
}
|
|
|
|
.skills-view-card-header {
|
|
display: flex;
|
|
align-items: flex-start;
|
|
justify-content: space-between;
|
|
gap: var(--space-sm);
|
|
}
|
|
|
|
.skills-view-card-install {
|
|
align-self: flex-start;
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.skills-view-card-title {
|
|
font-weight: 600;
|
|
color: var(--text);
|
|
margin: 0;
|
|
}
|
|
|
|
.skills-view-card-description {
|
|
color: var(--text-muted);
|
|
line-height: 1.45;
|
|
display: -webkit-box;
|
|
-webkit-line-clamp: 2;
|
|
-webkit-box-orient: vertical;
|
|
overflow: hidden;
|
|
margin: 0;
|
|
}
|
|
|
|
.skills-view-card-tags {
|
|
display: flex;
|
|
flex-wrap: wrap;
|
|
gap: var(--space-xs);
|
|
}
|
|
|
|
.skills-view-card-installs {
|
|
color: var(--text-dim);
|
|
margin-top: auto;
|
|
}
|
|
|
|
/* Empty / error / loading states */
|
|
.skills-view-empty {
|
|
display: flex;
|
|
flex-direction: column;
|
|
align-items: center;
|
|
gap: var(--space-md);
|
|
padding: var(--space-2xl);
|
|
border: 1px dashed var(--border);
|
|
border-radius: var(--radius-md);
|
|
text-align: center;
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.skills-view-error {
|
|
display: flex;
|
|
flex-direction: column;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
padding: var(--space-lg);
|
|
color: var(--color-error);
|
|
background: color-mix(in srgb, var(--color-error) 8%, transparent);
|
|
border: 1px solid color-mix(in srgb, var(--color-error) 25%, transparent);
|
|
border-radius: var(--radius-md);
|
|
text-align: center;
|
|
}
|
|
|
|
.skills-view-loading {
|
|
display: flex;
|
|
align-items: center;
|
|
justify-content: center;
|
|
gap: var(--space-sm);
|
|
padding: var(--space-xl);
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
/* Close button */
|
|
.skills-view-close {
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
/* === Skill Detail Panel === */
|
|
.skills-view-item--selected {
|
|
border-color: var(--todo);
|
|
background: var(--card-hover);
|
|
}
|
|
|
|
.skills-view-detail {
|
|
background: var(--surface);
|
|
border: 1px solid var(--border);
|
|
border-left: calc(var(--space-md) / 4) solid var(--todo);
|
|
border-radius: var(--radius-md);
|
|
margin: var(--space-sm) 0 var(--space-md) 0;
|
|
padding: var(--space-lg);
|
|
}
|
|
|
|
.skills-view-detail-header {
|
|
display: flex;
|
|
align-items: center;
|
|
justify-content: space-between;
|
|
gap: var(--space-md);
|
|
margin-bottom: var(--space-md);
|
|
padding-bottom: var(--space-md);
|
|
border-bottom: 1px solid var(--border);
|
|
}
|
|
|
|
.skills-view-detail-title {
|
|
font-weight: 600;
|
|
color: var(--text);
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
}
|
|
|
|
.skills-view-detail-close {
|
|
flex-shrink: 0;
|
|
}
|
|
|
|
.skills-view-detail-content {
|
|
font-family: var(--font-mono);
|
|
line-height: 1.5;
|
|
overflow-x: auto;
|
|
white-space: pre-wrap;
|
|
word-break: break-word;
|
|
color: var(--text);
|
|
background: var(--bg);
|
|
padding: var(--space-md);
|
|
border-radius: var(--radius-sm);
|
|
max-height: calc(var(--space-2xl) * 12 + var(--space-md));
|
|
overflow-y: auto;
|
|
}
|
|
|
|
.skills-view-detail-files {
|
|
display: flex;
|
|
flex-wrap: wrap;
|
|
align-items: center;
|
|
gap: var(--space-xs);
|
|
margin-top: var(--space-md);
|
|
padding-top: var(--space-sm);
|
|
border-top: 1px solid var(--border);
|
|
}
|
|
|
|
.skills-view-detail-files-label {
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.skills-view-detail-loading {
|
|
display: flex;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
padding: var(--space-md);
|
|
color: var(--text-muted);
|
|
}
|
|
|
|
.skills-view-detail-error {
|
|
display: flex;
|
|
flex-direction: column;
|
|
align-items: center;
|
|
gap: var(--space-sm);
|
|
padding: var(--space-md);
|
|
color: var(--color-error);
|
|
background: color-mix(in srgb, var(--color-error) 10%, transparent);
|
|
border-radius: var(--radius-sm);
|
|
text-align: center;
|
|
}
|
|
|
|
.skills-view-detail-empty {
|
|
padding: var(--space-md);
|
|
color: var(--text-muted);
|
|
font-style: italic;
|
|
}
|
|
|
|
@media (max-width: 768px) {
|
|
.skills-view-content {
|
|
padding: var(--space-md);
|
|
}
|
|
|
|
.skills-view-section {
|
|
margin-bottom: var(--space-md);
|
|
}
|
|
|
|
.skills-view-section-title {
|
|
}
|
|
|
|
.skills-view-card {
|
|
padding: var(--space-sm);
|
|
}
|
|
|
|
.skills-view-card-title {
|
|
}
|
|
|
|
.skills-view-card-description {
|
|
}
|
|
|
|
.skills-view-empty {
|
|
padding: var(--space-lg);
|
|
}
|
|
|
|
.skills-view-error {
|
|
padding: var(--space-lg);
|
|
}
|
|
|
|
.skills-view-loading {
|
|
padding: var(--space-md);
|
|
}
|
|
|
|
.skills-view-search .form-input {
|
|
width: 100%;
|
|
max-width: none;
|
|
}
|
|
|
|
.skills-view-grid {
|
|
grid-template-columns: 1fr;
|
|
}
|
|
|
|
.skills-view-card-header {
|
|
flex-wrap: wrap;
|
|
}
|
|
|
|
.skills-view-item {
|
|
padding: var(--space-md);
|
|
min-height: calc(var(--space-lg) + var(--space-md) + var(--space-xs));
|
|
flex-wrap: nowrap;
|
|
}
|
|
|
|
.skills-view-item-info {
|
|
flex: 1 1 auto;
|
|
width: auto;
|
|
}
|
|
|
|
.skills-view-item-toggle {
|
|
padding: var(--space-sm);
|
|
}
|
|
|
|
.skills-view-item--selected {
|
|
border-color: var(--todo);
|
|
}
|
|
|
|
.skills-view-toggle-slider {
|
|
min-width: calc(var(--space-xl) + var(--space-lg));
|
|
min-height: calc(var(--space-xl) - (var(--space-xs) / 2));
|
|
}
|
|
|
|
.skills-view-detail {
|
|
padding: var(--space-md);
|
|
}
|
|
|
|
.skills-view-detail-content {
|
|
max-height: calc(60dvh - (var(--space-2xl) * 6 + var(--space-xs)));
|
|
-webkit-overflow-scrolling: touch;
|
|
}
|
|
|
|
.skills-view-detail-close {
|
|
min-width: calc(var(--space-lg) + var(--space-md) + var(--space-xs));
|
|
min-height: calc(var(--space-lg) + var(--space-md) + var(--space-xs));
|
|
}
|
|
}
|
|
|