Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
128 lines
5.2 KiB
TypeScript
128 lines
5.2 KiB
TypeScript
import fs from "node:fs";
|
|
import { loadAllAppCss } from "../../test/cssFixture";
|
|
import path from "node:path";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
const indexHtmlPath = path.resolve(__dirname, "../../index.html");
|
|
|
|
function getMainMobileSection(css: string): string {
|
|
// After CSS extraction, mobile rules live both in styles.css's
|
|
// "Mobile Responsive Overrides" section AND in @media (max-width: 768px)
|
|
// blocks at the bottom of each co-located component CSS file. Treat the
|
|
// union of all 768px-and-below media blocks as the "main mobile section".
|
|
const matches = [...css.matchAll(/@media\s*\(max-width:\s*768px\)\s*\{/g)];
|
|
expect(matches.length).toBeGreaterThan(0);
|
|
|
|
const parts: string[] = [];
|
|
for (const match of matches) {
|
|
const start = match.index!;
|
|
const open = css.indexOf("{", start);
|
|
let depth = 1;
|
|
let i = open + 1;
|
|
while (i < css.length && depth > 0) {
|
|
if (css[i] === "{") depth++;
|
|
else if (css[i] === "}") depth--;
|
|
i++;
|
|
}
|
|
parts.push(css.slice(start, i));
|
|
}
|
|
return parts.join("\n");
|
|
}
|
|
|
|
function getFirstRootBlock(css: string): string {
|
|
const match = css.match(/:root\s*\{([\s\S]*?)\n\}/);
|
|
expect(match).toBeTruthy();
|
|
return match![1];
|
|
}
|
|
|
|
describe("mobile CSS foundation", () => {
|
|
it("defines canonical mobile breakpoint custom properties in the first :root block", () => {
|
|
const css = loadAllAppCss();
|
|
const firstRoot = getFirstRootBlock(css);
|
|
|
|
expect(firstRoot).toContain("--mobile-breakpoint: 768px;");
|
|
expect(firstRoot).toContain("--tablet-breakpoint: 1024px;");
|
|
expect(firstRoot).toContain("--small-breakpoint: 480px;");
|
|
expect(firstRoot).toContain("--xsmall-breakpoint: 640px;");
|
|
});
|
|
|
|
it("provides a touch-target utility class with 44px minimum dimensions", () => {
|
|
const css = loadAllAppCss();
|
|
const touchTargetMatch = css.match(/\.touch-target\s*\{([\s\S]*?)\}/);
|
|
|
|
expect(touchTargetMatch).toBeTruthy();
|
|
expect(touchTargetMatch![1]).toContain("min-width: 44px;");
|
|
expect(touchTargetMatch![1]).toContain("min-height: 44px;");
|
|
});
|
|
|
|
it("enforces 16px font size for text inputs in the main mobile media query", () => {
|
|
const css = loadAllAppCss();
|
|
const mobileSection = getMainMobileSection(css);
|
|
|
|
expect(mobileSection).toContain("@media (max-width: 768px)");
|
|
expect(mobileSection).toContain('input[type="text"]');
|
|
expect(mobileSection).toContain('input[type="search"]');
|
|
expect(mobileSection).toContain('input[type="tel"]');
|
|
expect(mobileSection).toContain("select,");
|
|
expect(mobileSection).toContain("textarea {");
|
|
expect(mobileSection).toContain("font-size: 16px;");
|
|
});
|
|
|
|
it("applies safe-area inset handling in the main mobile section", () => {
|
|
const css = loadAllAppCss();
|
|
const mobileSection = getMainMobileSection(css);
|
|
|
|
expect(mobileSection).toContain("#root {");
|
|
expect(mobileSection).toContain("padding-top: env(safe-area-inset-top, 0px);");
|
|
expect(mobileSection).toContain("padding-bottom: env(safe-area-inset-bottom, 0px);");
|
|
expect(mobileSection).toContain(".header {");
|
|
expect(mobileSection).toContain("padding-left: max(var(--space-md), env(safe-area-inset-left, 0px));");
|
|
expect(mobileSection).toContain(".board {");
|
|
expect(mobileSection).toContain("padding-bottom: max(var(--space-md), env(safe-area-inset-bottom, 0px));");
|
|
expect(mobileSection).toContain(".modal,");
|
|
expect(mobileSection).toContain("padding-bottom: env(safe-area-inset-bottom, 0px);");
|
|
});
|
|
|
|
it("adds mobile overflow guards for wide content", () => {
|
|
const css = loadAllAppCss();
|
|
const mobileSection = getMainMobileSection(css);
|
|
|
|
expect(mobileSection).toContain("* {");
|
|
expect(mobileSection).toContain("max-width: 100vw;");
|
|
expect(mobileSection).toContain("pre,");
|
|
expect(mobileSection).toContain("overflow-x: auto;");
|
|
expect(mobileSection).toContain(".code-block");
|
|
expect(mobileSection).toContain("word-break: break-all;");
|
|
expect(mobileSection).toContain("word-break: break-word;");
|
|
expect(mobileSection).toContain("img,");
|
|
expect(mobileSection).toContain("svg {");
|
|
expect(mobileSection).toContain("max-width: 100%;");
|
|
expect(mobileSection).toContain("table {");
|
|
expect(mobileSection).toContain("display: block;");
|
|
expect(mobileSection).toContain("-webkit-overflow-scrolling: touch;");
|
|
expect(mobileSection).toContain(".workflow-step-manager-modal {");
|
|
expect(mobileSection).toContain("max-height: 100dvh;");
|
|
});
|
|
|
|
it("keeps the capacitor viewport meta tag configured", () => {
|
|
const html = fs.readFileSync(indexHtmlPath, "utf-8");
|
|
|
|
expect(html).toContain("name=\"viewport\"");
|
|
expect(html).toContain("width=device-width");
|
|
expect(html).toContain("maximum-scale=1.0");
|
|
expect(html).toContain("user-scalable=no");
|
|
});
|
|
|
|
it("uses only approved max-width breakpoint values", () => {
|
|
const css = loadAllAppCss();
|
|
const matches = [...css.matchAll(/@media\s*\(max-width:\s*(\d+)px\)/g)];
|
|
const foundValues = new Set(matches.map((match) => Number(match[1])));
|
|
const allowedValues = new Set([480, 640, 768, 860]);
|
|
|
|
expect(foundValues.size).toBeGreaterThan(0);
|
|
for (const value of foundValues) {
|
|
expect(allowedValues.has(value)).toBe(true);
|
|
}
|
|
});
|
|
});
|