gsxdsm
ea008b4064
docs(core): an empty role result has TWO meanings — correcting a rule I applied across three PRs ( #2765 )
...
## A correction to a rule I introduced, prompted by #2760 and then
measured
`synthesizeDefaultColumns` (`workflow-ir.ts`) upgrades a v1 graph by
emitting `{ id, name: id, traits: [] }` for the five default ids —
**placement only, by design**, with the real trait set living in
`BUILTIN_CODING_WORKFLOW_IR`.
So a v1-upgraded board arrives at every role resolver looking exactly
like a v2 board that declares nothing. Measured on such an IR:
| resolver | result |
|---|---|
| `resolveLifecycleColumns` | `{}` — every role undefined |
| `resolveReviewColumns` | `[]` |
| `columnsWithFlag(…, "countsTowardWip")` | `[]` |
| `resolveTerminalColumns` | `["done","archived"]` — its own legacy
fallback saves it |
## The correction I owe
I introduced **"resolved and empty means this board declares no such
lane"** deliberately across #2731 , #2733 and #2734 , to fix the
*opposite* bug — a legacy fallback masking a genuinely absent lane. I
argued for it repeatedly and applied it in several files.
It is right for hand-written v2. It is **wrong for the upgrade path**,
where it withdraws every role at once. And the two cases are
indistinguishable at the call site: both arrive as an empty array.
The contrast the test pins is the sharpest evidence —
`resolveTerminalColumns` survives the identical IR purely because it
never adopted that reading. **The data is the same; the reading is what
differs.**
## Affected, named rather than left to be rediscovered
- **on `main` today**: `default-workflow-hooks.ts` → `inRole` (from
#2734 )
- **in my open PRs**: the store bypass guard (#2709 ) and the
tracking-state terminal classifier (#2754 )
Consumers that kept a `length > 0 ? resolved : legacy` guard are
unaffected — including the notifier (#2722 ), which I checked.
## Not fixed here
The root repair is for the upgrade to carry real traits instead of
placeholders. That changes behaviour for **every persisted v1
workflow**, so it wants its own change with its own measurement — not
something slipped into a doc commit. Flagged at the source so the next
consumer chooses knowingly.
## Verification
34 trait tests green · core `tsc` clean · lint clean (0 errors) · gate
green (487 + 158 + 10 + 71). No production behaviour change; no census
movement.
2026-07-30 08:25:08 -07:00
..
2026-07-27 15:25:17 -07:00
2026-07-30 08:25:08 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 12:01:19 -07:00
2026-07-30 02:38:58 -07:00
2026-07-30 08:09:36 -07:00
2026-07-30 02:38:58 -07:00
2026-07-15 10:36:10 -07:00
2026-07-30 02:08:26 -07:00
2026-06-07 18:51:46 -07:00
2026-07-15 16:17:37 -07:00
2026-07-04 10:42:21 -07:00
2026-07-09 19:58:05 -07:00
2026-07-29 22:39:14 -07:00
2026-07-30 08:09:36 -07:00
2026-07-30 05:52:01 -07:00
2026-07-13 19:07:58 -07:00
2026-06-02 18:46:33 -07:00
2026-07-26 12:01:19 -07:00
2026-07-01 16:19:03 -07:00
2026-07-19 13:34:25 -07:00
2026-07-26 23:28:42 -07:00
2026-07-21 23:10:08 -07:00
2026-07-16 17:05:29 -07:00
2026-07-29 10:26:46 -07:00
2026-07-16 16:01:29 -07:00
2026-07-23 20:19:18 -07:00
2026-07-14 08:16:42 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 08:16:42 -07:00
2026-07-28 23:23:13 -07:00
2026-07-16 05:33:55 -07:00
2026-07-24 18:09:32 -07:00
2026-07-18 11:34:42 -07:00
2026-07-16 00:30:59 -07:00
2026-07-16 16:01:29 -07:00
2026-07-13 19:07:58 -07:00
2026-07-18 13:18:08 -07:00
2026-07-18 13:18:08 -07:00
2026-07-16 00:30:59 -07:00
2026-07-14 22:13:30 -07:00
2026-07-21 00:00:08 -07:00
2026-07-23 16:12:44 -07:00
2026-07-26 12:01:19 -07:00
2026-07-13 19:07:58 -07:00
2026-07-16 16:01:29 -07:00
2026-07-14 12:41:10 -07:00
2026-07-26 12:01:19 -07:00
2026-07-17 01:23:32 -07:00
2026-07-14 13:36:08 -07:00
2026-07-26 23:28:42 -07:00
2026-07-12 19:43:41 -07:00
2026-06-21 13:32:19 -07:00
2026-07-16 16:34:09 -07:00
2026-07-16 16:34:09 -07:00
2026-07-30 06:48:00 -07:00
2026-06-07 20:43:44 -07:00
2026-06-03 13:51:13 -07:00
2026-06-03 09:23:44 -07:00
2026-07-05 11:31:48 -07:00
2026-06-29 14:00:32 -07:00
2026-06-29 18:41:43 -07:00
2026-07-26 23:42:46 -07:00
2026-07-28 22:19:28 -07:00
2026-07-01 16:43:08 -07:00
2026-06-29 11:07:11 -07:00
2026-06-29 12:23:20 -07:00
2026-07-26 23:42:46 -07:00
2026-06-29 12:23:20 -07:00
2026-07-05 16:58:42 -07:00
2026-07-29 09:54:39 -07:00
2026-07-26 23:42:46 -07:00
2026-06-08 23:38:32 -07:00
2026-06-26 00:26:03 -07:00
2026-06-29 11:24:41 -07:00
2026-07-29 00:05:29 -07:00
2026-07-29 09:54:39 -07:00
2026-07-29 22:41:17 -07:00
2026-07-14 22:13:30 -07:00
2026-07-24 18:09:32 -07:00
2026-07-24 18:09:32 -07:00
2026-07-16 00:30:59 -07:00
2026-06-04 22:52:20 -07:00
2026-06-05 00:57:49 -07:00
2026-06-05 13:59:50 -07:00
2026-07-30 03:01:36 -07:00
2026-07-20 09:57:38 -07:00
2026-07-16 21:42:44 -07:00
2026-07-18 11:34:42 -07:00
2026-05-27 21:31:12 -07:00
2026-07-13 19:07:58 -07:00
2026-07-13 19:07:58 -07:00
2026-07-30 07:05:05 -07:00
2026-07-18 12:32:07 -07:00
2026-06-26 14:55:01 -07:00
2026-07-26 12:01:19 -07:00
2026-06-04 08:00:33 -07:00
2026-07-25 23:44:56 -07:00
2026-07-22 19:28:51 -07:00
2026-07-22 08:53:31 -07:00
2026-07-14 08:16:42 -07:00
2026-07-14 08:16:42 -07:00
2026-07-14 08:16:42 -07:00
2026-07-13 19:07:58 -07:00
2026-06-26 08:40:59 -07:00
2026-07-26 10:23:00 -07:00
2026-07-21 18:00:35 -07:00
2026-05-23 04:18:55 -07:00
2026-07-16 16:01:29 -07:00
2026-06-12 09:24:02 -07:00
2026-07-14 22:13:30 -07:00
2026-07-19 18:45:27 -07:00
2026-07-17 23:56:34 -07:00
2026-07-18 00:33:14 -07:00
2026-07-17 23:56:34 -07:00
2026-07-13 19:07:58 -07:00
2026-07-02 19:01:09 -07:00
2026-07-13 19:07:58 -07:00
2026-07-02 11:38:34 -07:00
2026-07-16 16:34:09 -07:00
2026-07-18 11:34:42 -07:00
2026-05-30 22:53:24 -07:00
2026-05-28 10:32:16 -07:00
2026-05-28 10:32:16 -07:00
2026-07-09 21:36:14 -07:00
2026-07-18 13:18:08 -07:00
2026-06-28 16:51:49 -07:00
2026-07-16 14:31:59 -07:00
2026-07-27 19:49:05 -07:00
2026-07-30 05:40:54 -07:00
2026-07-30 05:40:54 -07:00
2026-07-13 19:07:58 -07:00
2026-07-13 19:07:58 -07:00
2026-07-22 18:16:00 -07:00
2026-07-30 02:19:32 -07:00
2026-07-26 09:50:43 -07:00
2026-07-16 20:37:05 -07:00
2026-07-26 12:01:19 -07:00
2026-07-22 15:25:20 -07:00
2026-06-26 11:56:12 -07:00
2026-07-11 17:16:49 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 12:01:19 -07:00
2026-07-26 17:48:46 -07:00
2026-07-21 00:00:08 -07:00
2026-07-26 12:01:19 -07:00
2026-07-14 22:13:30 -07:00
2026-07-26 12:01:19 -07:00
2026-07-23 16:12:44 -07:00
2026-07-18 19:18:57 -07:00
2026-05-23 03:09:00 -07:00
2026-07-16 19:48:11 -07:00
2026-07-22 08:53:31 -07:00
2026-06-15 19:57:20 -07:00
2026-06-11 20:53:01 -07:00
2026-06-14 15:29:35 -07:00
2026-06-25 03:44:22 -07:00
2026-07-16 19:36:02 -07:00
2026-06-13 02:54:57 -07:00
2026-07-26 12:01:19 -07:00
2026-07-07 22:06:20 -07:00
2026-06-13 23:20:06 -07:00
2026-07-09 23:12:02 -07:00
2026-07-18 11:49:11 -07:00
2026-07-15 02:19:19 -07:00
2026-07-04 19:29:47 +00:00
2026-07-14 20:27:35 -07:00
2026-07-14 20:27:35 -07:00
2026-07-14 22:13:30 -07:00
2026-07-15 21:33:11 -07:00
2026-07-04 13:51:09 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 20:27:35 -07:00
2026-07-14 20:27:35 -07:00
2026-07-11 22:16:48 -07:00
2026-07-20 17:35:06 -07:00
2026-07-13 19:07:58 -07:00
2026-06-04 01:43:26 -07:00
2026-07-26 08:35:04 -07:00
2026-07-26 08:35:04 -07:00
2026-07-10 07:46:52 -07:00
2026-07-12 11:52:24 -07:00
2026-07-26 23:28:42 -07:00
2026-07-22 15:25:20 -07:00
2026-07-20 01:54:42 -07:00
2026-06-15 19:44:17 -07:00
2026-07-26 09:50:43 -07:00
2026-07-20 13:40:50 -07:00
2026-07-16 16:01:29 -07:00
2026-07-14 22:13:30 -07:00
2026-07-23 11:41:15 -07:00
2026-06-05 03:56:29 -07:00
2026-07-26 12:01:19 -07:00
2026-07-18 16:18:15 -07:00
2026-07-13 19:07:58 -07:00
2026-07-18 16:18:15 -07:00
2026-07-15 20:53:05 -07:00
2026-07-19 11:50:52 -07:00
2026-07-26 23:28:42 -07:00
2026-05-19 17:19:02 -07:00
2026-07-26 23:28:42 -07:00
2026-07-13 19:07:58 -07:00
2026-07-14 20:27:35 -07:00
2026-07-14 22:13:30 -07:00
2026-07-29 23:34:41 -07:00
2026-07-16 15:37:42 -07:00
2026-07-15 13:32:33 -07:00
2026-06-26 00:28:31 -07:00
2026-07-15 10:38:04 -07:00
2026-07-16 20:37:05 -07:00
2026-07-14 22:13:30 -07:00
2026-07-14 22:13:30 -07:00
2026-07-27 19:49:05 -07:00
2026-07-27 14:19:32 -07:00
2026-06-30 07:31:59 -07:00
2026-07-30 07:53:28 -07:00
2026-07-19 15:20:39 -07:00
2026-07-18 19:31:30 -07:00
2026-06-21 13:32:19 -07:00
2026-07-30 05:52:01 -07:00
2026-07-26 13:15:36 -07:00
2026-07-26 13:15:36 -07:00
2026-07-22 08:30:12 -07:00
2026-06-04 13:19:55 -07:00
2026-06-28 01:43:08 -07:00
2026-05-19 05:16:37 -07:00
2026-06-19 06:51:57 -07:00
2026-06-18 03:24:57 -07:00
2026-07-19 11:50:52 -07:00
2026-07-18 14:54:54 -07:00
2026-06-24 10:45:21 -07:00
2026-07-27 14:19:32 -07:00
2026-07-19 21:19:56 -07:00
2026-07-20 13:40:50 -07:00
2026-07-13 19:07:58 -07:00
2026-07-16 00:30:59 -07:00
2026-07-14 08:16:42 -07:00
2026-07-30 05:33:27 -07:00
2026-06-04 02:13:48 -07:00
2026-06-04 00:19:57 -07:00
2026-06-04 00:19:58 -07:00
2026-06-04 00:19:58 -07:00
2026-07-29 22:39:14 -07:00
2026-07-26 12:01:19 -07:00
2026-06-03 13:48:02 -07:00
2026-07-13 19:07:58 -07:00
2026-07-30 03:10:35 -07:00
2026-07-14 13:36:08 -07:00
2026-07-27 13:30:13 -07:00
2026-06-07 21:19:10 -07:00
2026-06-07 20:43:44 -07:00
2026-07-29 22:39:50 -07:00
2026-07-29 00:05:29 -07:00
2026-07-27 15:06:19 -07:00
2026-07-30 08:25:08 -07:00
2026-07-01 16:43:08 -07:00
2026-07-26 09:40:37 -07:00
2026-07-21 12:17:47 -07:00
2026-06-21 21:23:41 -07:00
2026-07-28 18:52:46 -07:00
2026-07-23 08:53:06 -07:00
2026-07-16 01:32:23 -07:00
2026-07-26 12:24:29 -07:00
2026-07-10 01:49:15 -07:00
2026-07-19 11:50:52 -07:00
2026-07-29 22:39:33 -07:00
2026-07-16 15:27:03 -07:00
2026-06-13 21:17:20 -07:00