1cf86baa1c
## Summary
Wave 18 continues the package code-organization program after wave 17
domain folders (U4 Slice A from
`docs/plans/2026-07-14-001-refactor-package-code-organization-plan.md`).
### What changed
Peel **pure, behavior-preserving** helpers out of
`packages/engine/src/executor.ts` into domain modules under
`packages/engine/src/executor/`, with **stable re-exports** from
`executor.ts` so deep imports and `vi.mock("../executor.js")` keep
working.
| New module | Symbols |
|------------|---------|
| `executor/task-done-refusal.ts` | `evaluateTaskDoneRefusal`,
`determineRevisionResetStart`, skip-bypass refusal helper |
| `executor/workflow-feedback-paths.ts` |
`extractReferencedPathsFromWorkflowFeedback`,
`isAlwaysAllowedScopeLeakPath`, `workflowPathMatchesDeclaredScope` |
| `executor/workflow-step-verdict.ts` |
`FUSION_WORKFLOW_STEP_CONVENTIONS_PREAMBLE`, `parseWorkflowStepVerdict`
/ `parseWorkflowStepOutput`, step outcome types |
| `executor/await-input-parse.ts` | `parseAwaitInputSentinel`,
`parseAwaitInputQuestionToolCall` |
| `executor/no-commit-eligibility.ts` | `getNoCommitEligibilityReason`
(+ prompt heuristics) |
`executor.ts` live LOC ~**22817 → ~22427** (first pure-peel batch; more
peels needed to approach the 2k cap).
### Shims
- `old path` `executor.ts` public exports → `new path` `executor/*.ts` →
delete-when consumer deep-imports are re-pointed (not this PR)
### Test plan
- [x] `@fusion/engine` typecheck
- [x] Oracle: task-done refusal, skip-bypass, workflow malformed
verdict, scope-leak allowlist, executor-step-session, executor-prompt
- [x] `vitest --project=engine-core` (merge-gate curated suite)
- [ ] CI merge gate
**Stack:** wave17 (merged) → **this PR**
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* Improved recognition of workflow outcomes from structured and
conversational responses.
* Added support for extracting questions from await-input responses and
tool calls.
* Improved workflow feedback handling for referenced files and declared
scope patterns.
* Added clearer guidance for task execution, approvals, verification,
and available tools.
* **Bug Fixes**
* Prevented completion when required review approvals are missing or
revisions remain pending.
* Improved handling of workflows that legitimately require no code
changes.
* Added clearer refusal messages and more reliable revision restarts.
* Sanitized repository paths in Git remediation instructions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
27 lines
1.4 KiB
TypeScript
27 lines
1.4 KiB
TypeScript
/**
|
|
* FNXC:CodeOrganization 2026-08-04-02:05:
|
|
* Module-level TaskExecutor tuning constants peeled from executor.ts preamble (U4).
|
|
* Facades and free peels import from here so the class file is not a constants host.
|
|
*
|
|
* FNXC:SessionContention 2026-07-25-21:30:
|
|
* The contention ladder is deliberately long and slow compared with the provider-failure budget (2 fast
|
|
* retries): a lease is held for as long as the holder's own work takes — minutes, not milliseconds. Ten
|
|
* attempts backing off 5s→60s covers ~8 minutes of waiting, after which the task is left queued for
|
|
* ordinary re-dispatch rather than parked. (Backoff values live on the session-contention peel; this
|
|
* file keeps the sibling watchdog/retry ceilings that share the same "slow recovery" posture.)
|
|
*/
|
|
|
|
/** Maximum retry attempts for workflow step hard failures before giving up */
|
|
export const MAX_WORKFLOW_STEP_RETRIES = 3;
|
|
|
|
/** How long to wait before recovering a completed task still stuck in in-progress. */
|
|
export const COMPLETED_TASK_WATCHDOG_MS = 60_000;
|
|
|
|
/** How long to wait before retrying a workflow rerun handoff that never reached in-progress. */
|
|
export const WORKFLOW_RERUN_WATCHDOG_MS = 15_000;
|
|
|
|
export const MAX_WORKTREE_RETRIES = 3;
|
|
export const WORKTREE_RETRY_DELAYS = [100, 500, 1000] as const; // ms
|
|
export const MAX_AUTO_RECOVERY_ATTEMPTS = 3;
|
|
export const BRANCH_CONFLICT_TRIPWIRE_THRESHOLD = 5;
|