Files
fusion/packages/cli/src/__tests__/task-command-github-import-tracking.test.ts
gsxdsm 10b80453c4 FN-7978: share GitHub import dedup via sourceIssue-first helper
Unify GitHub issue import deduplication so prior imports stay marked after description edits or owner/repo casing changes.

- Extract shared buildGitHubIssueSource and isGitHubIssueAlreadyImported helpers in dashboard github.ts (sourceIssue-first, case-insensitive repo, sourceMetadata + description URL fallbacks)
- Route CLI import paths, extension tools, and dashboard single/batch import through the shared helpers
- Drop local description-URL-regex-only importedUrls dedup; list existing tasks with slim:false for full provenance
- Add regression coverage and changeset for the operator-facing fix

Files changed:
 .changeset/fn-7978-github-import-dedup.md          |  7 ++
 docs/gitlab-parity-inventory.md                    |  2 +-
 packages/cli/src/__tests__/extension.test.ts       | 12 ++--
 .../task-command-github-import-tracking.test.ts    |  6 ++
 packages/cli/src/commands/__tests__/task.test.ts   | 36 +++++++---
 packages/cli/src/commands/task.ts                  | 82 +++++++++-------------
 packages/cli/src/extension.ts                      | 35 ++-------
 packages/dashboard/src/__tests__/github.test.ts    | 22 +++++-
 .../dashboard/src/__tests__/routes-github.test.ts  |  8 +--
 packages/dashboard/src/github.ts                   | 62 +++++++++++++++-
 packages/dashboard/src/index.ts                    |  2 +-
 .../dashboard/src/routes/register-git-github.ts    | 33 +--------
 12 files changed, 174 insertions(+), 133 deletions(-)

Fusion-Task-Id: FN-7978

Fusion-Task-Lineage: 44f3d555-49fb-41e2-87d0-0a722462f132

Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
2026-07-15 15:16:19 -07:00

167 lines
6.1 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from "vitest";
const taskStoreCtorMock = vi.hoisted(() => vi.fn());
const runGhJsonAsyncMock = vi.hoisted(() => vi.fn());
const resolveProjectMock = vi.hoisted(() => vi.fn());
vi.mock("@fusion/core", async (importActual) => {
const actual = await importActual<typeof import("@fusion/core")>();
return {
...actual,
TaskStore: taskStoreCtorMock,
};
});
vi.mock("@fusion/core/gh-cli", () => ({
isGhAvailable: vi.fn(() => true),
isGhAuthenticated: vi.fn(() => true),
runGhJsonAsync: runGhJsonAsyncMock,
getGhErrorMessage: vi.fn((error: unknown) => (error instanceof Error ? error.message : String(error))),
}));
// FNXC:CliBoardMutation 2026-07-09-00:00: task.ts imports closeProjectStore +
// asLocalProjectContext from project-context; stub both so the whole-module
// mock stays accurate as task.ts's project-context surface grows.
vi.mock("../project-context.js", () => ({
resolveProject: resolveProjectMock,
closeProjectStore: vi.fn(async (context: { store: { close?: () => unknown } }) => {
try {
await context.store.close?.();
} catch {
// best-effort, mirrors production closeProjectStore
}
}),
asLocalProjectContext: vi.fn((store: unknown) => ({
projectId: process.cwd(),
projectPath: process.cwd(),
projectName: "current-project",
isRegistered: false,
store,
})),
createLocalStore: vi.fn(async () => new (taskStoreCtorMock as any)()),
}));
vi.mock("@fusion/dashboard", () => ({
registerGithubTrackingHook: vi.fn(),
// FNXC:CliTests 2026-07-13-09:40: Missing dashboard barrel exports added for mock completeness (scripts/check-mock-completeness.mjs gate).
GitLabClient: vi.fn(),
resolveGitlabAuth: vi.fn(() => ({})),
buildGitLabTaskProvenance: vi.fn(() => ({})),
isGitLabAlreadyImported: vi.fn(),
buildGitLabTaskDescription: vi.fn(),
buildGitHubIssueSource: vi.fn((owner: string, repo: string, issue: { number: number; html_url: string }) => ({
sourceIssue: { provider: "github", repository: `${owner}/${repo}`, externalIssueId: String(issue.number), issueNumber: issue.number, url: issue.html_url },
sourceMetadata: { issueUrl: issue.html_url, issueNumber: issue.number },
})),
isGitHubIssueAlreadyImported: vi.fn(() => false),
}));
vi.mock("@fusion/engine", () => ({
createFnAgent: vi.fn(),
runAiMerge: vi.fn(),
landWorkspaceTask: vi.fn(),
// FNXC:TestInfrastructure 2026-07-13-10:25: extension.ts named-imports this from @fusion/engine.
isInReviewMissingWorktreeSessionStartFailure: vi.fn(),
}));
vi.mock("@fusion/dashboard/planning", () => ({
createSession: vi.fn(),
submitResponse: vi.fn(),
RateLimitError: class RateLimitError extends Error {},
SessionNotFoundError: class SessionNotFoundError extends Error {},
InvalidSessionStateError: class InvalidSessionStateError extends Error {},
}));
import { runTaskImportFromGitHub } from "../commands/task.js";
describe("fn task import GitHub tracking defaults", () => {
beforeEach(() => {
vi.clearAllMocks();
vi.spyOn(console, "log").mockImplementation(() => {});
vi.spyOn(console, "error").mockImplementation(() => {});
resolveProjectMock.mockRejectedValue(new Error("No project context"));
runGhJsonAsyncMock.mockResolvedValue([
{
number: 1,
title: "Imported Issue",
body: "Imported issue body",
html_url: "https://github.com/owner/repo/issues/1",
labels: [],
},
]);
});
function mockStore(options: { projectSettings?: Record<string, unknown>; globalSettings?: Record<string, unknown> } = {}) {
const createTask = vi.fn().mockImplementation((input) => Promise.resolve({
id: "FN-001",
title: input.title,
description: input.description,
column: "triage",
}));
taskStoreCtorMock.mockImplementation(function () {
return {
init: vi.fn().mockResolvedValue(undefined),
listTasks: vi.fn().mockResolvedValue([]),
createTask,
getSettings: vi.fn().mockResolvedValue(options.projectSettings ?? {}),
getGlobalSettingsStore: vi.fn().mockReturnValue({
getSettings: vi.fn().mockResolvedValue(options.globalSettings ?? {}),
}),
};
});
return { createTask };
}
it("sets githubTracking.enabled for fn task import when project tracking defaults are on", async () => {
const { createTask } = mockStore({ projectSettings: { githubTrackingEnabledByDefault: true } });
await runTaskImportFromGitHub("owner/repo", { limit: 1 });
expect(createTask).toHaveBeenCalledWith(expect.objectContaining({
githubTracking: { enabled: true },
sourceIssue: expect.objectContaining({
provider: "github",
repository: "owner/repo",
issueNumber: 1,
}),
}));
});
it("sets githubTracking.enabled for fn task import when global tracking defaults are on", async () => {
const { createTask } = mockStore({ globalSettings: { githubTrackingDefaultEnabledForNewTasks: true } });
await runTaskImportFromGitHub("owner/repo", { limit: 1 });
expect(createTask).toHaveBeenCalledWith(expect.objectContaining({
githubTracking: { enabled: true },
sourceIssue: expect.objectContaining({ issueNumber: 1 }),
}));
});
it("sets githubTracking.enabled for fn task import when import linking is on and new-task defaults are off", async () => {
const { createTask } = mockStore({
projectSettings: {
githubTrackingEnabledByDefault: false,
githubLinkImportedIssuesToTracking: true,
},
});
await runTaskImportFromGitHub("owner/repo", { limit: 1 });
expect(createTask).toHaveBeenCalledWith(expect.objectContaining({
githubTracking: { enabled: true },
sourceIssue: expect.objectContaining({ provider: "github", repository: "owner/repo", issueNumber: 1 }),
}));
});
it("does not force githubTracking for fn task import when tracking defaults are off", async () => {
const { createTask } = mockStore();
await runTaskImportFromGitHub("owner/repo", { limit: 1 });
expect(createTask).toHaveBeenCalledWith(expect.not.objectContaining({
githubTracking: expect.anything(),
}));
});
});