root/sase.tr
1
0
Fork 0
Code Issues 5 Pull Requests 3 Actions 7 Packages Projects Releases Wiki Activity

fix(api): translation job IDs must not contain ':'
Some checks failed
QA Gate (P0/P1) / Test affected app (pull_request) Has been cancelled
Details

Browse Source 
Same BullMQ 5.68 restriction as the prefetch fix (acd5691): a custom job ID
containing ':' is rejected with "Custom Id cannot contain :". enqueueTranslation
built jobId `tr:<base64>`, so every enqueue threw — and both call sites
fire-and-forget with .catch(warn), so it failed silently: fresh terms were
NX-flagged as queued but never actually enqueued, leaving new EMEX/PCAT terms
untranslated (English). Use 'tr-' prefix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Semih Yesilyurt
2026-05-27 16:49:46 +03:00
parent acd5691f6b
commit dae76085ef
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/api/src/translations/translations.service.ts
View File

@@ -290,8 +290,9 @@ export class TranslationsService {
await this.translationQueue.add( await this.translationQueue.add(
"translate", "translate",
{ terms: chunk }, { terms: chunk },
// jobId hashes the chunk so identical retries collapse // jobId hashes the chunk so identical retries collapse.
{ jobId: `tr:${Buffer.from(chunk.sort().join("|")).toString("base64").slice(0, 32)}` }, // Prefix uses "-" not ":" — BullMQ rejects custom job IDs containing ":".
{ jobId: `tr-${Buffer.from(chunk.sort().join("|")).toString("base64").slice(0, 32)}` },
); );
} }
this.logger.debug(`Enqueued ${fresh.length} term(s) for async translation`); this.logger.debug(`Enqueued ${fresh.length} term(s) for async translation`);