fix(pl24): P4 decode returns null on model-selection page (Hyundai/Kia/Nissan) #109

root · 2026-06-05T02:37:38+03:00

root commented

2026-06-05 02:37:38 +03:00

When PL24 can't identify a VIN, vin-group.action redirects to vehicle.action (a brand-wide model picker). The generic P4 parser collapsed that page's

When PL24 can't identify a VIN, vin-group.action redirects to vehicle.action (a brand-wide model picker). The generic P4 parser collapsed that page's <title> to the brand name with a bogus VIN-char year, and doResolveVin's fastest-source-wins treated that truthy result as a definitive decode — masking the pcat/emex candidate fallback. parseP4VehicleResponse now returns null when the extracted model is just the brand (or contains the VIN), so the pipeline falls back to pcat/emex instead of storing a fake vehicle. Live discovery: 7/11 Hyundai/Kia/Nissan VINs hit the picker (newer 2024+ / Nissan EU model-pick catalog); the 4 PL24-indexed VINs (GETZ 02, RIO 15/17/20) still decode. Adds pl24-ford-legacy.service.spec.ts; biome-formats two pre-existing lines in the touched file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

root added 1 commit 2026-06-05 02:37:39 +03:00

fix(pl24): P4 decode returns null on model-selection page (Hyundai/Kia/Nissan)

QA Gate (P0/P1) / Test affected app (pull_request) Has been cancelled

Details

01ed1a4480

When PL24 can't identify a VIN, vin-group.action redirects to vehicle.action (a brand-wide model picker). The generic P4 parser collapsed that page's <title> to the brand name with a bogus VIN-char year, and doResolveVin's fastest-source-wins treated that truthy result as a definitive decode — masking the pcat/emex candidate fallback.

parseP4VehicleResponse now returns null when the extracted model is just the brand (or contains the VIN), so the pipeline falls back to pcat/emex instead of storing a fake vehicle. Live discovery: 7/11 Hyundai/Kia/Nissan VINs hit the picker (newer 2024+ / Nissan EU model-pick catalog); the 4 PL24-indexed VINs (GETZ 02, RIO 15/17/20) still decode. Adds pl24-ford-legacy.service.spec.ts; biome-formats two pre-existing lines in the touched file.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

root merged commit d27411a9f3 into main

2026-06-05 02:37:44 +03:00

root referenced this issue from a commit

2026-06-05 02:37:46 +03:00

Merge pull request 'fix(pl24): P4 decode returns null on model-selection page (Hyundai/Kia/Nissan)' (#109) from dev into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: root/sase.tr#109