root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(FN-5039): complete Step 5 — verify narrowed scope-leak warnings

Browse Source 
Fusion-Task-Id: FN-5039
Fusion-Task-Lineage: 324b7259-e08f-4051-b89c-b94836b73d5d
This commit is contained in:
Fusion (runfusion.ai)
2026-05-18 07:10:18 -07:00
committed by gsxdsm
parent 385a5cd2d8
commit 16bbeba37a
1 changed files with 71 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
packages/engine/src/__tests__/executor-capture-modified-files-attribution.test.ts
View File

@@ -1,4 +1,5 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { Task } from "@fusion/core";
import "./executor-test-helpers.js";
import { TaskExecutor } from "../executor.js";
import { BranchAttributionError } from "../branch-attribution.js";
@@ -108,4 +109,74 @@ describe("FN-5039 executor captureModifiedFiles attribution", () => {
expect(files).toEqual([]);
expect(filterFilesToOwnTaskCommitsMock).not.toHaveBeenCalled();
});
it("scope-leak guard excludes foreign-only contamination from warning", async () => {
const store = createMockStore();
store.parseFileScopeFromPrompt.mockResolvedValue(["task-file.ts"]);
const executor = new TaskExecutor(store as any, "/repo");
vi.spyOn(executor as any, "captureModifiedFiles").mockResolvedValue(["task-file.ts"]);
vi.spyOn(executor as any, "captureUncommittedModifiedFiles").mockResolvedValue([]);
const result = await (executor as any).evaluateTaskDoneScopeLeak(
{ id: "FN-5039", baseCommitSha: "base123" } as Task,
"/repo/.worktrees/wt",
"## Review Level: 1",
{ planOnlyScopeLeakEnforcement: "block" },
);
expect(result).toEqual({ blocked: false });
expect(store.logEntry).not.toHaveBeenCalledWith(
"FN-5039",
expect.stringMatching(/\[scope-leak\].*off-scope/),
undefined,
undefined,
);
});
it("scope-leak guard still warns for own committed off-scope files", async () => {
const store = createMockStore();
store.parseFileScopeFromPrompt.mockResolvedValue(["task-file.ts"]);
const executor = new TaskExecutor(store as any, "/repo");
vi.spyOn(executor as any, "captureModifiedFiles").mockResolvedValue(["task-file.ts", "AGENTS.md"]);
vi.spyOn(executor as any, "captureUncommittedModifiedFiles").mockResolvedValue([]);
const result = await (executor as any).evaluateTaskDoneScopeLeak(
{ id: "FN-5039", baseCommitSha: "base123" } as Task,
"/repo/.worktrees/wt",
"## Review Level: 1",
{ planOnlyScopeLeakEnforcement: "block" },
);
expect(result).toEqual(expect.objectContaining({ blocked: true }));
expect(store.logEntry).toHaveBeenCalledWith(
"FN-5039",
expect.stringMatching(/\[scope-leak\].*AGENTS\.md/),
undefined,
undefined,
);
});
it("scope-leak guard still warns for uncommitted off-scope files", async () => {
const store = createMockStore();
store.parseFileScopeFromPrompt.mockResolvedValue(["task-file.ts"]);
const executor = new TaskExecutor(store as any, "/repo");
vi.spyOn(executor as any, "captureModifiedFiles").mockResolvedValue(["task-file.ts"]);
vi.spyOn(executor as any, "captureUncommittedModifiedFiles").mockResolvedValue(["AGENTS.md"]);
const result = await (executor as any).evaluateTaskDoneScopeLeak(
{ id: "FN-5039", baseCommitSha: "base123" } as Task,
"/repo/.worktrees/wt",
"## Review Level: 1",
{ planOnlyScopeLeakEnforcement: "block" },
);
expect(result).toEqual(expect.objectContaining({ blocked: true }));
expect(store.logEntry).toHaveBeenCalledWith(
"FN-5039",
expect.stringMatching(/\[scope-leak\].*AGENTS\.md/),
undefined,
undefined,
);
});
});