root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(FN-424): keep audit logging non-blocking

Browse Source
This commit is contained in:
Phil Larson
2026-06-12 16:08:00 -07:00
parent f331419867
commit 285f238e92
2 changed files with 29 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/engine/src/__tests__/executor-task-done-invariant.test.ts
View File

@@ -206,6 +206,23 @@ describe("FN-4114 fn_task_done invariants", () => {
expect(result.content[0].text).toContain("fn_task_done refused: wrong_branch");
expect(store.moveTask).toHaveBeenCalledWith("FN-4114", "todo", { preserveProgress: true });
});
it("FN-4114 allows no-commit completion when noCommitsExpected audit logging fails", async () => {
const { store, tool } = await setup({ noCommitsExpected: true });
mockedExecSync.mockImplementation((cmd: string) => {
if (cmd.includes("rev-parse --show-toplevel")) return Buffer.from("/repo/.worktrees/swift-falcon\n");
if (cmd.includes("rev-parse --abbrev-ref HEAD")) return Buffer.from("fusion/fn-4114\n");
if (cmd.includes("rev-list --count")) return Buffer.from("0\n");
if (cmd.includes("rev-parse HEAD")) return Buffer.from("def456\n");
return Buffer.from("");
});
store.logEntry.mockImplementation(async (_id: string, message: string) => {
if (message.includes("no_commits guard skipped")) throw new Error("audit unavailable");
});
const result = await tool.execute("id", {});
expect(result.content[0].text).toContain("Task marked complete");
expect(store.updateStep).toHaveBeenCalled();
});
it("FN-416 allows plan-only operational no-source completion with zero commits when the explicit flag is missing", async () => {

18
packages/engine/src/executor.ts
View File

@@ -9530,12 +9530,18 @@ export class TaskExecutor {
: evaluatePromptDerivedNoCommitEligibility(task, typeof promptContent === "string" ? promptContent : "");
if (noCommitEligibility.eligible) {
executorLog.log(`${task.id}: fn_task_done no_commits guard skipped (${noCommitEligibility.reason})`);
await this.store.logEntry(
task.id,
`fn_task_done no_commits guard skipped (${noCommitEligibility.reason})`,
undefined,
this.getRunContextFor(task.id),
);
try {
await this.store.logEntry(
task.id,
`fn_task_done no_commits guard skipped (${noCommitEligibility.reason})`,
undefined,
this.getRunContextFor(task.id),
);
} catch (error) {
executorLog.warn(
`${task.id}: failed to write no_commits guard skip audit log: ${error instanceof Error ? error.message : String(error)}`,
);
}
return { ok: true };
}