root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(FN-4604): complete Step 4 — gate acceptance rollup when milestone criteria exist

Browse Source 
Fusion-Task-Id: FN-4604
Fusion-Task-Lineage: 71752cd0-eadb-4434-a2a3-d9fff562ea63
This commit is contained in:
Fusion
2026-05-15 07:41:02 -07:00
committed by gsxdsm
parent 07c1de77ca
commit 48b98eec6b
2 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/dashboard/app/components/MissionManager.tsx
View File

@@ -3423,7 +3423,9 @@ export function MissionManager({ isOpen, isInline = false, onClose, addToast, pr
)}
</div>
))}
{(!assertionsByMilestone.get(milestone.id) || assertionsByMilestone.get(milestone.id)?.length === 0) && !isCreatingAssertion && (
{(!assertionsByMilestone.get(milestone.id) || assertionsByMilestone.get(milestone.id)?.length === 0)
&& !isCreatingAssertion
&& !milestone.acceptanceCriteria?.trim() && (
featuresWithAcceptanceCriteria.length > 0 ? (
// Product contract (2026-05-15 #product): completion criteria canonically
// live on MissionFeature.acceptanceCriteria; MissionContractAssertion rows

24
packages/dashboard/app/components/__tests__/MissionManager.test.tsx
View File

@@ -4239,6 +4239,7 @@ describe("MissionManager", () => {
it("keeps empty-state nudge when assertions and feature acceptance criteria are both missing", async () => {
const missionDetail = JSON.parse(JSON.stringify(mockMissionDetail)) as typeof mockMissionDetail;
missionDetail.milestones[0].acceptanceCriteria = "";
missionDetail.milestones[0].slices[0].features = [
{
...missionDetail.milestones[0].slices[0].features[0],
@@ -4255,8 +4256,31 @@ describe("MissionManager", () => {
expect(screen.getAllByText(emptyAssertionsCopy)).toHaveLength(1);
});
it("hides feature acceptance rollup when milestone acceptance criteria already exists", async () => {
const missionDetail = JSON.parse(JSON.stringify(mockMissionDetail)) as typeof mockMissionDetail;
missionDetail.milestones[0].acceptanceCriteria = "- Session handling: Session refresh succeeds without logout";
missionDetail.milestones[0].slices[0].features = [
{
...missionDetail.milestones[0].slices[0].features[0],
id: "F-DERIVED-1",
title: "Session handling",
acceptanceCriteria: "Session refresh succeeds without logout",
},
];
globalThis.fetch = createDetailFetchMockForMissionDetail(missionDetail);
render(<MissionManager isOpen={true} onClose={vi.fn()} addToast={vi.fn()} />);
fireEvent.click(await screen.findByText("Build Auth System"));
await waitForDetailLoaded();
expect(screen.getAllByText(/Acceptance:/).length).toBeGreaterThan(0);
expect(screen.queryByTestId("milestone-feature-acceptance-rollup")).not.toBeInTheDocument();
});
it("shows feature acceptance rollup instead of false empty-state when assertions are absent", async () => {
const missionDetail = JSON.parse(JSON.stringify(mockMissionDetail)) as typeof mockMissionDetail;
missionDetail.milestones[0].acceptanceCriteria = "";
missionDetail.milestones[0].slices[0].features = [
{
...missionDetail.milestones[0].slices[0].features[0],