root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4988): complete Step 2 — reuse centralized session-start classifier

Browse Source 
Fusion-Task-Id: FN-4988
Fusion-Task-Lineage: d7f60c48-4cd0-4041-9bc6-10c55b87cd5f
This commit is contained in:
Fusion (runfusion.ai)
2026-05-18 04:44:19 -07:00
committed by gsxdsm
parent 040a9099de
commit 56eb33f7a1
2 changed files with 11 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/engine/src/__tests__/self-healing.test.ts
View File

@@ -1867,6 +1867,11 @@ describe("SelfHealingManager", () => {
});
describe("recoverMissingWorktreeReviewFailures", () => {
it("does not hard-code unusable-worktree assertion literals in self-healing", async () => {
const source = await readFile(join(process.cwd(), "packages/engine/src/self-healing.ts"), "utf8");
expect(source).not.toMatch(/Refusing to start coding agent/);
});
it("requeues failed in-review tasks with unusable-worktree session-start errors", async () => {
const managerWithRecovery = new SelfHealingManager(store, {
rootDir: "/tmp/test-project",

22
packages/engine/src/self-healing.ts
View File

@@ -31,6 +31,7 @@ import type { MeshLeaseManager } from "./mesh-lease-manager.js";
import { createLogger } from "./logger.js";
import { RemovalReason, getRegisteredWorktreeBranchMap, getRegisteredWorktreePaths, isUsableTaskWorktree, removeWorktree, resolveWorktreeBackend, scanIdleWorktrees, scanOrphanedBranches } from "./worktree-pool.js";
import {
classifyMissingWorktreeSessionStartFailure,
extractMissingWorktreePathFromSessionStartFailure,
isMissingWorktreeSessionStartFailure,
isRecoverableMissingWorktreeReviewFailureNoProgress,
@@ -310,18 +311,6 @@ function bumpTaskPriority(priority: TaskPriority | undefined): TaskPriority {
}
}
function classifyWorktreeSessionStartFailure(error: unknown): "missing" | "incomplete" | "unregistered" | "unknown" {
const text = typeof error === "string"
? error
: error instanceof Error
? error.message
: String(error);
if (text.startsWith("Refusing to start coding agent in missing worktree:")) return "missing";
if (text.startsWith("Refusing to start coding agent in incomplete worktree:")) return "incomplete";
if (text.startsWith("Refusing to start coding agent in unregistered git worktree:")) return "unregistered";
return "unknown";
}
export async function autoRecoverWorktreeSessionStartFailure(
store: TaskStore,
task: Task,
@@ -331,7 +320,7 @@ export async function autoRecoverWorktreeSessionStartFailure(
auditor: RunAuditor | null;
},
): Promise<{ outcome: "requeue-todo" | "escalate-exhausted"; retries: number; classification: "missing" | "incomplete" | "unregistered" | "unknown" }> {
const classification = classifyWorktreeSessionStartFailure(opts.failure);
const classification = classifyMissingWorktreeSessionStartFailure(opts.failure);
const nextCount = (task.worktreeSessionRetryCount ?? 0) + 1;
if (nextCount > MAX_WORKTREE_SESSION_RETRIES) {
await store.logEntry(
@@ -5396,9 +5385,10 @@ export class SelfHealingManager {
* Recover failed `in-review` retries that point at an unusable worktree path.
*
* This is a narrow guard for session-start failures thrown by
* assertValidWorktreeSession() (`Refusing to start coding agent in missing worktree:`,
* `Refusing to start coding agent in incomplete worktree:`, and
* `Refusing to start coding agent in unregistered git worktree:`).
* `assertValidWorktreeSession()` in `pi.ts`, classified centrally via
* `MISSING_WORKTREE_SESSION_PREFIXES` /
* `classifyMissingWorktreeSessionStartFailure()` in
* `restart-recovery-coordinator.ts`.
* We clear stale worktree metadata and failure state, keep step progress and
* retry counters, then requeue to todo for a clean retry.
*/