root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-1007): fix singular/plural for file count on task cards

Browse Source 
- Fix file count label to show singular 'file' when count is 1 and plural 'files' otherwise
- Add comprehensive tests for TaskCard file count display
- Test edge cases: zero files, single file, multiple files, and missing attachments
This commit is contained in:
gsxdsm
2026-04-05 19:35:53 -07:00
parent faa5ed51a9
commit 6a218ca4d8
2 changed files with 144 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/dashboard/app/components/TaskCard.tsx
View File

@@ -781,7 +781,7 @@ function TaskCardComponent({
>
<Folder size={12} />
<span>
{sessionFilesLoading ? "Checking files…" : `${sessionFiles.length} files changed`}
{sessionFilesLoading ? "Checking files…" : `${sessionFiles.length} ${sessionFiles.length === 1 ? "file" : "files"} changed`}
</span>
</button>
)}
@@ -800,7 +800,7 @@ function TaskCardComponent({
disabled={!onOpenDetailWithTab}
>
<Folder size={12} />
<span>{displayCount} files changed</span>
<span>{displayCount} {displayCount === 1 ? "file" : "files"} changed</span>
</button>
);
}
@@ -814,7 +814,7 @@ function TaskCardComponent({
disabled={!onOpenDetailWithTab}
>
<Folder size={12} />
<span>{modifiedCount} files changed</span>
<span>{modifiedCount} {modifiedCount === 1 ? "file" : "files"} changed</span>
</button>
);
}
@@ -828,7 +828,7 @@ function TaskCardComponent({
>
<Folder size={12} />
<span>
{sessionFilesLoading ? "Checking files…" : `${sessionFiles.length} files changed`}
{sessionFilesLoading ? "Checking files…" : `${sessionFiles.length} ${sessionFiles.length === 1 ? "file" : "files"} changed`}
</span>
</button>
);

140
packages/dashboard/app/components/__tests__/TaskCard.test.tsx
View File

@@ -3228,6 +3228,146 @@ describe("TaskCard files-changed in done column", () => {
});
});
describe("TaskCard singular/plural file count", () => {
const noopToast = vi.fn();
beforeEach(() => {
vi.clearAllMocks();
mockUseSessionFiles.mockReturnValue({ files: [], loading: false });
mockUseTaskDiffStats.mockReturnValue({ stats: null, loading: false });
});
it("displays '1 file changed' (singular) for in-progress column with 1 session file", () => {
const task = makeTask({
column: "in-progress",
worktree: "/repo/.worktrees/fn-099",
status: "executing",
});
mockUseSessionFiles.mockReturnValue({ files: ["src/a.ts"], loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("1 file changed")).toBeInTheDocument();
});
it("displays '2 files changed' (plural) for in-progress column with 2 session files", () => {
const task = makeTask({
column: "in-progress",
worktree: "/repo/.worktrees/fn-099",
status: "executing",
});
mockUseSessionFiles.mockReturnValue({ files: ["src/a.ts", "src/b.ts"], loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("2 files changed")).toBeInTheDocument();
});
it("displays '1 file changed' (singular) for done column with displayCount=1 via diffStats", () => {
const task = makeTask({
column: "done",
mergeDetails: { filesChanged: 7, mergedAt: "2026-01-01T00:00:00Z", targetBranch: "main" },
});
mockUseSessionFiles.mockReturnValue({ files: [], loading: false });
mockUseTaskDiffStats.mockReturnValue({ stats: { filesChanged: 1, additions: 5, deletions: 0 }, loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("1 file changed")).toBeInTheDocument();
expect(screen.queryByText("1 files changed")).not.toBeInTheDocument();
});
it("displays '1 file changed' (singular) for done column with modifiedFiles of length 1", () => {
const task = makeTask({
column: "done",
modifiedFiles: ["src/a.ts"],
});
mockUseSessionFiles.mockReturnValue({ files: [], loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("1 file changed")).toBeInTheDocument();
expect(screen.queryByText("1 files changed")).not.toBeInTheDocument();
});
it("displays '1 file changed' (singular) for done column with sessionFiles fallback of length 1", () => {
const task = makeTask({
column: "done",
worktree: "/repo/.worktrees/fn-099",
});
mockUseSessionFiles.mockReturnValue({ files: ["src/a.ts"], loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("1 file changed")).toBeInTheDocument();
expect(screen.queryByText("1 files changed")).not.toBeInTheDocument();
});
it("displays 'N files changed' (plural) for done column with diffStats count > 1", () => {
const task = makeTask({ column: "done" });
mockUseSessionFiles.mockReturnValue({ files: [], loading: false });
mockUseTaskDiffStats.mockReturnValue({ stats: { filesChanged: 3, additions: 10, deletions: 2 }, loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("3 files changed")).toBeInTheDocument();
});
it("displays 'N files changed' (plural) for done column with modifiedFiles length > 1", () => {
const task = makeTask({
column: "done",
modifiedFiles: ["src/a.ts", "src/b.ts"],
});
mockUseSessionFiles.mockReturnValue({ files: [], loading: false });
render(
<TaskCard
task={task}
onOpenDetail={vi.fn()}
addToast={noopToast}
/>
);
expect(screen.getByText("2 files changed")).toBeInTheDocument();
});
});
describe("TaskCard mission badge", () => {
const createTask = (overrides: Partial<Task> = {}): Task => ({
id: "FN-001",