root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(FN-4378): complete Step 1 — thread githubIssueAction through store

Browse Source 
Fusion-Task-Id: FN-4378
Fusion-Task-Lineage: d3867ba8-f852-41e3-9db0-584c0ffc23b1
This commit is contained in:
Fusion
2026-05-13 13:22:18 -07:00
committed by gsxdsm
parent c50e152a87
commit 6e5a92acd5
3 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/core/src/__tests__/store-github-tracking.test.ts
View File

@@ -196,6 +196,19 @@ describe("TaskStore github tracking", () => {
);
});
it("emits githubIssueAction metadata on task:deleted", async () => {
const task = await store.createTask({ description: "Delete tracking metadata" });
const deletedEvents: Array<{ id: string; action: string | undefined }> = [];
store.on("task:deleted", (deletedTask, meta) => {
deletedEvents.push({ id: deletedTask.id, action: meta?.githubIssueAction });
});
await store.deleteTask(task.id, { githubIssueAction: "delete" });
expect(deletedEvents).toEqual([{ id: task.id, action: "delete" }]);
});
it("persists disabled state, repo override, and issue mutations across repeated restarts", async () => {
const diskRoot = makeTmpDir();
const diskGlobal = makeTmpDir();

11
packages/core/src/store.ts
View File

@@ -3,7 +3,7 @@ import { randomUUID } from "node:crypto";
import { mkdir, readdir, readFile, writeFile, rename, unlink } from "node:fs/promises";
import { join } from "node:path";
import { existsSync, watch, type FSWatcher } from "node:fs";
import type { Task, TaskDetail, TaskCreateInput, TaskAttachment, AgentLogEntry, BoardConfig, Column, MergeResult, Settings, GlobalSettings, ProjectSettings, ActivityLogEntry, ActivityEventType, TaskDocument, TaskDocumentRevision, TaskDocumentCreateInput, TaskDocumentWithTask, InboxTask, TaskLogEntry, RunMutationContext, RunAuditEvent, RunAuditEventInput, RunAuditEventFilter, ArchivedTaskEntry, ArchiveAgentLogMode, TaskPriority, SourceType, WorkflowStepTemplate, Agent, AutostashOrphanRecord, TaskCommitAssociation, TaskCommitAssociationMatchSource, TaskCommitAssociationConfidence } from "./types.js";
import type { Task, TaskDetail, TaskCreateInput, TaskAttachment, AgentLogEntry, BoardConfig, Column, MergeResult, Settings, GlobalSettings, ProjectSettings, ActivityLogEntry, ActivityEventType, TaskDocument, TaskDocumentRevision, TaskDocumentCreateInput, TaskDocumentWithTask, InboxTask, TaskLogEntry, RunMutationContext, RunAuditEvent, RunAuditEventInput, RunAuditEventFilter, ArchivedTaskEntry, ArchiveAgentLogMode, TaskPriority, SourceType, WorkflowStepTemplate, Agent, AutostashOrphanRecord, TaskCommitAssociation, TaskCommitAssociationMatchSource, TaskCommitAssociationConfidence, GithubIssueAction } from "./types.js";
import { createActivityLogSnapshot, createRunAuditSnapshot, createTaskMetadataSnapshot, toTaskMetadataRecord, validateSnapshotEnvelope, type ActivityLogSnapshot, type RunAuditSnapshot, type TaskMetadataSnapshot } from "./shared-mesh-state.js";
import { VALID_TRANSITIONS, DEFAULT_SETTINGS, isGlobalOnlySettingsKey, WORKFLOW_STEP_TEMPLATES, validateDocumentKey } from "./types.js";
import { DEFAULT_PROJECT_SETTINGS } from "./settings-schema.js";
@@ -486,7 +486,7 @@ export interface TaskStoreEvents {
"task:created": [task: Task];
"task:moved": [data: { task: Task; from: Column; to: Column }];
"task:updated": [task: Task];
"task:deleted": [task: Task];
"task:deleted": [task: Task, meta?: { githubIssueAction?: GithubIssueAction }];
"task:merged": [result: MergeResult];
"settings:updated": [data: { settings: Settings; previous: Settings }];
"agent:log": [entry: AgentLogEntry];
@@ -4636,7 +4636,10 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
return paths;
}
async deleteTask(id: string, options?: { removeDependencyReferences?: boolean }): Promise<Task> {
async deleteTask(
id: string,
options?: { removeDependencyReferences?: boolean; githubIssueAction?: GithubIssueAction },
): Promise<Task> {
return this.withTaskLock(id, async () => {
// Flush buffered agent logs inside the lock so no new appends for this
// task can sneak in between flush and DELETE.
@@ -4680,7 +4683,7 @@ export class TaskStore extends EventEmitter<TaskStoreEvents> {
this.emit("task:updated", dependentTask);
}
this.emit("task:deleted", task);
this.emit("task:deleted", task, { githubIssueAction: options?.githubIssueAction ?? "auto" });
return task;
});
}

2
packages/core/src/types.ts
View File

@@ -638,6 +638,8 @@ export interface TaskGithubTrackedIssue {
lastSyncedAt?: string;
}
export type GithubIssueAction = "close" | "delete" | "leave" | "auto";
export interface TaskGithubTracking {
/** Per-task enabled override. When undefined, project/global default applies. */
enabled?: boolean;