root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-002): tighten pushState assertions to be action-specific per PR feedback

Browse Source
This commit is contained in:
Timothy Laurent
2026-05-05 13:05:01 -07:00
parent 85eabbc533
commit 7250b450de
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/dashboard/app/components/__tests__/navigation-history.test.tsx
View File

@@ -379,6 +379,7 @@ describe("Navigation history integration", () => {
it("pushes history entry when opening Settings modal on desktop", async () => {
await renderAppAndWait();
const pushCallsBefore = (window.history.pushState as any).mock.calls.length;
const settingsBtn = screen.getByTitle("Settings");
fireEvent.click(settingsBtn);
@@ -386,8 +387,8 @@ describe("Navigation history integration", () => {
expect(screen.getByTestId("settings-modal")).toBeTruthy();
});
// Back-button nav is enabled on desktop too
expect(window.history.pushState).toHaveBeenCalled();
// Back-button nav is enabled on desktop too — pushState called for the modal open
expect((window.history.pushState as any).mock.calls.length).toBeGreaterThan(pushCallsBefore);
});
// 2. Desktop: popstate dismisses modals
@@ -418,6 +419,7 @@ describe("Navigation history integration", () => {
await renderAppAndWait();
const pushCallsBefore = (window.history.pushState as any).mock.calls.length;
// Switch to agents view
const agentsTab = screen.queryByTitle("Agents");
if (!agentsTab) return;
@@ -428,7 +430,7 @@ describe("Navigation history integration", () => {
});
// pushState should have been called for the view change
expect(window.history.pushState).toHaveBeenCalled();
expect((window.history.pushState as any).mock.calls.length).toBeGreaterThan(pushCallsBefore);
});
// 4. Desktop: popstate reverts view changes