root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(FN-4728): complete Step 4 — cover shared tracking helper

Browse Source 
Fusion-Task-Id: FN-4728
Fusion-Task-Lineage: 6e8e9040-0c2f-4290-8905-1c1be8487894
This commit is contained in:
Fusion (runfusion.ai)
2026-05-16 07:57:57 -07:00
committed by gsxdsm
parent 22e0d0d094
commit 79f8dd68cf
1 changed files with 60 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

63
packages/dashboard/src/__tests__/github-tracking-hook.test.ts
View File

@@ -20,8 +20,8 @@ vi.mock("../github-auth.js", () => ({
resolveGithubTrackingAuth: (...args: unknown[]) => mockResolveGithubTrackingAuth(...args),
}));
import { registerGithubTrackingHook } from "../github-tracking-hook.js";
import { maybeCreateTrackingIssue } from "../github-tracking.js";
import { createTrackingIssueForTask, registerGithubTrackingHook } from "../github-tracking-hook.js";
import * as githubTracking from "../github-tracking.js";
function makeTmpDir(): string {
return mkdtempSync(join(tmpdir(), "kb-dashboard-github-tracking-hook-test-"));
@@ -148,7 +148,7 @@ describe("registerGithubTrackingHook", () => {
const staleTaskRef = { ...createdTask, githubTracking: { enabled: true } };
const projectSettings = await store.getSettings();
const result = await maybeCreateTrackingIssue(staleTaskRef, {
const result = await githubTracking.maybeCreateTrackingIssue(staleTaskRef, {
taskStore: store,
projectSettings,
globalSettings: {},
@@ -159,4 +159,61 @@ describe("registerGithubTrackingHook", () => {
expect(result).toEqual({ created: false, reason: "issue_already_linked" });
expect(mockCreateIssue).toHaveBeenCalledTimes(1);
});
it("passes request token when settings token is missing", async () => {
const task = await store.createTask({
description: "token override",
githubTracking: { enabled: true },
});
const spy = vi.spyOn(githubTracking, "maybeCreateTrackingIssue").mockResolvedValue({
created: false,
reason: "tracking_disabled",
});
await createTrackingIssueForTask(store, task, { githubToken: "request-token" });
expect(spy).toHaveBeenCalledWith(
task,
expect.objectContaining({
projectSettings: expect.objectContaining({ githubAuthToken: "request-token" }),
}),
);
spy.mockRestore();
});
it("prefers settings token over request token", async () => {
await store.updateSettings({ githubAuthToken: "settings-token" });
const task = await store.createTask({
description: "token precedence",
githubTracking: { enabled: true },
});
const spy = vi.spyOn(githubTracking, "maybeCreateTrackingIssue").mockResolvedValue({
created: false,
reason: "tracking_disabled",
});
await createTrackingIssueForTask(store, task, { githubToken: "request-token" });
expect(spy).toHaveBeenCalledWith(
task,
expect.objectContaining({
projectSettings: expect.objectContaining({ githubAuthToken: "settings-token" }),
}),
);
spy.mockRestore();
});
it("swallows maybeCreateTrackingIssue errors", async () => {
const task = await store.createTask({
description: "best effort",
githubTracking: { enabled: true },
});
const spy = vi.spyOn(githubTracking, "maybeCreateTrackingIssue").mockRejectedValue(new Error("boom"));
await expect(createTrackingIssueForTask(store, task)).resolves.toBeUndefined();
spy.mockRestore();
});
});