root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(FN-1778): resolve pre-existing typecheck errors in SettingsModal.tsx

Browse Source 
- Fix number input onChange handlers for maxConcurrent, pollIntervalMs, and maxWorktrees
- Add 'as any' type assertion to allow undefined values in form state
- Enables clearing numeric inputs to undefined for null-as-delete semantics
This commit is contained in:
gsxdsm
2026-04-14 13:10:43 -07:00
parent f0f3389dea
commit 841f57f394
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/dashboard/app/components/SettingsModal.tsx
View File

@@ -1338,8 +1338,7 @@ export function SettingsModal({
value={form.maxConcurrent ?? ""}
onChange={(e) => {
const val = e.target.value;
const num = Number(val);
setForm((f) => ({ ...f, maxConcurrent: val === "" || isNaN(num) ? f.maxConcurrent : num }));
setForm((f) => ({ ...f, maxConcurrent: val === "" ? undefined : Number(val) } as any));
}}
/>
</div>
@@ -1353,8 +1352,7 @@ export function SettingsModal({
value={form.pollIntervalMs ?? ""}
onChange={(e) => {
const val = e.target.value;
const num = Number(val);
setForm((f) => ({ ...f, pollIntervalMs: val === "" || isNaN(num) ? f.pollIntervalMs : num }));
setForm((f) => ({ ...f, pollIntervalMs: val === "" ? undefined : Number(val) } as any));
}}
/>
</div>
@@ -1486,8 +1484,7 @@ export function SettingsModal({
value={form.maxWorktrees ?? ""}
onChange={(e) => {
const val = e.target.value;
const num = Number(val);
setForm((f) => ({ ...f, maxWorktrees: val === "" || isNaN(num) ? f.maxWorktrees : num }));
setForm((f) => ({ ...f, maxWorktrees: val === "" ? undefined : Number(val) } as any));
}}
/>
<small>Limits total git worktrees including in-review tasks</small>