root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(core): sweep schema-version assertions to 115 (U1 follow-up)

Browse Source 
The migration-115 bump in U1 left many test files asserting the old version 114;
update them (db-migrate.test.ts now asserts the exported SCHEMA_VERSION constant
to drop it from future sweeps).
This commit is contained in:
gsxdsm
2026-06-12 01:31:28 -07:00
parent 483c71b014
commit 8f84116f91
8 changed files with 78 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
packages/core/src/__tests__/db-migrate.test.ts
View File

@@ -1,6 +1,6 @@
import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
import { detectLegacyData, migrateFromLegacy, getMigrationStatus } from "../db-migrate.js";
import { Database } from "../db.js";
import { Database, SCHEMA_VERSION } from "../db.js";
import { mkdir, writeFile, rm, readdir, appendFile } from "node:fs/promises";
import { join } from "node:path";
import { mkdtempSync, existsSync } from "node:fs";
@@ -715,8 +715,8 @@ describe("schema migration", () => {
const row = db.prepare("SELECT deletedAt FROM tasks WHERE id = 'FN-legacy'").get() as { deletedAt: string | null };
expect(row.deletedAt).toBeNull();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -749,8 +749,8 @@ describe("schema migration", () => {
{ id: "WS-001", mode: "prompt", gateMode: "advisory" },
{ id: "WS-002", mode: "script", gateMode: "advisory" },
]);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -800,8 +800,8 @@ describe("schema migration", () => {
reviewerContextRetryCount: 0,
reviewerFallbackRetryCount: 0,
});
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -830,8 +830,8 @@ describe("schema migration", () => {
const columns = db.prepare("PRAGMA table_info(milestones)").all() as Array<{ name: string }>;
expect(columns.map((column) => column.name)).toContain("acceptanceCriteria");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -872,8 +872,8 @@ describe("schema migration", () => {
const missionColumns = db.prepare("PRAGMA table_info(missions)").all() as Array<{ name: string }>;
expect(missionColumns.map((column) => column.name)).toContain("autoMerge");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -907,8 +907,8 @@ describe("schema migration", () => {
{ id: "WS-002", mode: "script", enabled: 1, gateMode: "advisory" },
{ id: "WS-003", mode: "prompt", enabled: 0, gateMode: "advisory" },
]);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -945,8 +945,8 @@ describe("schema migration", () => {
const indexes = db.prepare("PRAGMA index_list(mission_goals)").all() as Array<{ name: string }>;
expect(indexes.some((index) => index.name === "idxMissionGoalsGoalId")).toBe(true);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1007,7 +1007,7 @@ describe("schema migration", () => {
expect(customFieldsColumn).toBeDefined();
expect(customFieldsColumn?.dflt_value).toBe("'{}'");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1045,7 +1045,7 @@ describe("schema migration", () => {
const indexes = db.prepare("PRAGMA index_list(workflow_settings)").all() as Array<{ name: string }>;
expect(indexes.some((index) => index.name === "idx_workflow_settings_project")).toBe(true);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1127,7 +1127,7 @@ describe("schema migration", () => {
expect(indexNames).toContain("idx_cli_sessions_chatSessionId");
expect(indexNames).toContain("idx_cli_sessions_project_state");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1159,7 +1159,7 @@ describe("schema migration", () => {
.all() as Array<{ name: string }>;
expect(columns.map((column) => column.name)).toContain("cliExecutorAdapterId");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1169,7 +1169,7 @@ describe("schema migration", () => {
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table'").all() as Array<{ name: string }>;
expect(tables.map((row) => row.name)).toContain("cli_sessions");
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
@@ -1226,23 +1226,23 @@ describe("schema migration", () => {
.get() as { migrated_fragment_id: string | null };
expect(stepRow.migrated_fragment_id).toBeNull();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
});
it("migration 109 is idempotent on re-init", () => {
const db = new Database(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(db.getSchemaVersion()).toBe(SCHEMA_VERSION);
db.close();
// Re-open the same on-disk DB: already at 109, the 109 block must be a no-op.
const reopened = new Database(fusionDir);
reopened.init();
expect(reopened.getSchemaVersion()).toBe(114);
expect(reopened.getSchemaVersion()).toBe(114);
expect(reopened.getSchemaVersion()).toBe(SCHEMA_VERSION);
expect(reopened.getSchemaVersion()).toBe(SCHEMA_VERSION);
const workflowColumns = reopened.prepare("PRAGMA table_info(workflows)").all() as Array<{ name: string }>;
expect(workflowColumns.filter((c) => c.name === "kind")).toHaveLength(1);
const stepColumns = reopened.prepare("PRAGMA table_info(workflow_steps)").all() as Array<{ name: string }>;

84
packages/core/src/__tests__/db.test.ts
View File

@@ -334,8 +334,8 @@ describe("Database", () => {
});
it("seeds schema version", () => {
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
});
it("includes tokenUsageCacheWriteTokens on freshly initialized tasks table", () => {
@@ -394,8 +394,8 @@ describe("Database", () => {
it("is idempotent - calling init() twice does not fail", () => {
expect(() => db.init()).not.toThrow();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
});
it("does not overwrite existing config on re-init", () => {
// Update the config
@@ -1465,8 +1465,8 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29 (includes v1→v2 through v26→v29)
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -1491,16 +1491,16 @@ describe("schema migrations", () => {
const db = new Database(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
// Re-init should not fail
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
// Re-init should not fail
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
db.close();
});
@@ -1535,8 +1535,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("priority");
@@ -1577,8 +1577,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1650,8 +1650,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const colNames = cols.map((col) => col.name);
@@ -1891,8 +1891,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const cols = db.prepare("PRAGMA table_info(chat_messages)").all() as Array<{ name: string }>;
expect(cols.map((col) => col.name)).toContain("attachments");
@@ -1966,8 +1966,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'agentRatings'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "agentRatings" }]);
@@ -1991,8 +1991,8 @@ describe("schema migrations", () => {
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
const tables = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'mission_events'").all() as Array<{ name: string }>;
expect(tables).toEqual([{ name: "mission_events" }]);
@@ -2096,8 +2096,8 @@ describe("schema migrations", () => {
db.init();
// Verify version bumped to 29
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
// Verify new columns exist and existing data is intact
const cols = db.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
@@ -2316,8 +2316,8 @@ describe("schema migrations", () => {
localDb.init();
expect(localDb.getSchemaVersion()).toBe(114);
expect(localDb.getSchemaVersion()).toBe(114);
expect(localDb.getSchemaVersion()).toBe(115);
expect(localDb.getSchemaVersion()).toBe(115);
const columns = localDb.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
expect(columns.map((column) => column.name)).toContain("tokenUsageCacheWriteTokens");
@@ -2628,8 +2628,8 @@ describe("createDatabase factory", () => {
const db = createDatabase(fusionDir);
db.init();
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getSchemaVersion()).toBe(115);
expect(db.getLastModified()).toBeGreaterThan(0);
db.close();
@@ -2783,8 +2783,8 @@ describe("migration v77 task token budget columns", () => {
migrated = new Database(fusion);
migrated.init();
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(115);
expect(migrated.getSchemaVersion()).toBe(115);
const rows = migrated.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>;
const names = new Set(rows.map((row) => row.name));
expect(names.has("tokenBudgetSoftAlertedAt")).toBe(true);
@@ -2815,8 +2815,8 @@ describe("migration v106 adds tasks.transitionPending (FN-1417)", () => {
const fresh = new Database(fusion);
try {
fresh.init();
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(115);
expect(fresh.getSchemaVersion()).toBe(115);
const names = new Set(
(fresh.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>).map((r) => r.name),
);
@@ -2844,8 +2844,8 @@ describe("migration v106 adds tasks.transitionPending (FN-1417)", () => {
migrated = new Database(fusion);
migrated.init();
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(115);
expect(migrated.getSchemaVersion()).toBe(115);
const names = new Set(
(migrated.prepare("PRAGMA table_info(tasks)").all() as Array<{ name: string }>).map((r) => r.name),
);
@@ -2871,8 +2871,8 @@ describe("migration v107 adds workflow_run_branches + index (FN-1417)", () => {
const fresh = new Database(fusion);
try {
fresh.init();
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(115);
expect(fresh.getSchemaVersion()).toBe(115);
const table = fresh
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'workflow_run_branches'")
.get() as { name: string } | undefined;
@@ -2906,8 +2906,8 @@ describe("migration v107 adds workflow_run_branches + index (FN-1417)", () => {
migrated = new Database(fusion);
migrated.init();
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(115);
expect(migrated.getSchemaVersion()).toBe(115);
const table = migrated
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name = 'workflow_run_branches'")
.get() as { name: string } | undefined;
@@ -2948,8 +2948,8 @@ describe("migration v67 drops orphan project auth tables", () => {
migrated = new Database(fusion);
migrated.init();
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(114);
expect(migrated.getSchemaVersion()).toBe(115);
expect(migrated.getSchemaVersion()).toBe(115);
const tables = migrated
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name LIKE 'project_auth_%'")
.all() as Array<{ name: string }>;
@@ -2976,8 +2976,8 @@ describe("migration v67 drops orphan project auth tables", () => {
try {
fresh.init();
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(114);
expect(fresh.getSchemaVersion()).toBe(115);
expect(fresh.getSchemaVersion()).toBe(115);
const tables = fresh
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name LIKE 'project_auth_%'")
.all() as Array<{ name: string }>;

2
packages/core/src/__tests__/goals-schema.test.ts
View File

@@ -91,6 +91,6 @@ describe("goals schema", () => {
});
it("reports schema version 101", () => {
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
});
});

10
packages/core/src/__tests__/insight-store.test.ts
View File

@@ -1000,7 +1000,7 @@ describe("Migration: pre-33 DB upgrade", () => {
// Step 1: Create a fresh database at v33 (runs all migrations up to 33)
const db1 = createDatabase(legacyDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(114);
expect(db1.getSchemaVersion()).toBe(115);
db1.close();
// Step 2: Manually downgrade to version 32 and drop insight tables
@@ -1035,7 +1035,7 @@ describe("Migration: pre-33 DB upgrade", () => {
expect(tableNamesBefore).not.toContain("project_insight_runs");
// Now run init — this triggers the v32→v33 migration
db3.init();
expect(db3.getSchemaVersion()).toBe(114);
expect(db3.getSchemaVersion()).toBe(115);
// Step 4: Verify insight tables exist after migration
const tablesAfter = db3.prepare(
@@ -1066,12 +1066,12 @@ describe("Migration: pre-33 DB upgrade", () => {
try {
const db1 = createDatabase(testDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(114);
expect(db1.getSchemaVersion()).toBe(115);
db1.close();
const db2 = createDatabase(testDir);
expect(() => db2.init()).not.toThrow();
expect(db2.getSchemaVersion()).toBe(114);
expect(db2.getSchemaVersion()).toBe(115);
db2.close();
} finally {
rmSync(testDir, { recursive: true, force: true });
@@ -1085,7 +1085,7 @@ describe("Migration: pre-33 DB upgrade", () => {
// Step 1: Create a fresh DB and run migrations
const db1 = createDatabase(compatDir);
db1.init();
expect(db1.getSchemaVersion()).toBe(114);
expect(db1.getSchemaVersion()).toBe(115);
// Step 2: Strip lifecycle and cancelledAt columns by recreating the
// table without them. This simulates a DB that was created before the

2
packages/core/src/__tests__/merge-request-record.test.ts
View File

@@ -38,7 +38,7 @@ describe("TaskStore merge request record + completion handoff marker", () => {
.all() as Array<{ name: string }>;
expect(tableRows).toEqual([{ name: "completion_handoff_markers" }, { name: "merge_requests" }]);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
});
it("upserts merge request records", async () => {

2
packages/core/src/__tests__/run-audit.test.ts
View File

@@ -584,7 +584,7 @@ describe("Run Audit", () => {
});
it("schema version is bumped to 40", () => {
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
});
});
});

2
packages/core/src/__tests__/store-merge-queue.test.ts
View File

@@ -60,7 +60,7 @@ describe("TaskStore merge queue", () => {
expect.arrayContaining(["idx_mergeQueue_lease_ready", "idx_mergeQueue_leaseExpiresAt"]),
);
expect(store.getDatabase().getSchemaVersion()).toBe(114);
expect(store.getDatabase().getSchemaVersion()).toBe(115);
});
it("migrates a legacy v88 database and preserves task rows", async () => {

2
packages/core/src/__tests__/task-documents.test.ts
View File

@@ -51,7 +51,7 @@ describe("TaskStore task documents", () => {
expect(tableNames.has("task_documents")).toBe(true);
expect(tableNames.has("task_document_revisions")).toBe(true);
expect(db.getSchemaVersion()).toBe(114);
expect(db.getSchemaVersion()).toBe(115);
const index = db
.prepare(