feat(FN-4488): complete Step 4 — shared policy editor

Fusion-Task-Id: FN-4488
Fusion-Task-Lineage: 3fc1ac43-490f-43f2-a27e-4fdceb64d9c4
This commit is contained in:
Fusion
2026-05-14 12:53:22 -07:00
committed by gsxdsm
parent 9a7736a81f
commit 96773cbb0d
3 changed files with 230 additions and 0 deletions

View File

@@ -0,0 +1,46 @@
.agent-policy-editor {
padding: var(--space-lg);
border: 1px solid var(--border);
border-radius: var(--radius-lg);
display: flex;
flex-direction: column;
gap: var(--space-md);
}
.agent-policy-table {
display: flex;
flex-direction: column;
gap: var(--space-sm);
}
.agent-policy-row {
display: grid;
grid-template-columns: 1fr 220px;
gap: var(--space-md);
padding: var(--space-sm);
border: 1px solid var(--border);
border-radius: var(--radius-md);
background: var(--surface);
}
.agent-policy-cell {
display: flex;
flex-direction: column;
gap: var(--space-xs);
}
.agent-policy-description {
color: var(--text-muted);
font-size: 0.75rem;
}
.agent-policy-inherit-note {
color: var(--text-dim);
font-size: 0.75rem;
}
@media (max-width: 768px) {
.agent-policy-row {
grid-template-columns: 1fr;
}
}

View File

@@ -0,0 +1,127 @@
import "./AgentPermissionPolicyEditor.css";
import {
AGENT_PERMISSION_POLICY_ACTION_CATEGORIES,
normalizeAgentPermissionPolicyFromPreset,
type AgentPermissionPolicy,
type AgentPermissionPolicyDisposition,
type AgentPermissionPolicyRules,
} from "@fusion/core";
type Mode = "project-default" | "agent-override";
interface Props {
value: AgentPermissionPolicy | undefined;
projectDefault?: Partial<AgentPermissionPolicyRules>;
mode: Mode;
onChange(next: AgentPermissionPolicy | undefined): void;
disabled?: boolean;
}
const DISPOSITIONS: AgentPermissionPolicyDisposition[] = ["allow", "require-approval", "block"];
const CATEGORY_LABELS: Record<string, { label: string; description: string }> = {
git_write: { label: "Git writes", description: "Commits, branch updates, and merge-affecting git changes." },
file_write_delete: { label: "File writes/deletes", description: "Create, edit, or remove files in the workspace." },
command_execution: { label: "Command execution", description: "Runs shell commands and scripts." },
network_api: { label: "Network/API", description: "Outbound network or API access." },
task_agent_mutation: { label: "Task/agent mutation", description: "Task state changes, delegation, or agent lifecycle actions." },
};
function buildAllowRules(): AgentPermissionPolicyRules {
return {
git_write: "allow",
file_write_delete: "allow",
command_execution: "allow",
network_api: "allow",
task_agent_mutation: "allow",
};
}
function getPresetRules(presetId: AgentPermissionPolicy["presetId"]): AgentPermissionPolicyRules {
return normalizeAgentPermissionPolicyFromPreset(presetId).rules;
}
export function AgentPermissionPolicyEditor({ value, projectDefault, mode, onChange, disabled = false }: Props) {
const currentPreset = mode === "agent-override" && !value ? "inherit" : (value?.presetId ?? "unrestricted");
const rules = value?.rules ?? buildAllowRules();
const setPreset = (preset: string) => {
if (mode === "agent-override" && preset === "inherit") {
onChange(undefined);
return;
}
if (preset === "custom") {
onChange({ presetId: "custom", rules: { ...rules } });
return;
}
onChange({ presetId: preset as AgentPermissionPolicy["presetId"], rules: getPresetRules(preset as AgentPermissionPolicy["presetId"]) });
};
const setRule = (category: keyof AgentPermissionPolicyRules, next: string) => {
if (mode === "agent-override" && next === "inherit") {
if (!value) return;
const nextRules = { ...value.rules };
nextRules[category] = projectDefault?.[category] ?? "allow";
onChange({ presetId: "custom", rules: nextRules });
return;
}
const nextRules = { ...rules, [category]: next as AgentPermissionPolicyDisposition };
onChange({ presetId: "custom", rules: nextRules });
};
return (
<div className="agent-policy-editor card">
<div className="form-group">
<label htmlFor="agent-policy-preset">Preset</label>
<select
id="agent-policy-preset"
className="select"
value={currentPreset}
onChange={(event) => setPreset(event.target.value)}
disabled={disabled}
>
{mode === "agent-override" ? <option value="inherit">Inherit project default</option> : null}
<option value="unrestricted">Unrestricted</option>
<option value="approval-required">Approval Required</option>
<option value="locked-down">Locked Down</option>
<option value="custom">Custom</option>
</select>
</div>
<div className="agent-policy-table" role="table" aria-label="Permission policy categories">
{AGENT_PERMISSION_POLICY_ACTION_CATEGORIES.map((category) => {
const meta = CATEGORY_LABELS[category] ?? { label: category, description: "" };
const inherited = projectDefault?.[category] ?? "allow";
const effective = rules[category] ?? "allow";
const rowValue = mode === "agent-override" && !value ? "inherit" : effective;
return (
<div key={category} className="agent-policy-row" role="row">
<div className="agent-policy-cell">
<strong>{meta.label}</strong>
<div className="agent-policy-description">{meta.description}</div>
</div>
<div className="agent-policy-cell">
<select
className="select"
value={rowValue}
onChange={(event) => setRule(category, event.target.value)}
disabled={disabled}
>
{mode === "agent-override" ? <option value="inherit">Inherit</option> : null}
{DISPOSITIONS.map((disposition) => (
<option key={disposition} value={disposition}>
{disposition === "require-approval" ? "Require approval" : disposition[0]?.toUpperCase() + disposition.slice(1)}
</option>
))}
</select>
{mode === "agent-override" && rowValue === "inherit" ? (
<div className="agent-policy-inherit-note">from project default: {inherited === "require-approval" ? "Require approval" : inherited}</div>
) : null}
</div>
</div>
);
})}
</div>
</div>
);
}

View File

@@ -0,0 +1,57 @@
import { describe, it, expect, vi } from "vitest";
import { fireEvent, render, screen } from "@testing-library/react";
import { AgentPermissionPolicyEditor } from "../AgentPermissionPolicyEditor";
import type { AgentPermissionPolicy } from "@fusion/core";
describe("AgentPermissionPolicyEditor", () => {
it("preset dropdown switches all rules", () => {
const onChange = vi.fn();
render(
<AgentPermissionPolicyEditor
mode="project-default"
value={{ presetId: "unrestricted", rules: {
git_write: "allow",
file_write_delete: "allow",
command_execution: "allow",
network_api: "allow",
task_agent_mutation: "allow",
} }}
onChange={onChange}
/>,
);
fireEvent.change(screen.getByLabelText("Preset"), { target: { value: "locked-down" } });
const payload = onChange.mock.calls.at(-1)?.[0] as AgentPermissionPolicy;
expect(payload.presetId).toBe("locked-down");
expect(payload.rules.git_write).toBe("block");
});
it("changing one category flips to custom", () => {
const onChange = vi.fn();
render(
<AgentPermissionPolicyEditor
mode="project-default"
value={undefined}
onChange={onChange}
/>,
);
const selects = screen.getAllByRole("combobox");
fireEvent.change(selects[1], { target: { value: "require-approval" } });
const payload = onChange.mock.calls.at(-1)?.[0] as AgentPermissionPolicy;
expect(payload.presetId).toBe("custom");
});
it("shows inherit annotation from project default", () => {
render(
<AgentPermissionPolicyEditor
mode="agent-override"
value={undefined}
projectDefault={{ git_write: "require-approval" }}
onChange={() => {}}
/>,
);
expect(screen.getByText("from project default: Require approval")).toBeInTheDocument();
});
});