Address PR review feedback (#1763)
- Exclude the 4 SettingsModal split files from the app backfill project (greptile P1): the split dropped the bare "SettingsModal" entry from qualityAppComponentTests, which had excluded the curated file from backfill; without spreading qualityAppSettingsOnlyTests into backfillAppExclude the split files matched the backfill `app/**` glob and ran in two projects, doubling their wall-time. Now collected by exactly one project (dashboard-app-quality-settings). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -332,6 +332,16 @@ const qualityApiTests = [
|
||||
// backfill automatically; it can never silently fall through again.
|
||||
const backfillAppExclude = [
|
||||
...qualityAppTests,
|
||||
/*
|
||||
FNXC:DashboardTests 2026-06-25-10:40:
|
||||
The SettingsModal split removed the bare "SettingsModal" entry from
|
||||
qualityAppComponentTests, which is what previously excluded the curated
|
||||
settings file from the broad app backfill (via qualityAppTests). The 4 split
|
||||
files live only in qualityAppSettingsOnlyTests, so spread them here too —
|
||||
otherwise the backfill `app/**` glob re-collects them and they run in BOTH the
|
||||
settings project and backfill, doubling their wall-time instead of halving it.
|
||||
*/
|
||||
...qualityAppSettingsOnlyTests,
|
||||
...skipListDashboardGlobs.filter((file) => file.startsWith("app/")),
|
||||
"app/__tests__/build-output.test.ts",
|
||||
];
|
||||
|
||||
Reference in New Issue
Block a user