root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: remove dead post-await sleeps in skills install tests

Browse Source 
runSkillsInstall already awaits the spawned child exit event, so the
fixed 100ms post-await sleeps were redundant wall-clock time (FN-5048).
Removes ~400ms of dead waits; assertions unchanged, 22 tests still pass.
This commit is contained in:
gsxdsm
2026-06-27 17:03:55 -07:00
parent 6f46fa17dd
commit aeafee75e5
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/cli/src/commands/__tests__/skills.test.ts
View File

@@ -390,12 +390,16 @@ describe("runSkillsInstall", () => {
);
});
/*
FNXC:CliSkills 2026-06-27-17:10:
runSkillsInstall awaits the spawned child's "exit" event before resolving (skills.ts:193), so
`await runSkillsInstall(...)` already completes after the mock fires exit. The prior fixed 100ms
post-await sleeps were dead wall-clock time (FN-5048: no fixed sleeps where an await already gates
completion); removed without weakening any assertion.
*/
it("spawns npx with correct args for install all skills", async () => {
await runSkillsInstall(["firebase/agent-skills"]);
// Wait for async spawn to complete
await new Promise((r) => setTimeout(r, 100));
expect(mocks.spawn).toHaveBeenCalledWith(
"npx",
["skills", "add", "firebase/agent-skills", "-y", "-a", "pi"],
@@ -406,9 +410,6 @@ describe("runSkillsInstall", () => {
it("spawns npx with correct args for specific skill", async () => {
await runSkillsInstall(["firebase/agent-skills"], { skill: "firebase-basics" });
// Wait for async spawn to complete
await new Promise((r) => setTimeout(r, 100));
expect(mocks.spawn).toHaveBeenCalledWith(
"npx",
["skills", "add", "firebase/agent-skills", "--skill", "firebase-basics", "-y", "-a", "pi"],
@@ -419,9 +420,6 @@ describe("runSkillsInstall", () => {
it("prints success message on successful install", async () => {
await runSkillsInstall(["firebase/agent-skills"]);
// Wait for async spawn to complete
await new Promise((r) => setTimeout(r, 100));
expect(consoleLogSpy).toHaveBeenCalledWith(
expect.stringContaining("Installed skill from firebase/agent-skills"),
);
@@ -441,9 +439,6 @@ describe("runSkillsInstall", () => {
await runSkillsInstall(["firebase/agent-skills"]);
// Wait for async spawn to complete
await new Promise((r) => setTimeout(r, 100));
expect(consoleErrorSpy).toHaveBeenCalledWith(
expect.stringContaining("Failed to install skill"),
);