root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(FN-798): scope engine vitest fork pool

Browse Source 
Fusion-Task-Id: FN-798
This commit is contained in:
Phil Larson
2026-06-25 11:16:16 -07:00
parent fa8e9fa817
commit b62b4b0e30
2 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/engine/vitest.config.ts
View File

@@ -19,11 +19,9 @@ export default defineConfig({
resolve(__dirname, "../core/src/__test-utils__/vitest-setup.ts"),
],
globalSetup: [resolve(__dirname, "../core/src/__test-utils__/vitest-teardown.ts")],
// Node 24.15.0 on macOS aborts in libuv kqueue when Vitest's
// worker-thread pool closes unmanaged file descriptors during this gate.
// Fork workers preserve real failure semantics while avoiding the raw
// SIGABRT/warning flood; keep worker counts bounded below.
pool: "forks",
// Keep the broad engine lanes on worker threads; engine-core overrides this
// below because only the curated merge gate has hit the Node/macOS abort.
pool: "threads",
maxWorkers,
minWorkers: 1,
fileParallelism: true,
@@ -56,6 +54,11 @@ export default defineConfig({
extends: true,
test: {
name: "engine-core",
/*
FNXC:EngineTests 2026-06-25-11:11:
The curated engine-core merge gate hits a Node 24.15.0/macOS libuv kqueue SIGABRT when Vitest thread workers close unmanaged file descriptors. Scope fork workers to this gate so the broad default engine suite keeps its explicit worker-thread behavior.
*/
pool: "forks",
// The curated merge-gate suite (see docs/testing.md "Merge gate").
// Membership is an explicit allow-list, NOT a glob: tests earn their
// way in with evidence of value, and a flaky gate test is evicted by

25
scripts/__tests__/engine-vitest-gate-policy.test.mjs
View File

@@ -16,13 +16,32 @@ function readJson(relativePath) {
return JSON.parse(read(relativePath));
}
test("engine-core gate keeps a Node 24/macOS-safe Vitest pool without hiding warnings", () => {
test("engine-core gate keeps a Node 24/macOS-safe Vitest pool without changing broad engine lanes", () => {
const config = read("packages/engine/vitest.config.ts");
const projectsIndex = config.indexOf("projects:");
const rootTestConfig = projectsIndex === -1 ? config : config.slice(0, projectsIndex);
const engineCoreBlock = config.match(/name:\s*"engine-core"[\s\S]*?include:\s*\[/)?.[0] ?? "";
const engineDefaultBlock = config.match(/name:\s*"engine-default"[\s\S]*?include:\s*\[/)?.[0] ?? "";
assert.match(
config,
engineCoreBlock,
/pool:\s*"forks"/,
"engine Vitest must use fork workers; thread workers abort with Node 24/macOS libuv kqueue",
"engine-core must use fork workers; thread workers abort with Node 24/macOS libuv kqueue",
);
assert.doesNotMatch(
rootTestConfig,
/pool:\s*"forks"/,
"fork workers must not be configured at root scope because that slows the broad engine-default lane",
);
assert.match(
rootTestConfig,
/pool:\s*"threads"/,
"root engine config must explicitly keep broad lanes on threads because Vitest 4 defaults to forks",
);
assert.doesNotMatch(
engineDefaultBlock,
/pool:\s*"forks"/,
"engine-default must keep inheriting Vitest's default thread pool for broad src/**/*.test.ts runs",
);
assert.doesNotMatch(
config,