feat(FN-4684): complete Step 2 — add worktree backend primitives

Fusion-Task-Id: FN-4684
Fusion-Task-Lineage: 142e512b-8189-4029-9df4-4bd40b69ed2a
This commit is contained in:
Fusion (runfusion.ai)
2026-05-15 16:28:15 -07:00
committed by gsxdsm
parent a27614fa85
commit c1abebc98d
2 changed files with 371 additions and 0 deletions

View File

@@ -0,0 +1,142 @@
import { describe, it, expect, vi, beforeEach } from "vitest";
import {
NativeWorktreeBackend,
WorktrunkOperationError,
WorktrunkWorktreeBackend,
resolveWorktreeBackend,
} from "../worktree-backend.js";
const { execMock } = vi.hoisted(() => {
const mock = vi.fn();
(mock as any)[Symbol.for("nodejs.util.promisify.custom")] = mock;
return { execMock: mock };
});
vi.mock("node:child_process", () => ({ exec: execMock }));
vi.mock("../branch-conflicts.js", () => ({
inspectBranchConflict: vi.fn().mockResolvedValue({ kind: "stale" }),
}));
beforeEach(() => {
execMock.mockReset();
});
describe("NativeWorktreeBackend", () => {
it("creates worktree with expected command", async () => {
execMock.mockResolvedValue({ stdout: "", stderr: "" });
const backend = new NativeWorktreeBackend();
const result = await backend.create({
rootDir: "/repo",
worktreePath: "/repo/.worktrees/fn-1",
branch: "fusion/fn-1",
startPoint: "main",
taskId: "FN-1",
});
expect(result).toEqual({ path: "/repo/.worktrees/fn-1", branch: "fusion/fn-1" });
expect(execMock).toHaveBeenCalledWith(
'git worktree add -b "fusion/fn-1" "/repo/.worktrees/fn-1" "main"',
expect.objectContaining({ cwd: "/repo", timeout: 120000, maxBuffer: 10485760 }),
);
});
it("removes worktree", async () => {
execMock.mockResolvedValue({ stdout: "", stderr: "" });
const backend = new NativeWorktreeBackend();
await backend.remove({ rootDir: "/repo", worktreePath: "/repo/.worktrees/fn-1", taskId: "FN-1" });
expect(execMock).toHaveBeenCalledWith(
'git worktree remove --force "/repo/.worktrees/fn-1"',
expect.objectContaining({ cwd: "/repo" }),
);
});
it("prunes worktrees", async () => {
execMock.mockResolvedValue({ stdout: "", stderr: "" });
const backend = new NativeWorktreeBackend();
await backend.prune({ rootDir: "/repo", taskId: "FN-1" });
expect(execMock).toHaveBeenCalledWith(
"git worktree prune",
expect.objectContaining({ cwd: "/repo" }),
);
});
it("implements required methods", () => {
const backend = new NativeWorktreeBackend();
expect(backend.kind).toBe("native");
expect(typeof backend.create).toBe("function");
expect(typeof backend.remove).toBe("function");
expect(typeof backend.sync).toBe("function");
expect(typeof backend.prune).toBe("function");
});
});
describe("WorktrunkWorktreeBackend", () => {
it("throws typed error when binary is missing", async () => {
const backend = new WorktrunkWorktreeBackend({ binaryPath: null });
await expect(
backend.create({
rootDir: "/repo",
worktreePath: "/repo/.worktrees/fn-1",
branch: "fusion/fn-1",
taskId: "FN-1",
}),
).rejects.toMatchObject({
name: "WorktrunkOperationError",
code: "worktrunk_binary_missing",
operation: "create",
exitCode: null,
});
});
it("maps non-zero exit to worktrunk_operation_failed and preserves stderr", async () => {
execMock.mockRejectedValue({ stderr: "bad", code: 17 });
const backend = new WorktrunkWorktreeBackend({ binaryPath: "worktrunk" });
await expect(
backend.prune({ rootDir: "/repo", taskId: "FN-1" }),
).rejects.toEqual(
expect.objectContaining<Partial<WorktrunkOperationError>>({
code: "worktrunk_operation_failed",
stderr: "bad",
exitCode: 17,
operation: "prune",
}),
);
});
it("passes timeout and maxBuffer to exec", async () => {
execMock.mockResolvedValue({ stdout: "", stderr: "" });
const backend = new WorktrunkWorktreeBackend({ binaryPath: "worktrunk" });
await backend.sync({
rootDir: "/repo",
worktreePath: "/repo/.worktrees/fn-1",
branch: "fusion/fn-1",
taskId: "FN-1",
});
expect(execMock).toHaveBeenCalledWith(
'"worktrunk" --help',
expect.objectContaining({ cwd: "/repo/.worktrees/fn-1", timeout: 120000, maxBuffer: 10485760 }),
);
});
});
describe("resolveWorktreeBackend", () => {
it("defaults to native when worktrunk undefined", () => {
expect(resolveWorktreeBackend({}).kind).toBe("native");
});
it("uses native when enabled=false", () => {
expect(resolveWorktreeBackend({ worktrunk: { enabled: false } as any }).kind).toBe("native");
});
it("uses worktrunk when enabled=true and binaryPath present", () => {
expect(resolveWorktreeBackend({ worktrunk: { enabled: true, binaryPath: "worktrunk" } as any }).kind).toBe("worktrunk");
});
it("uses worktrunk when enabled=true and binaryPath missing", () => {
expect(resolveWorktreeBackend({ worktrunk: { enabled: true } as any }).kind).toBe("worktrunk");
});
});

View File

@@ -0,0 +1,229 @@
import { exec } from "node:child_process";
import { promisify } from "node:util";
import type { Settings } from "@fusion/core";
import { inspectBranchConflict } from "./branch-conflicts.js";
import { formatError, worktreePoolLog } from "./logger.js";
const execAsync = promisify(exec);
const GIT_TIMEOUT_MS = 120_000;
const GIT_MAX_BUFFER = 10 * 1024 * 1024;
export type WorktreeBackendKind = "native" | "worktrunk";
type LoggerLike = { log?: (message: string) => void; warn?: (message: string) => void };
export interface WorktreeCreateInput {
rootDir: string;
worktreePath: string;
branch: string;
startPoint?: string;
taskId: string;
allowSiblingBranchRename?: boolean;
}
export interface WorktreeRemoveInput {
rootDir: string;
worktreePath: string;
taskId: string;
}
export interface WorktreeSyncInput {
rootDir: string;
worktreePath: string;
branch: string;
startPoint?: string;
taskId: string;
}
export interface WorktreePruneInput {
rootDir: string;
taskId: string;
}
export interface WorktreeBackend {
kind: WorktreeBackendKind;
create(input: WorktreeCreateInput): Promise<{ path: string; branch: string }>;
remove(input: WorktreeRemoveInput): Promise<void>;
sync(input: WorktreeSyncInput): Promise<void>;
prune(input: WorktreePruneInput): Promise<void>;
}
export type WorktrunkOperation = "create" | "remove" | "sync" | "prune";
export type WorktrunkOperationErrorCode = "worktrunk_operation_failed" | "worktrunk_binary_missing";
export class WorktrunkOperationError extends Error {
readonly name = "WorktrunkOperationError";
readonly operation: WorktrunkOperation;
readonly stderr: string;
readonly exitCode: number | null;
readonly code: WorktrunkOperationErrorCode;
constructor(input: {
operation: WorktrunkOperation;
stderr: string;
exitCode: number | null;
code: WorktrunkOperationErrorCode;
}) {
super(`worktrunk ${input.operation} failed: ${input.stderr || "unknown error"}`);
this.operation = input.operation;
this.stderr = input.stderr;
this.exitCode = input.exitCode;
this.code = input.code;
}
}
function quoteShellArg(value: string): string {
return JSON.stringify(value);
}
async function runCommand(command: string, cwd: string): Promise<{ stdout: string; stderr: string }> {
const result = await execAsync(command, {
cwd,
encoding: "utf-8",
timeout: GIT_TIMEOUT_MS,
maxBuffer: GIT_MAX_BUFFER,
});
return {
stdout: result.stdout ?? "",
stderr: result.stderr ?? "",
};
}
export class NativeWorktreeBackend implements WorktreeBackend {
readonly kind: WorktreeBackendKind = "native";
constructor(private readonly deps: { logger?: LoggerLike } = {}) {}
async create(input: WorktreeCreateInput): Promise<{ path: string; branch: string }> {
const startArg = input.startPoint ? ` ${quoteShellArg(input.startPoint)}` : "";
const create = async (branchName: string): Promise<void> => {
await runCommand(
`git worktree add -b ${quoteShellArg(branchName)} ${quoteShellArg(input.worktreePath)}${startArg}`,
input.rootDir,
);
};
try {
await create(input.branch);
return { path: input.worktreePath, branch: input.branch };
} catch (error) {
if (!input.allowSiblingBranchRename) {
throw error;
}
for (let suffix = 2; suffix <= 50; suffix += 1) {
const candidateBranch = `${input.branch}-${suffix}`;
try {
await create(candidateBranch);
return { path: input.worktreePath, branch: candidateBranch };
} catch {
// try next suffix
}
}
let inspection: Awaited<ReturnType<typeof inspectBranchConflict>> | null = null;
try {
inspection = await inspectBranchConflict({
repoDir: input.rootDir,
branchName: input.branch,
conflictingWorktreePath: input.worktreePath,
requestingTaskId: input.taskId,
startPoint: input.startPoint,
});
} catch (inspectError) {
this.deps.logger?.warn?.(
`[worktree-backend] ${input.taskId}: failed to inspect branch conflict: ${formatError(inspectError).detail}`,
);
}
if (inspection?.kind === "live-foreign") {
throw inspection.error;
}
throw error;
}
}
async remove(input: WorktreeRemoveInput): Promise<void> {
await runCommand(`git worktree remove --force ${quoteShellArg(input.worktreePath)}`, input.rootDir);
}
async sync(input: WorktreeSyncInput): Promise<void> {
await runCommand("git fetch --all --prune", input.worktreePath);
const target = input.startPoint ?? "main";
await runCommand(`git rebase ${quoteShellArg(target)}`, input.worktreePath);
}
async prune(input: WorktreePruneInput): Promise<void> {
await runCommand("git worktree prune", input.rootDir);
}
}
export class WorktrunkWorktreeBackend implements WorktreeBackend {
readonly kind: WorktreeBackendKind = "worktrunk";
constructor(private readonly deps: { binaryPath: string | null; logger?: LoggerLike }) {}
private async runOperation(operation: WorktrunkOperation, cwd: string): Promise<void> {
if (!this.deps.binaryPath || !this.deps.binaryPath.trim()) {
throw new WorktrunkOperationError({
operation,
code: "worktrunk_binary_missing",
stderr: "worktrunk binary not configured",
exitCode: null,
});
}
try {
// FN-4623: replace placeholder with real worktrunk subcommand.
await execAsync(`${quoteShellArg(this.deps.binaryPath)} --help`, {
cwd,
encoding: "utf-8",
timeout: GIT_TIMEOUT_MS,
maxBuffer: GIT_MAX_BUFFER,
});
} catch (error) {
const err = error as { stderr?: string; code?: number };
const stderr = typeof err?.stderr === "string" ? err.stderr : String(err ?? "");
this.deps.logger?.warn?.(
`[worktree-backend] worktrunk ${operation} failed: ${stderr || formatError(error).detail}`,
);
throw new WorktrunkOperationError({
operation,
code: "worktrunk_operation_failed",
stderr,
exitCode: typeof err?.code === "number" ? err.code : null,
});
}
}
async create(input: WorktreeCreateInput): Promise<{ path: string; branch: string }> {
await this.runOperation("create", input.rootDir);
return { path: input.worktreePath, branch: input.branch };
}
async remove(input: WorktreeRemoveInput): Promise<void> {
await this.runOperation("remove", input.rootDir);
}
async sync(input: WorktreeSyncInput): Promise<void> {
await this.runOperation("sync", input.worktreePath);
}
async prune(input: WorktreePruneInput): Promise<void> {
await this.runOperation("prune", input.rootDir);
}
}
export function resolveWorktreeBackend(
settings: Partial<Settings>,
deps: { logger?: LoggerLike } = {},
): WorktreeBackend {
if (settings.worktrunk?.enabled === true) {
return new WorktrunkWorktreeBackend({
binaryPath: settings.worktrunk.binaryPath ?? null,
logger: deps.logger,
});
}
return new NativeWorktreeBackend({ logger: deps.logger ?? worktreePoolLog });
}