root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(FN-WF): retire builtin:review-gated-coding via the registry deprecation list

Browse Source 
Adds it to `DEPRECATED_BUILTIN_WORKFLOW_IDS` — the registry's own retirement
mechanism, and the reason `isBuiltinWorkflowToggleEligible` and
`validateEnabledBuiltinWorkflowIds` exist. The workflow disappears from new
selection while `getBuiltinWorkflow` keeps resolving it, so any task that already
selected it still runs. Built-ins cannot be deleted, and deleting this one would
strand those tasks.

It is obsolete because builtin:coding-ideas-v2 supersedes it and because its own
success path could never complete: `code-review -> documentation-delivery` puts a
write-capable node after a passed review, which the graph refuses with
`workspace-review-seal-required`.
This commit is contained in:
Fusion Agent
2026-08-24 10:33:36 +00:00
parent 9e76393cfa
commit d061081b61
2 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.changeset/deprecate-review-gated-coding.md Normal file
View File

@@ -0,0 +1,7 @@
---
"@runfusion/fusion": patch
---
summary: Retire the Coding (review-gated) workflow, superseded by Coding (Ideas) V2.
category: internal
dev: Adds `builtin:review-gated-coding` to `DEPRECATED_BUILTIN_WORKFLOW_IDS`, the registry's official retirement mechanism: it disappears from new selection and from `toggleEligibleBuiltinWorkflowIds()` while `getBuiltinWorkflow` still resolves it, so tasks that already selected it keep working. It shipped with a success path that could never complete (`code-review -> documentation-delivery` places a write-capable node after a passed review, refused as `workspace-review-seal-required`).

10
packages/core/src/types.ts
View File

@@ -60,8 +60,18 @@ export type { IngestedCheckState, IngestedCheckStateValue, MergeablePrCheck } fr
* selection. FN-7970 and FN-7969 preserve direct resolution for pre-existing
* Brainstorming and Coding (Ideas) task selections while hiding them elsewhere.
*/
/*
FNXC:WorkflowDeprecation 2026-08-24-10:40:
builtin:review-gated-coding is retired in favour of builtin:coding-ideas-v2. It shipped with a
success path that could never complete: `code-review -> documentation-delivery` puts a write-capable
node after a passed review, which `execute-workflow-graph` refuses with
`workspace-review-seal-required`, and its plan node declared a seam `resolveSeamName` throws on.
Deprecated rather than deleted so any task that already selected it still resolves its definition;
it is simply no longer offered for new work.
*/
export const DEPRECATED_BUILTIN_WORKFLOW_IDS: ReadonlySet<string> = new Set([
"builtin:brainstorming",
"builtin:review-gated-coding",
]);