root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(dashboard): align modal and locale fixtures (#2460)

Browse Source 
## Summary
- query Task Detail modal assertions from the document after its
FloatingWindow portal migration
- sync secondary locale catalogs with the current English key structure

## Test plan
- `pnpm --filter @fusion/dashboard exec vitest run
app/components/__tests__/TaskDetailModal.attachments-and-tabs.test.tsx
--silent=passed-only --reporter=dot`
- `pnpm i18n:status`
- `pnpm --filter @fusion/dashboard build`

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Documentation**
* Added missing localization entries for workflow selection/help text,
action-based report targeting, agent tool output limit hints,
auto-update/restart messaging, and task refinement status labels across
Spanish, French, Korean, Simplified Chinese, and Traditional Chinese.

* **Tests**
* Updated task detail modal tests to query the correct rendered document
root so portal/modal content is asserted reliably.
* Minor test formatting adjustments to keep assertions consistent
without changing coverage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Phil Larson
2026-07-26 22:36:09 -07:00
committed by GitHub
parent 11887625f1
commit d19c82b33b
6 changed files with 87 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
packages/dashboard/app/components/__tests__/TaskDetailModal.attachments-and-tabs.test.tsx
View File

@@ -216,7 +216,8 @@ describe("TaskDetailModal", () => {
mockUpload.mockResolvedValueOnce(mockAttachment);
const addToast = vi.fn();
const { container } = render(
// FNXC:TaskDetailModalTests 2026-07-26-21:28: Query baseElement because FloatingWindow portals modal content into document.body, outside React Testing Library's local render container.
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask()}
onClose={noop}
@@ -358,7 +359,7 @@ describe("TaskDetailModal", () => {
});
it("renders in-review PR content only in the Pull Request tab body", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ column: "in-review", status: "creating-pr", dependencies: ["FN-001"] })}
onClose={noop}
@@ -392,7 +393,7 @@ describe("TaskDetailModal", () => {
});
it("activity list does not have nested scroll constraints", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
log: [
@@ -493,7 +494,7 @@ describe("TaskDetailModal", () => {
oversight gating, so pin plannerOversightLevel: "off" to keep the
three-label Activity-view assertion meaningful and honest (FN-7607).
*/
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent", plannerOversightLevel: "off" })}
taskDetailChatFirst
@@ -533,7 +534,7 @@ describe("TaskDetailModal", () => {
});
it("switches to Feed segment via Activity tab and shows activity feed", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
prompt: "# Hello\n\nContent",
@@ -563,7 +564,7 @@ describe("TaskDetailModal", () => {
});
it("Feed segment renders log entries correctly", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
log: [
@@ -601,7 +602,7 @@ describe("TaskDetailModal", () => {
it("Feed segment preserves legacy text/detail and duplicate entries", () => {
const duplicateEntry = { timestamp: "2026-01-01T00:02:00Z", action: "Repeated diagnostic", outcome: "same payload" };
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
log: [
@@ -629,7 +630,7 @@ describe("TaskDetailModal", () => {
});
it("Feed segment keeps action/outcome rendering intact", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
log: [
@@ -673,7 +674,7 @@ describe("TaskDetailModal", () => {
});
it("Feed segment shows empty state when no logs", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ log: [] })}
onClose={noop}
@@ -699,7 +700,7 @@ describe("TaskDetailModal", () => {
});
it("can switch between all tabs and Activity segments", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
prompt: "# Hello\n\nContent",
@@ -751,7 +752,7 @@ describe("TaskDetailModal", () => {
const { useAgentLogs } = await import("../../hooks/useAgentLogs");
const mockUseAgentLogs = vi.mocked(useAgentLogs);
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -819,7 +820,7 @@ describe("TaskDetailModal", () => {
});
it("switches to Comments tab", async () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -843,7 +844,7 @@ describe("TaskDetailModal", () => {
});
it("shows correct top-level tabs without Logs", async () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask()}
onClose={noop}
@@ -951,7 +952,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6370/FN-6517 expands and collapses Activity Live without leaving chrome hidden", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -994,7 +995,7 @@ describe("TaskDetailModal", () => {
});
it("FN-7325 keeps Activity expansion available and sticky across Live, Feed, and Raw Logs", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({
prompt: "# Hello\n\nContent",
@@ -1076,7 +1077,7 @@ describe("TaskDetailModal", () => {
it("FN-7320 removes branch group chrome only while Activity is expanded", () => {
const branchContext = { groupId: "BG-7320", source: "planning", assignmentMode: "shared" } as const;
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent", branchContext })}
taskDetailChatFirst
@@ -1108,7 +1109,7 @@ describe("TaskDetailModal", () => {
});
it("FN-7320 expands Activity for tasks without branch groups without rendering branch shells", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent", branchContext: undefined })}
taskDetailChatFirst
@@ -1131,7 +1132,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6517 keeps the title row visible when embedded chat expands", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailContent
task={makeTask({ prompt: "# Hello\n\nContent" })}
onMoveTask={noopMove}
@@ -1193,7 +1194,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6370 resets expanded Activity when entering edit mode", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ column: "triage", prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -1215,7 +1216,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6532 restores planner Chat first when Chat-first is enabled while preserving explicit Activity requests", () => {
const { container, rerender } = render(
const { baseElement: container, rerender } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
taskDetailChatFirst
@@ -1268,7 +1269,7 @@ describe("TaskDetailModal", () => {
const blocker = makeTask({ id: "FN-6574", title: "Definition task", prompt: "# Spec\n\nDefinition body unique text.", dependencies: ["FN-100"], githubTracking: { enabled: true } });
const dependency = makeTask({ id: "FN-100", title: "Dependency task" });
const dependent = makeTask({ id: "FN-200", title: "Dependent task", dependencies: ["FN-6574"] });
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={blocker}
tasks={[blocker, dependency, dependent]}
@@ -1294,7 +1295,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6347 applies chat modifiers only while the Activity tab is active", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
taskDetailChatFirst
@@ -1327,7 +1328,7 @@ describe("TaskDetailModal", () => {
});
it("FN-6347 removes the chat body modifier while editing", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ column: "triage", prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -1350,7 +1351,7 @@ describe("TaskDetailModal", () => {
describe("Raw Logs full-height layout", () => {
it("applies detail-body--agent-log class when Activity → Raw Logs segment is active", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -1383,7 +1384,7 @@ describe("TaskDetailModal", () => {
});
it("wraps AgentLogViewer in detail-section--agent-log class", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ prompt: "# Hello\n\nContent" })}
onClose={noop}
@@ -1407,7 +1408,7 @@ describe("TaskDetailModal", () => {
});
it("does not apply detail-body--agent-log when editing", () => {
const { container } = render(
const { baseElement: container } = render(
<TaskDetailModal
task={makeTask({ column: "triage", prompt: "# Hello\n\nContent" })}
onClose={noop}

15
packages/i18n/locales/es/app.json
View File

@@ -5994,7 +5994,12 @@
"reportDiscussionCategorySelect": "Selecciona una categoría de discusión",
"reportDiscussionCategoryUnavailable": "Las categorías de discusión no están disponibles para el repositorio configurado.",
"reportDiscussionCategoryEmpty": "No hay categorías de discusión disponibles para el repositorio configurado.",
"reportTargetByActionHelp": ""
"reportTargetByActionHelp": "",
"originWorkflowSelected": "",
"taskCreateWorkflow": "",
"taskCreateWorkflowHelp": "",
"refinementTaskWorkflow": "",
"refinementTaskWorkflowHelp": ""
},
"globalGeneral": {
"andShowsUpdateNoticesInTheCLIAnd": "",
@@ -6050,7 +6055,9 @@
"agentToolOutputLimit": "",
"agentToolOutputLimitHint": "",
"noLimitOnAgentToolOutput": "",
"noLimitOnAgentToolOutputHint": ""
"noLimitOnAgentToolOutputHint": "",
"autoUpdateAndRestart": "",
"autoUpdateAndRestartHelp": ""
},
"globalModels": {
"allow": "",
@@ -8538,7 +8545,9 @@
"awaitingApprovalPlanReviewReplanCapTitle": "",
"reviewBudgetExhausted": "",
"awaitingApprovalTitle": "",
"statusReplan": "Replanificar"
"statusReplan": "Replanificar",
"refinesOf": "",
"refinesOfTitle": ""
},
"terminal": {
"arrowKeysLabel": "",

15
packages/i18n/locales/fr/app.json
View File

@@ -5994,7 +5994,12 @@
"reportDiscussionCategorySelect": "Sélectionnez une catégorie de discussion",
"reportDiscussionCategoryUnavailable": "Les catégories de discussion ne sont pas disponibles pour le dépôt configuré.",
"reportDiscussionCategoryEmpty": "Aucune catégorie de discussion n’est disponible pour le dépôt configuré.",
"reportTargetByActionHelp": ""
"reportTargetByActionHelp": "",
"originWorkflowSelected": "",
"taskCreateWorkflow": "",
"taskCreateWorkflowHelp": "",
"refinementTaskWorkflow": "",
"refinementTaskWorkflowHelp": ""
},
"globalGeneral": {
"andShowsUpdateNoticesInTheCLIAnd": "",
@@ -6050,7 +6055,9 @@
"agentToolOutputLimit": "",
"agentToolOutputLimitHint": "",
"noLimitOnAgentToolOutput": "",
"noLimitOnAgentToolOutputHint": ""
"noLimitOnAgentToolOutputHint": "",
"autoUpdateAndRestart": "",
"autoUpdateAndRestartHelp": ""
},
"globalModels": {
"allow": "",
@@ -8538,7 +8545,9 @@
"awaitingApprovalPlanReviewReplanCapTitle": "",
"reviewBudgetExhausted": "",
"awaitingApprovalTitle": "",
"statusReplan": "Replanifier"
"statusReplan": "Replanifier",
"refinesOf": "",
"refinesOfTitle": ""
},
"terminal": {
"arrowKeysLabel": "",

15
packages/i18n/locales/ko/app.json
View File

@@ -5994,7 +5994,12 @@
"reportDiscussionCategorySelect": "토론 카테고리 선택",
"reportDiscussionCategoryUnavailable": "Discussion categories are unavailable for the configured repository.",
"reportDiscussionCategoryEmpty": "No Discussion categories are available for the configured repository.",
"reportTargetByActionHelp": ""
"reportTargetByActionHelp": "",
"originWorkflowSelected": "",
"taskCreateWorkflow": "",
"taskCreateWorkflowHelp": "",
"refinementTaskWorkflow": "",
"refinementTaskWorkflowHelp": ""
},
"globalGeneral": {
"andShowsUpdateNoticesInTheCLIAnd": "",
@@ -6050,7 +6055,9 @@
"agentToolOutputLimit": "",
"agentToolOutputLimitHint": "",
"noLimitOnAgentToolOutput": "",
"noLimitOnAgentToolOutputHint": ""
"noLimitOnAgentToolOutputHint": "",
"autoUpdateAndRestart": "",
"autoUpdateAndRestartHelp": ""
},
"globalModels": {
"allow": "",
@@ -8538,7 +8545,9 @@
"awaitingApprovalPlanReviewReplanCapTitle": "",
"reviewBudgetExhausted": "",
"awaitingApprovalTitle": "",
"statusReplan": "재계획"
"statusReplan": "재계획",
"refinesOf": "",
"refinesOfTitle": ""
},
"terminal": {
"arrowKeysLabel": "",

15
packages/i18n/locales/zh-CN/app.json
View File

@@ -5994,7 +5994,12 @@
"reportDiscussionCategorySelect": "选择讨论类别",
"reportDiscussionCategoryUnavailable": "Discussion categories are unavailable for the configured repository.",
"reportDiscussionCategoryEmpty": "No Discussion categories are available for the configured repository.",
"reportTargetByActionHelp": ""
"reportTargetByActionHelp": "",
"originWorkflowSelected": "",
"taskCreateWorkflow": "",
"taskCreateWorkflowHelp": "",
"refinementTaskWorkflow": "",
"refinementTaskWorkflowHelp": ""
},
"globalGeneral": {
"andShowsUpdateNoticesInTheCLIAnd": "",
@@ -6050,7 +6055,9 @@
"agentToolOutputLimit": "",
"agentToolOutputLimitHint": "",
"noLimitOnAgentToolOutput": "",
"noLimitOnAgentToolOutputHint": ""
"noLimitOnAgentToolOutputHint": "",
"autoUpdateAndRestart": "",
"autoUpdateAndRestartHelp": ""
},
"globalModels": {
"allow": "",
@@ -8538,7 +8545,9 @@
"awaitingApprovalPlanReviewReplanCapTitle": "",
"reviewBudgetExhausted": "",
"awaitingApprovalTitle": "",
"statusReplan": "重新规划"
"statusReplan": "重新规划",
"refinesOf": "",
"refinesOfTitle": ""
},
"terminal": {
"arrowKeysLabel": "",

15
packages/i18n/locales/zh-TW/app.json
View File

@@ -5994,7 +5994,12 @@
"reportDiscussionCategorySelect": "選擇討論分類",
"reportDiscussionCategoryUnavailable": "Discussion categories are unavailable for the configured repository.",
"reportDiscussionCategoryEmpty": "No Discussion categories are available for the configured repository.",
"reportTargetByActionHelp": ""
"reportTargetByActionHelp": "",
"originWorkflowSelected": "",
"taskCreateWorkflow": "",
"taskCreateWorkflowHelp": "",
"refinementTaskWorkflow": "",
"refinementTaskWorkflowHelp": ""
},
"globalGeneral": {
"andShowsUpdateNoticesInTheCLIAnd": "",
@@ -6050,7 +6055,9 @@
"agentToolOutputLimit": "",
"agentToolOutputLimitHint": "",
"noLimitOnAgentToolOutput": "",
"noLimitOnAgentToolOutputHint": ""
"noLimitOnAgentToolOutputHint": "",
"autoUpdateAndRestart": "",
"autoUpdateAndRestartHelp": ""
},
"globalModels": {
"allow": "",
@@ -8538,7 +8545,9 @@
"awaitingApprovalPlanReviewReplanCapTitle": "",
"reviewBudgetExhausted": "",
"awaitingApprovalTitle": "",
"statusReplan": "重新規劃"
"statusReplan": "重新規劃",
"refinesOf": "",
"refinesOfTitle": ""
},
"terminal": {
"arrowKeysLabel": "",