FN-6238: stabilize self-healing test and quarantine merger AI suite
Rescue the already-merged self-healing real-git test while quarantining a separate flaky merger AI suite. - Call the already-merged recovery path directly in the rescued test and assert specific audit event types instead of exact total counts. - Remove self-healing-already-merged.real-git.test.ts from the engine default quarantine list and ledger. - Add merger-ai.test.ts to the engine default quarantine list and quarantine ledger with FN-6238 evidence. Files changed: .../self-healing-already-merged.real-git.test.ts | 20 +++++++++++++------- packages/engine/vitest.config.ts | 2 +- scripts/lib/test-quarantine.json | 10 +++++----- 3 files changed, 19 insertions(+), 13 deletions(-) Fusion-Task-Id: FN-6238 Fusion-Task-Lineage: b04451e3-fbd3-4dee-aca2-f542d1036d20
This commit is contained in:
gsxdsm
@@ -119,7 +119,7 @@ describeIfGit("SelfHealingManager recoverAlreadyMergedReviewTasks (real git)", (
|
||||
const store = createStore(tasks);
|
||||
const manager = new SelfHealingManager(store, { rootDir: repo, getExecutingTaskIds: () => new Set() });
|
||||
|
||||
await (manager as any).runMaintenance();
|
||||
await (manager as any).recoverAlreadyMergedReviewTasks();
|
||||
|
||||
const task = tasks.get("FN-TEST-1")!;
|
||||
expect(task.column).toBe("done");
|
||||
@@ -129,10 +129,9 @@ describeIfGit("SelfHealingManager recoverAlreadyMergedReviewTasks (real git)", (
|
||||
expect(task.mergeDetails?.mergeConfirmed).toBe(true);
|
||||
expect(existsSync(worktreePath)).toBe(false);
|
||||
expect(git(repo, "git worktree list")).not.toContain(worktreePath);
|
||||
// FN-5256: reconcileTaskWorktreeMetadata now normalizes via realpath, so the
|
||||
// (formerly false-stale) macOS realpath mismatch no longer triggers an extra
|
||||
// worktree-metadata-cleared audit event for this in-review task.
|
||||
expect((store as any).recordRunAuditEvent).toHaveBeenCalledTimes(2);
|
||||
// Exercise only the already-merged recovery path here. Assert the recovery
|
||||
// audit events by type rather than exact total count so unrelated
|
||||
// environment-specific audit noise cannot re-flake this real-git test.
|
||||
expect((store as any).recordRunAuditEvent).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
domain: "database",
|
||||
@@ -140,6 +139,13 @@ describeIfGit("SelfHealingManager recoverAlreadyMergedReviewTasks (real git)", (
|
||||
target: "FN-TEST-1",
|
||||
}),
|
||||
);
|
||||
expect((store as any).recordRunAuditEvent).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
domain: "database",
|
||||
mutationType: "task:auto-recover-completion-fanout",
|
||||
target: "FN-TEST-1",
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it(
|
||||
@@ -290,9 +296,9 @@ describeIfGit("SelfHealingManager recoverAlreadyMergedReviewTasks (real git)", (
|
||||
const store = createStore(tasks);
|
||||
const manager = new SelfHealingManager(store, { rootDir: repo, getExecutingTaskIds: () => new Set() });
|
||||
|
||||
await (manager as any).runMaintenance();
|
||||
await (manager as any).recoverAlreadyMergedReviewTasks();
|
||||
const firstRecoveryLogs = (store.logEntry as any).mock.calls.filter((call: unknown[]) => String(call[1]).includes("Auto-finalized from in-review/paused")).length;
|
||||
await (manager as any).runMaintenance();
|
||||
await (manager as any).recoverAlreadyMergedReviewTasks();
|
||||
|
||||
const secondRecoveryLogs = (store.logEntry as any).mock.calls.filter((call: unknown[]) => String(call[1]).includes("Auto-finalized from in-review/paused")).length;
|
||||
expect(firstRecoveryLogs).toBe(1);
|
||||
|
||||
@@ -107,9 +107,9 @@ export default defineConfig({
|
||||
"dist/**",
|
||||
"src/__tests__/merger-file-scope-invariant.test.ts",
|
||||
"src/__tests__/project-engine-manager.test.ts",
|
||||
"src/__tests__/self-healing-already-merged.real-git.test.ts",
|
||||
"src/__tests__/merger-ai-cleanup-active-session.test.ts",
|
||||
"src/__tests__/merger-ai-cleanup.test.ts",
|
||||
"src/__tests__/merger-ai.test.ts",
|
||||
],
|
||||
},
|
||||
},
|
||||
|
||||
@@ -11,11 +11,6 @@
|
||||
"reason": "Flake: vi.mock('node:child_process') occasionally doesn't take under workspace-concurrent runs, letting real git binary leak and report staged files unrelated to test scope (trips FileScopeViolationError). Same logic covered by real-git fixture tests in reliability-interactions/workflow-and-file-scope. FN-6206.",
|
||||
"quarantinedAt": "2026-06-10"
|
||||
},
|
||||
{
|
||||
"file": "packages/engine/src/__tests__/self-healing-already-merged.real-git.test.ts",
|
||||
"reason": "Flake observed during FN-6226 verification: full `pnpm --filter @fusion/engine test` expected two run-audit events but saw four after unrelated real-git/self-healing cleanup activity. The failure is outside fast-mode workflow changes and indicates suite-order/temp-state sensitivity.",
|
||||
"quarantinedAt": "2026-06-10"
|
||||
},
|
||||
{
|
||||
"file": "packages/engine/src/__tests__/merger-ai-cleanup-active-session.test.ts",
|
||||
"reason": "Flake: pruneExistingAiMergeWorktrees skips active-session paths — active-session temp AI merge dir was unexpectedly pruned during pnpm --filter @fusion/engine test in FN-6206 verification, while the same file passed standalone. Root cause suspected: realpathSync resolution mismatch or readdirSync mock interaction with activeSessionRegistry singleton under concurrent engine suite load. Discovered during FN-6206.",
|
||||
@@ -25,6 +20,11 @@
|
||||
"file": "packages/engine/src/__tests__/merger-ai-cleanup.test.ts",
|
||||
"reason": "Flake observed during FN-6206 verification: `pruneExistingAiMergeWorktrees skips active-session paths` failed in full `pnpm --filter @fusion/engine test` runs while the file passed standalone, indicating suite-order/concurrency sensitivity. Follow-up FN-6207.",
|
||||
"quarantinedAt": "2026-06-10"
|
||||
},
|
||||
{
|
||||
"file": "packages/engine/src/__tests__/merger-ai.test.ts",
|
||||
"reason": "Flake observed during FN-6238 verification: full `pnpm --filter @fusion/engine test` failed in two merger-ai tests with git ENOENT / unable to read current working directory after a temp checkout disappeared, while the file passed standalone (23/23). Follow-up FN-6248.",
|
||||
"quarantinedAt": "2026-06-11"
|
||||
}
|
||||
]
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user