root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(engine): repair two stale test mocks broken by #1910

Browse Source 
restart.integration.test.ts's `../pi.js` factory replaces the module
wholesale but omits ModelFallbackExhaustedError, which triage.ts references
via `err instanceof ModelFallbackExhaustedError` — evaluating the guard threw
"No ModelFallbackExhaustedError export is defined on the mock". Added a plain
Error-subclass stub (no restart test enters the fallback-exhausted branch).

mission-validation-trigger-gap.test.ts's two recovery-path missionStore mocks
omit getMission, which #1910's mission-active gate now walks
(getSlice → getMilestone → getMission) inside resolveFeatureMission. The throw
was swallowed by processTaskOutcome's catch, aborting recovery before it
ensured assertions / started the validator run — surfacing as
ensureFeatureAssertionLinked called 0 times. Added getMission returning an
active mission.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
fusion-merge-train
2026-07-05 19:56:06 +02:00
parent 17c40070db
commit e5cae03f9a
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/engine/src/__tests__/reliability-interactions/mission-validation-trigger-gap.test.ts
View File

@@ -215,6 +215,11 @@ describe("FN-5715 reliability: mission validation trigger gap", () => {
completeValidatorRun: vi.fn(),
getSlice: vi.fn(() => ({ id: "SL-001", milestoneId: "MS-001", status: "active" })),
getMilestone: vi.fn(() => ({ id: "MS-001", missionId: "M-001" })),
// resolveFeatureMission (reached via processTaskOutcome during recovery)
// walks getSlice → getMilestone → getMission to gate on mission.status.
// Without getMission the walk throws and recovery aborts before it can
// ensure assertions / start the validator run this test asserts on.
getMission: vi.fn(() => ({ id: "M-001", status: "active" })),
logMissionEvent: vi.fn(),
transitionLoopState: vi.fn(),
setFeatureCurrentTaskRunId: vi.fn(),
@@ -277,6 +282,11 @@ describe("FN-5715 reliability: mission validation trigger gap", () => {
completeValidatorRun: vi.fn(),
getSlice: vi.fn(() => ({ id: "SL-001", milestoneId: "MS-001", status: "active" })),
getMilestone: vi.fn(() => ({ id: "MS-001", missionId: "M-001" })),
// resolveFeatureMission (reached via processTaskOutcome during recovery)
// walks getSlice → getMilestone → getMission to gate on mission.status.
// Without getMission the walk throws and recovery aborts before it can
// ensure assertions / start the validator run this test asserts on.
getMission: vi.fn(() => ({ id: "M-001", status: "active" })),
logMissionEvent: vi.fn(),
transitionLoopState: vi.fn(),
setFeatureCurrentTaskRunId: vi.fn(),

6
packages/engine/src/__tests__/restart.integration.test.ts
View File

@@ -43,6 +43,12 @@ vi.mock("../pi.js", () => ({
// session. The mock must expose the export so the resume/triage paths can
// reach finalization instead of throwing on a missing mock member.
formatModelMarkerDetails: vi.fn((model: string) => model),
// triage.ts guards its catch block with `err instanceof ModelFallbackExhaustedError`
// (imported from pi.js). Because this factory replaces pi.js wholesale, the class
// must be exported or evaluating the `instanceof` throws "No ModelFallbackExhaustedError
// export is defined on the mock". No restart test enters the fallback-exhausted branch,
// so a plain Error subclass is a faithful stub (instanceof simply returns false).
ModelFallbackExhaustedError: class ModelFallbackExhaustedError extends Error {},
}));
vi.mock("../reviewer.js", () => ({
reviewStep: vi.fn(),