FN-6065: fix pending-review advisory retry expectation

Adjust the reliability test to match the queued advisory retry path.

- update the plan-review UNAVAILABLE assertion to expect the task to requeue instead of fail
- assert the advisory path clears the error while incrementing the retry counter
- keep coverage that pending review should not record the executor review-pending failure

Files changed:
 packages/engine/src/__tests__/reliability-interactions/executor-pending-review-skip-retry.test.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Fusion-Task-Id: FN-6065

Fusion-Task-Lineage: 1ef13146-f19b-4735-9ec5-3f00eff6e575
This commit is contained in:
gsxdsm
2026-06-09 02:15:03 -07:00
parent 14cea4a24e
commit e5e5ccf01f

View File

@@ -126,9 +126,13 @@ describe("reliability interactions: FN-5436 executor pending-review skip", () =>
expect(mockedCreateFnAgent).toHaveBeenCalledTimes(4);
expect(store.updateTask).toHaveBeenCalledWith("FN-5436-RI-E", {
status: "failed",
error: "Agent finished without calling fn_task_done (after 3 retries)",
status: "queued",
error: null,
taskDoneRetryCount: 1,
});
expect(store.updateTask).not.toHaveBeenCalledWith("FN-5436-RI-E", {
status: "failed",
error: "executor-exit-while-review-pending",
});
});
});