root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: drop the removed subtask handler case, document the star-prompt setting

Browse Source 
- useTaskHandlers: deletes `handleSubtaskTasksCreated delegates with addToast`
  and its `onSubtaskTasksCreated` fixture field. FN-074 removed task splitting;
  grep confirms no production reference to either symbol remains, so the case
  was asserting a deleted contract.
- settings-default-descriptions: records `githubStarPromptDismissedAt` as
  internal bookkeeping written by useGitHubStarPrompt rather than a rendered
  Settings field, which is what that guard requires of every settings key.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
gsxdsm
2026-08-23 19:16:53 -07:00
parent bcf353de48
commit f3e248bb25
2 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/dashboard/app/components/settings/sections/__tests__/settings-default-descriptions.test.tsx
View File

@@ -345,6 +345,8 @@ const SETTING_DESCRIPTION_KEYS: Record<string, string> = {
const NOT_SURFACED_ALLOWLIST: Record<string, string> = {
// FNXC:TaskOutputLanguage 2026-08-19-14:56: Legacy compatibility remains persisted but hidden behind the three-mode selector.
taskDefinitionInInputLanguage: "legacy task-output-language compatibility flag, not a rendered Settings field",
// FNXC:GitHubStarPrompt 2026-08-24-00:34: Internal dismissal timestamp written by useGitHubStarPrompt when the operator dismisses the star ask; runtime bookkeeping state, not a user-editable Settings field.
githubStarPromptDismissedAt: "internal star-prompt dismissal timestamp written by useGitHubStarPrompt; not a rendered Settings field",
/*
FNXC:OriginWorkflowSelection 2026-07-26-19:40:
Server-side mirror of the operator's Board workflow lane, written by the dashboard

13
packages/dashboard/app/hooks/__tests__/useTaskHandlers.test.ts
View File

@@ -26,7 +26,6 @@ function createOptions(overrides: Partial<Parameters<typeof useTaskHandlers>[0]>
ingestCreatedTasks: vi.fn(),
onPlanningTaskCreated: vi.fn(),
onPlanningTasksCreated: vi.fn(),
onSubtaskTasksCreated: vi.fn(),
addToast: vi.fn(),
...overrides,
};
@@ -107,18 +106,6 @@ describe("useTaskHandlers", () => {
expect(options.onPlanningTasksCreated).toHaveBeenCalledWith([CREATED_TASK], options.addToast);
});
it("handleSubtaskTasksCreated delegates with addToast", () => {
const options = createOptions();
const { result } = renderHook(() => useTaskHandlers(options));
act(() => {
result.current.handleSubtaskTasksCreated([CREATED_TASK]);
});
expect(options.ingestCreatedTasks).toHaveBeenCalledWith([CREATED_TASK]);
expect(options.onSubtaskTasksCreated).toHaveBeenCalledWith([CREATED_TASK], options.addToast);
});
it("handleGitHubImport shows success toast with task ID", () => {
const options = createOptions();
const { result } = renderHook(() => useTaskHandlers(options));