root/fusion
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FN-9005: add scoped workflow analytics regression coverage

Browse Source 
Cover workflow-name analytics lookups across project-scoped, legacy, and built-in workflow selections.

- Scope existing custom-workflow analytics fixtures to their owning project
- Add PostgreSQL coverage preventing foreign or legacy workflow names from leaking into project analytics
- Verify built-in workflow labels remain resolved

Files changed:
 packages/core/src/__tests__/postgres/command-center-remaining-analytics.pg.test.ts | 73 ++++++++++++++++++++--
 1 file changed, 69 insertions(+), 4 deletions(-)

Fusion-Task-Id: FN-9005

Fusion-Task-Lineage: e2686ef0-4cbe-4993-be03-05cac6948401

Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
This commit is contained in:
gsxdsm
2026-08-12 09:26:53 -07:00
parent b6839f4f03
commit f85f6257f6
1 changed files with 69 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
packages/core/src/__tests__/postgres/command-center-remaining-analytics.pg.test.ts
View File

@@ -104,13 +104,19 @@ pgTest("Command Center remaining analytics aggregators (PostgreSQL backend mode)
{ description: "workflow target", column: "done" },
{ taskId: "FN-WF-1", createdAt: IN_RANGE, updatedAt: IN_RANGE, applyDefaultWorkflowSteps: false },
);
/*
* FNXC:PostgresCommandCenterAnalytics 2026-08-12-16:15:
* FN-8998 scopes custom workflow-name prefetches by project_id. Omitting this
* owner lets the trigger stamp __legacy_unscoped__, which a p1-bound analytics
* layer cannot resolve; keep this workflow and its selection in p1 together.
*/
await adminDb.execute(sql`
INSERT INTO project.workflows (id, name, description, ir, layout, kind, created_at, updated_at)
VALUES ('wf-custom', 'Custom WF', '', ${JSON.stringify({ version: "v2" })}::jsonb, '{}'::jsonb, 'workflow', ${IN_RANGE}, ${IN_RANGE})
INSERT INTO project.workflows (project_id, id, name, description, ir, layout, kind, created_at, updated_at)
VALUES ('p1', 'wf-custom', 'Custom WF', '', ${JSON.stringify({ version: "v2" })}::jsonb, '{}'::jsonb, 'workflow', ${IN_RANGE}, ${IN_RANGE})
`);
await adminDb.execute(sql`
INSERT INTO project.task_workflow_selection (task_id, workflow_id, step_ids, updated_at)
VALUES ('FN-WF-1', 'wf-custom', '[]'::jsonb, ${IN_RANGE})
INSERT INTO project.task_workflow_selection (project_id, task_id, workflow_id, step_ids, updated_at)
VALUES ('p1', 'FN-WF-1', 'wf-custom', '[]'::jsonb, ${IN_RANGE})
`);
await adminDb.execute(sql`
UPDATE project.tasks SET
@@ -227,6 +233,65 @@ pgTest("Command Center remaining analytics aggregators (PostgreSQL backend mode)
expect(columnCounts["in-progress"]).toBe(1); // FN-GH-1
});
/*
* FNXC:PostgresCommandCenterAnalytics 2026-08-12-16:15:
* A project-bound workflow analytics layer may resolve custom display names
* only from its own workflow partition. Foreign and trigger-stamped legacy
* rows can still supply joined workflow ids, but must never supply a name.
*/
it("resolves workflow names only from the bound project partition", async () => {
const store = h.store();
const adminDb = h.adminDb();
const taskIds = ["FN-WF-SCOPED", "FN-WF-LEGACY", "FN-WF-BUILTIN"];
for (const taskId of taskIds) {
await store.createTaskWithReservedId(
{ description: `workflow partition fixture ${taskId}`, column: "done" },
{ taskId, createdAt: IN_RANGE, updatedAt: IN_RANGE, applyDefaultWorkflowSteps: false },
);
}
await adminDb.execute(sql`
UPDATE project.tasks SET column_moved_at = ${IN_RANGE}
WHERE id IN ('FN-WF-SCOPED', 'FN-WF-LEGACY', 'FN-WF-BUILTIN')
`);
await adminDb.execute(sql`
INSERT INTO project.workflows (project_id, id, name, description, ir, layout, kind, created_at, updated_at)
VALUES
('p1', 'wf-custom', 'Custom WF', '', ${JSON.stringify({ version: "v2" })}::jsonb, '{}'::jsonb, 'workflow', ${IN_RANGE}, ${IN_RANGE}),
('p2', 'wf-custom', 'Foreign WF', '', ${JSON.stringify({ version: "v2" })}::jsonb, '{}'::jsonb, 'workflow', ${IN_RANGE}, ${IN_RANGE})
`);
await adminDb.execute(sql`
INSERT INTO project.workflows (id, name, description, ir, layout, kind, created_at, updated_at)
VALUES ('wf-legacy-only', 'Legacy WF', '', ${JSON.stringify({ version: "v2" })}::jsonb, '{}'::jsonb, 'workflow', ${IN_RANGE}, ${IN_RANGE})
`);
expect(await h.adminSql()<Array<{ project_id: string }>>`
SELECT project_id FROM project.workflows WHERE id = 'wf-legacy-only'
`).toEqual([{ project_id: "__legacy_unscoped__" }]);
await adminDb.execute(sql`
INSERT INTO project.task_workflow_selection (project_id, task_id, workflow_id, step_ids, updated_at)
VALUES
('p1', 'FN-WF-SCOPED', 'wf-custom', '[]'::jsonb, ${IN_RANGE}),
('p2', 'FN-WF-BUILTIN', 'builtin:coding', '[]'::jsonb, ${IN_RANGE})
`);
await adminDb.execute(sql`
INSERT INTO project.task_workflow_selection (task_id, workflow_id, step_ids, updated_at)
VALUES ('FN-WF-LEGACY', 'wf-legacy-only', '[]'::jsonb, ${IN_RANGE})
`);
const workflow = await aggregateWorkflowAnalytics(
Object.assign(h.layer(), { projectId: "p1" }),
{ from: FROM, to: TO, defaultWorkflowId: "builtin:coding" },
);
const custom = workflow.workflows.find((row) => row.workflowId === "wf-custom");
const legacy = workflow.workflows.find((row) => row.workflowId === "wf-legacy-only");
const builtin = workflow.workflows.find((row) => row.workflowId === "builtin:coding");
expect(custom).toMatchObject({ workflowId: "wf-custom", workflowName: "Custom WF", isBuiltin: false });
expect(workflow.workflows.some((row) => row.workflowName === "Foreign WF")).toBe(false);
expect(legacy).toMatchObject({ workflowId: "wf-legacy-only", workflowName: "wf-legacy-only", isBuiltin: false });
expect(builtin).toMatchObject({ workflowId: "builtin:coding", workflowName: "Coding", isBuiltin: true });
});
/*
* FNXC:CommandCenter 2026-07-10:
* FN-7786 (PG port of the upstream sqlite regression): workflow cost