f11800f2c6
Split app/styles.css from ~40k lines down to ~4.5k. Created 56 co-located
component CSS files in app/components/, each imported by its owning .tsx.
The remainder of styles.css holds genuinely global rules (design tokens,
.btn/.card/.modal/.form-input primitives, cross-component @media overrides).
- Lazy-load 13 heavy views (AgentsView, RoadmapsView, NodesView, etc.) via
React.lazy + Suspense; prefetch all chunks on idle so first navigation is
instant. Initial JS bundle: 1.58 MB → 1.16 MB (-26%). Initial CSS bundle:
635 kB → 471 kB (-26%); the rest splits into 13 per-view chunks.
- Add app/test/cssFixture.ts exposing loadAllAppCss() + loadAllAppCssBaseOnly()
so CSS regression tests load the full per-component bundle (mirroring Vite
source order). Migrate 30+ tests off direct readFileSync('../styles.css').
- Enable test.css: { include: [/.+/] } in vitest.config.ts so component CSS
imports actually inject styles in jsdom (fixes getComputedStyle assertions).
- Add ESLint rule (no-restricted-syntax) banning direct styles.css reads in
dashboard test files; points at loadAllAppCss() instead.
- Restore lost utility classes (.text-muted, .text-secondary, .text-dim,
.form-input) and rescue dropped chat tool-call rules into QuickChatFAB.css.
- Mobile fixes along the way: scroll containment for view containers
(min-height:0 + -webkit-overflow-scrolling), QuickChatFAB full-screen on
mobile (with safe-area-inset for iOS home bar), AgentsView single-row
header layout, ActivityLogModal close button on right, model-combobox
z-index above the mobile quick-chat panel.
- Bug fix: SkillsView toggle was display:none which hid the input from the
accessibility tree; replaced with the visually-hidden pattern so screen
readers + getByRole still find the checkbox.
- Bug fix: standalone Delete button in TaskDetailModal for triage-column
tasks (Actions dropdown is hidden in triage state, so previously no way
to delete a freshly-created task without status change first).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
77 lines
2.8 KiB
TypeScript
77 lines
2.8 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { loadAllAppCss } from "../test/cssFixture";
|
|
import { readFileSync } from "fs";
|
|
import { resolve } from "path";
|
|
|
|
const css = loadAllAppCss();
|
|
|
|
describe("scroll-snap CSS", () => {
|
|
describe("base (desktop) styles", () => {
|
|
it("contains scroll-snap-type: x proximity on .board", () => {
|
|
expect(css).toContain("scroll-snap-type: x proximity");
|
|
});
|
|
|
|
it("contains scroll-snap-align: center on .column", () => {
|
|
// The base .column rule should include scroll-snap-align: center
|
|
const columnBlockMatch = css.match(/\.column\s*\{[^}]*\}/);
|
|
expect(columnBlockMatch).not.toBeNull();
|
|
expect(columnBlockMatch![0]).toContain("scroll-snap-align: center");
|
|
});
|
|
|
|
it("contains scroll-padding-inline on .board", () => {
|
|
expect(css).toContain("scroll-padding-inline");
|
|
});
|
|
});
|
|
|
|
describe("mobile @media (max-width: 768px)", () => {
|
|
// Extract the mobile media block for scoped assertions
|
|
const mediaStart = css.search(
|
|
/@media\s*\([^)]*max-width:\s*768px[^)]*\)\s*\{/,
|
|
);
|
|
const afterMedia = css.slice(mediaStart);
|
|
|
|
it("contains scroll-snap-type: x mandatory", () => {
|
|
expect(css).toContain("scroll-snap-type: x mandatory");
|
|
});
|
|
|
|
it("contains scroll-snap-align: center (not start)", () => {
|
|
expect(afterMedia).toContain("scroll-snap-align: center");
|
|
expect(afterMedia).not.toContain("scroll-snap-align: start");
|
|
});
|
|
|
|
it("contains -webkit-overflow-scrolling: touch", () => {
|
|
expect(css).toContain("-webkit-overflow-scrolling: touch");
|
|
});
|
|
|
|
it("contains flex-shrink: 0", () => {
|
|
expect(css).toContain("flex-shrink: 0");
|
|
});
|
|
|
|
it("contains scroll-padding-inline in the media block", () => {
|
|
expect(afterMedia).toContain("scroll-padding-inline");
|
|
});
|
|
|
|
it("scroll-snap rules are inside a @media block", () => {
|
|
expect(mediaStart).toBeGreaterThanOrEqual(0);
|
|
expect(afterMedia).toContain("scroll-snap-type: x mandatory");
|
|
expect(afterMedia).toContain("scroll-snap-align: center");
|
|
});
|
|
});
|
|
|
|
describe("card touch-action", () => {
|
|
it("allows horizontal panning so board swipes work when starting on a card", () => {
|
|
const cardBlockMatch = css.match(/\.card\s*\{[^}]*\}/s);
|
|
expect(cardBlockMatch).not.toBeNull();
|
|
expect(cardBlockMatch![0]).toContain("touch-action: pan-x pan-y");
|
|
});
|
|
|
|
it("does not use touch-action: pan-y alone (which blocks horizontal swipes)", () => {
|
|
// The card should NOT have just pan-y; it needs pan-x too
|
|
const cardBlockMatch = css.match(/\.card\s*\{[^}]*\}/s);
|
|
expect(cardBlockMatch).not.toBeNull();
|
|
const cardBlock = cardBlockMatch![0];
|
|
expect(cardBlock).not.toMatch(/touch-action:\s*pan-y\s*;/);
|
|
});
|
|
});
|
|
});
|