Files
fusion/packages/dashboard/app/components/TaskContextMenu.tsx
gsxdsm 3cef9c226e Drift 1/4: TaskCard planning affordances from traits, not "triage" (8→3 measured; one site needed a new wire fact, one conversion was wrong and the tests caught it) (#2558)
## Drift conversion 1 of 4 — TaskCard.tsx

Taking the dashboard surfaces from the drift review. This is the
board-card one; ListView, TaskDetailModal and
register-task-workflow-routes follow separately so each stays
revertable.

### Convergence number

`task.column === / !== "todo" | "triage"` in `TaskCard.tsx`: **8 → 3**

The three survivors are **one documented fallback**, not scattered
checks. `getTaskColumnFlags` (Column.tsx) returns `undefined` when a
card's column is absent from the resolved metadata and is not the
rendering column — the pre-load window, and a card stranded in a lane
its workflow dropped. Converting to bare trait reads would have removed
every planning affordance in exactly those states, so the legacy ids
survive **once**, at the role helpers, plus the move prompt resolving
its own target. They retire with the load window, not with this change.

I'd rather report 8 → 3 with the reason than 8 → 0 with a regression
behind it.

### Why this file was urgent

Every planning affordance was gated on `task.column === "triage"`. Land
U11 — merged column keeps id `todo`, `triage` deleted — and each
comparison silently becomes false: **delete button, awaiting-approval
controls, planner badge, step list all vanish from planning cards.**

### One site needed a new fact on the wire, not a renamed comparison

`showStartAction` was `intake === true && column !== "triage"`. That
hardcoded id was standing in for *"an intake column that does not
auto-triage"* — a distinction that lives in trait **config** (`intake`
with `autoTriage: false`) and was invisible to every client.

It also **inverts** under U11: with `triage` deleted, `column !==
"triage"` is vacuously true, so a Start button would appear on **every
planning card**. `describeColumns` now derives `manualIntake`
server-side and the gate reads it. Renaming the comparison would have
shipped the inversion.

### One conversion was wrong, and the tests caught it

I first converted the move-progress prompt to the card's *own* column
role. The original tests the move **destination** — moving a card *back*
into a pre-implementation lane is what risks discarding step progress.
`confirms preserving progress before moving` failed immediately on an
`in-progress → todo` move. It now resolves the target column's flags.

That is the argument for red-green per site rather than pattern-matching
the comparison: the regex looks identical at both sites and means
different things.

### Revert-proof

New `TaskCard.u11-merged-column.test.tsx` renders cards in the
**post-U11 shape** — id `todo`, traits `intake + hold`, no `triage`
anywhere — and asserts Delete, the planner badge and the step list still
appear; that Start does **not** (auto-triaging); and that a
manual-intake lane does get it. Revert any converted site and the
matching case fails, because these cards are not in `triage` and never
will be again.

### Fixture updates, and why they are not weakening

- Start-affordance cases now pass `manualIntake`, which the server
supplies for a manual intake lane.
- "omits the Start button for the triage column even when intake is
flagged" → "for an **AUTO-triaging** intake column". The rule was never
about the id; the title said it was.

### Verification

`pnpm test:gate` (414 + 10 + 71), `pnpm lint`, both dashboard typechecks
green. **No new failures**: `TaskCard.test.tsx` reports the same 2
pre-existing failures with and without the change, verified by diffing
failing test *names* against a stashed clean tree rather than comparing
counts.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-29 09:54:16 -07:00

582 lines
26 KiB
TypeScript

import "./TaskContextMenu.css";
import type { KeyboardEvent, PointerEvent as ReactPointerEvent, MouseEvent as ReactMouseEvent, ReactNode } from "react";
import { Fragment, useCallback, useEffect, useRef } from "react";
import type { TFunction } from "i18next";
import type { ColumnId, Task, TaskDetail, WorkflowStepResult } from "@fusion/core";
import { VALID_TRANSITIONS, isColumn } from "@fusion/core";
// `COLUMNS` is gone from this file: deleting the default-column-set shortcut removed
// the last use. `VALID_TRANSITIONS` survives ONLY for the no-metadata load window (see
// the note at `moveTransitions`); every workflow-resolved path now reads the payload's
// own `moveTargets` adjacency.
/*
FNXC:ReviewLaneBypass 2026-07-09-00:00:
Dashboard app code only imports TYPES from @fusion/core (Vite aliases
"@fusion/core" straight to packages/core/src/types.ts to avoid bundling the
full core runtime into the client) — see vite.config.ts. So the bypass
affordance's failed-pre-merge-step selection predicate is duplicated here in
miniature rather than imported from packages/core/src/task-merge.ts's
getLatestFailedPreMergeReviewStep. Keep this in lockstep with that function
and self-healing.ts's latestFailedPreMergeStep (FN-7720): most-recent
phase!=="post-merge" result with status==="failed".
*/
function hasFailedPreMergeReviewStep(task: Pick<Task, "workflowStepResults">): boolean {
return (task.workflowStepResults ?? []).some(
(result: WorkflowStepResult) => (result.phase || "pre-merge") === "pre-merge" && result.status === "failed",
);
}
export type TaskMenuActionTone = "default" | "danger" | "note";
export interface TaskMenuActionDescriptor {
id: string;
label: string;
tone?: TaskMenuActionTone;
disabled?: boolean;
onSelect?: () => void;
}
export interface TaskMoveActionDescriptor {
column: ColumnId;
label: string;
primaryLabel: string;
}
export interface TaskContextMenuColumnFlags {
complete?: boolean;
archived?: boolean;
hiddenFromBoard?: boolean;
hold?: boolean;
intake?: boolean;
/** Intake WITHOUT auto-triage: the operator promotes the card by hand. */
manualIntake?: boolean;
mergeBlocker?: boolean;
humanReview?: boolean;
/* FNXC:WorkflowResolvedColumns 2026-07-27-15:30 (U10 / R8): surfaced so column-trait consumers
can tell an implementation lane from a pre-implementation one without naming `in-progress`. */
countsTowardWip?: boolean;
}
export interface TaskContextMenuColumnMetadata {
id: ColumnId;
label: string;
flags?: TaskContextMenuColumnFlags;
/** Columns this one may move to, from the workflow's own graph adjacency. Optional:
* a payload predating the field falls back to the neighbour approximation. */
moveTargets?: readonly string[];
}
export interface TaskReviewActionDescriptor {
id: "merge" | "start-pr-review" | "check-pr-status" | "pr-automation";
label: string;
disabled?: boolean;
onSelect?: () => void;
}
export interface TaskActionMenuModel {
actions: TaskMenuActionDescriptor[];
moveTransitions: TaskMoveActionDescriptor[];
reviewAction?: TaskReviewActionDescriptor;
shouldShowActionsMenu: boolean;
isTaskPaused: boolean;
}
export interface BuildTaskActionMenuModelOptions {
task: Task | TaskDetail;
t: TFunction<"app">;
columnLabel: (column: ColumnId) => string;
currentColumnFlags?: TaskContextMenuColumnFlags;
workflowMoveColumns?: readonly TaskContextMenuColumnMetadata[];
canRetryTask?: boolean;
hasDuplicateHandler?: boolean;
hasRetryHandler?: boolean;
hasResetHandler?: boolean;
hasAssignedAgent?: boolean;
hasBypassReviewHandler?: boolean;
mergeStrategy?: string;
autoMergeEnabled?: boolean;
prAutomationLabel?: string;
isCheckingPrStatus?: boolean;
onDelete?: () => void;
onDuplicate?: () => void;
/*
FNXC:TaskContextMenu 2026-07-13-00:00:
Pre-execution task cards can open the same Planning Mode handoff as inline create, but only hosts that wire a planning route should expose the action so dock/plugin/detail surfaces never render a dead Plan item.
*/
onPlan?: () => void;
onOpenRefine?: () => void;
onRespecify?: () => void;
onRetry?: () => void;
onReset?: () => void;
onTogglePause?: () => void;
onMerge?: () => void;
onStartPrReview?: () => void;
onCheckPrStatus?: () => void;
onEnableGithubTracking?: () => void;
/*
FNXC:ReviewLaneBypass 2026-07-09-00:00:
Operator-only bypass of the latest failed pre-merge review step (FN-7720).
Only TaskDetailModal wires `onBypassReview`, so the action is invisible in
the Board/List card context menus — kept to the single canonical
task-detail actions surface intentionally.
*/
onBypassReview?: () => void;
}
export function getTaskPrAutomationLabel(t: TFunction<"app">, status?: string): string | undefined {
if (!status) return undefined;
const prAutomationStatusLabels: Record<string, string> = {
"creating-pr": t("taskDetail.pr.creatingPr", "Creating PR…"),
"awaiting-pr-checks": t("taskDetail.pr.awaitingChecks", "Awaiting PR checks"),
"merging-pr": t("taskDetail.pr.mergingPr", "Merging PR…"),
"merging-fix": t("taskDetail.pr.mergingFixes", "Merging fixes…"),
};
return prAutomationStatusLabels[status];
}
function isReviewColumn(column: string, flags?: TaskContextMenuColumnFlags): boolean {
return column === "in-review" || flags?.mergeBlocker === true || flags?.humanReview === true;
}
function isDoneOrReview(column: string, flags?: TaskContextMenuColumnFlags): boolean {
return column === "done" || isReviewColumn(column, flags) || (flags?.complete === true && flags?.archived !== true);
}
function isMutableLiveColumn(column: string, flags?: TaskContextMenuColumnFlags): boolean {
if (flags) return flags.complete !== true && flags.archived !== true;
return column !== "done" && column !== "archived";
}
export function isPreExecutionHoldColumn(column: string, flags?: TaskContextMenuColumnFlags): boolean {
if (flags?.complete === true || flags?.archived === true) return false;
return column === "triage" || flags?.intake === true || flags?.hold === true;
}
/*
FNXC:TaskContextMenu 2026-06-30-12:42:
Workflow-column Board/List menus derive move targets from the task's workflow metadata instead of legacy VALID_TRANSITIONS. Built-in/default workflows keep exact legacy parity; custom workflows use visible neighbor columns and trait flags so custom complete/archived lanes are not treated as mutable live work.
FNXC:TaskContextMenu 2026-06-30-13:02:
Manual pull-request review has two separate operator intents: Start PR Review opens PR creation, while Merge & Close calls the merge endpoint. Keep distinct callbacks so card/list context menus cannot merge a task when the user asked to create a PR.
*/
function getWorkflowMoveTargets(task: Task | TaskDetail, columns: readonly TaskContextMenuColumnMetadata[]): ColumnId[] {
const visibleColumns = columns.filter((column) => column.flags?.hiddenFromBoard !== true);
/*
FNXC:TaskContextMenu 2026-07-29-00:00 (U12 — R8):
REAL ADJACENCY, when the payload carries it. `moveTargets` comes from
`resolveAllowedColumns` — the same resolver `moveTaskInternal` validates against — so
the menu offers exactly what the store will accept, for ANY workflow.
This replaces the `VALID_TRANSITIONS` shortcut that used to run whenever a workflow's
column-id set matched the six built-ins. That shortcut existed because the fallback
below approximates targets from a column's NEIGHBOURS in declared order, which is
strictly weaker than the graph (in-progress: 4 real targets vs 2 neighbours), so
deleting it without adjacency would have SHRUNK every default-workflow move menu.
With adjacency on the wire the shortcut is not merely removable, it is redundant:
`resolveAllowedColumns(BUILTIN_CODING_WORKFLOW_IR, c)` is byte-identical to
`VALID_TRANSITIONS[c]` for all six columns, ORDER included — measured, and pinned by
`@fusion/core`'s `builtin-adjacency-matches-legacy-transitions` test so the
equivalence cannot drift silently. Custom workflows stop being guessed at.
Targets are filtered to columns this board can show, so an adjacency edge into a
hidden column never becomes a dead menu entry.
*/
const declaredTargets = columns.find((column) => column.id === task.column)?.moveTargets;
if (declaredTargets) {
const visibleIds = new Set(visibleColumns.map((column) => column.id));
return declaredTargets.filter((target) => visibleIds.has(target)) as ColumnId[];
}
const currentIndex = visibleColumns.findIndex((column) => column.id === task.column);
/*
FNXC:WorkflowResolvedColumns 2026-07-27-14:55 (U10 / R8):
A card resting in a column its workflow no longer declares used to get an EMPTY move list —
the one surface that could rescue it offered nothing, so the card was stranded until an engine
sweep re-homed it. Offer the workflow's own recovery lane instead (intake, else hold, else the
first live lane), which is the same target `resolveReboundTarget` picks engine-side. Undeclared
columns are produced by a workflow edit that drops a lane and by U11's Todo→Planning merge for
rows still stored in `todo`.
*/
if (currentIndex < 0) {
const liveColumns = visibleColumns.filter(
(column) => column.flags?.complete !== true && column.flags?.archived !== true,
);
const recoveryColumn = liveColumns.find((column) => column.flags?.intake === true)
?? liveColumns.find((column) => column.flags?.hold === true)
?? liveColumns[0];
return recoveryColumn ? [recoveryColumn.id] : [];
}
const targets: ColumnId[] = [];
const previous = visibleColumns[currentIndex - 1]?.id;
const next = visibleColumns[currentIndex + 1]?.id;
if (previous) targets.push(previous);
if (next) targets.push(next);
return targets;
}
export function getTaskMoveTransitions(
task: Task | TaskDetail,
t: TFunction<"app">,
columnLabel: (column: ColumnId) => string,
workflowMoveColumns?: readonly TaskContextMenuColumnMetadata[],
): TaskMoveActionDescriptor[] {
/*
FNXC:TaskContextMenu 2026-07-29-00:00 (U12 — R8, decision recorded):
The no-metadata `VALID_TRANSITIONS` fallback is KEPT. I removed it first, on the R8
principle, and measured the result: `workflowMoveColumns` is optional at both call
sites (`workflowMoveMetadata?.moveColumns`, `taskMoveColumns`) and is genuinely
undefined until board-workflows resolves, so dropping it left Task Detail with NO
move options during load — a live surface degraded to satisfy a purity rule. That is
a regression, not a cleanup, so it is not shipped.
Unlike Board and ListView, where the legacy path was provably unreachable, this one
is reachable and useful. It is retired the same way the shortcut above is: by putting
each column's allowed targets on the board-workflows payload so the load window has
real data instead of a guess.
*/
const moveTransitions: ColumnId[] = workflowMoveColumns
? getWorkflowMoveTargets(task, workflowMoveColumns)
: isColumn(task.column)
? (task.column === "in-review" ? ["todo", "in-progress"] : [...VALID_TRANSITIONS[task.column]])
: [];
const visibleOrdered = (workflowMoveColumns ?? []).filter((column) => column.flags?.hiddenFromBoard !== true);
const workflowLabelById = new Map(visibleOrdered.map((column) => [column.id, column.label]));
/*
FNXC:TaskContextMenu 2026-07-29-00:00 (U12 — R8):
"Back to X" is derived from COLUMN TRAITS, not from the literals `in-review` and
`in-progress`. The old condition (`column === "in-progress" && task.column ===
"in-review"`) hardcoded two lifecycle ids AND a hardcoded English label ("Back to In
Progress"), so on a workflow that renames those columns it either failed to fire or
announced a column name that is not on the board.
The rule it was expressing is "leaving the review lane backwards into the work lane",
which the traits already say: the CURRENT column carries `mergeBlocker`, the TARGET
carries `countsTowardWip`. For builtin:coding those are exactly in-review and
in-progress, so the labelled set is unchanged — deliberately. I first generalised
this to "any target earlier in the workflow order", which is arguably nicer but
relabels moves this change never set out to touch (18 assertion sites across three
suites would have flipped from "Move to" to "Back to"). Same-set-different-derivation
is the honest scope here; widening which moves read as backwards is a separate,
visible product decision.
Load window (no metadata): fall back to the legacy id pair, matching the fallback
already kept for the targets themselves a few lines below.
*/
const flagsById = new Map(visibleOrdered.map((column) => [column.id, column.flags]));
const orderById = new Map(visibleOrdered.map((column, index) => [column.id, index]));
const currentFlags = flagsById.get(task.column);
const currentOrder = orderById.get(task.column);
const isBackwardsLabel = (target: ColumnId): boolean => {
if (visibleOrdered.length === 0) {
return target === "in-progress" && task.column === "in-review";
}
/*
FNXC:TaskContextMenu 2026-07-29-00:00 (PR #2521 review — greptile):
DIRECTION as well as traits. The traits alone say "review lane -> work lane", but a
workflow may declare a `countsTowardWip` column AFTER its `mergeBlocker` one (a
rework or hotfix lane placed downstream of review). Labelling that "Back to" would
call a FORWARD move backwards — the same class of wrongness as the hardcoded ids
this predicate replaced, just arrived at differently.
Requiring the target to sit EARLIER in the workflow's declared order keeps the
builtin:coding set unchanged (in-progress precedes in-review) while making the
label mean what it says on any column layout.
*/
if (currentOrder === undefined) return false;
const targetOrder = orderById.get(target);
if (targetOrder === undefined || targetOrder >= currentOrder) return false;
return currentFlags?.mergeBlocker === true && flagsById.get(target)?.countsTowardWip === true;
};
return moveTransitions.map((column) => {
const label = workflowLabelById.get(column) ?? columnLabel(column);
return {
column,
label: isBackwardsLabel(column)
? t("taskDetail.move.backTo", "Back to {{column}}", { column: label })
: t("taskDetail.move.moveTo", "Move to {{column}}", { column: label }),
primaryLabel: t("taskDetail.move.moveTo", "Move to {{column}}", { column: label }),
};
});
}
export function getTaskReviewAction(
task: Task | TaskDetail,
options: Pick<BuildTaskActionMenuModelOptions, "t" | "currentColumnFlags" | "mergeStrategy" | "autoMergeEnabled" | "prAutomationLabel" | "isCheckingPrStatus" | "onMerge" | "onStartPrReview" | "onCheckPrStatus">,
): TaskReviewActionDescriptor | undefined {
const currentColumnFlags = options.currentColumnFlags;
if (!isReviewColumn(task.column, currentColumnFlags)) {
return undefined;
}
if (options.prAutomationLabel) {
return { id: "pr-automation", label: options.prAutomationLabel, disabled: true };
}
const isManualPrFlow = options.mergeStrategy === "pull-request" && !options.autoMergeEnabled;
const prStatus = task.prInfo?.status;
if (isManualPrFlow) {
if (!task.prInfo) {
return { id: "start-pr-review", label: options.t("taskDetail.pr.startPrReview", "Start PR Review"), onSelect: options.onStartPrReview };
}
if (prStatus === "open") {
return {
id: "check-pr-status",
label: options.t("taskDetail.pr.checkPrStatus", "Check PR Status"),
disabled: options.isCheckingPrStatus,
onSelect: options.onCheckPrStatus,
};
}
if (prStatus === "merged") {
return { id: "merge", label: options.t("taskDetail.pr.finishAndClose", "Finish & Close"), onSelect: options.onMerge };
}
}
return { id: "merge", label: options.t("taskDetail.pr.mergeAndClose", "Merge & Close"), onSelect: options.onMerge };
}
export function buildTaskActionMenuModel(options: BuildTaskActionMenuModelOptions): TaskActionMenuModel {
const {
task,
t,
columnLabel,
currentColumnFlags,
workflowMoveColumns,
canRetryTask = false,
hasDuplicateHandler = Boolean(options.onDuplicate),
hasRetryHandler = Boolean(options.onRetry),
hasResetHandler = Boolean(options.onReset),
hasAssignedAgent = Boolean(task.assignedAgentId),
hasBypassReviewHandler = Boolean(options.onBypassReview),
} = options;
const isTaskPaused = Boolean(task.paused || task.userPaused);
const actions: TaskMenuActionDescriptor[] = [];
const destructiveActions: TaskMenuActionDescriptor[] = [];
if (hasDuplicateHandler) {
actions.push({ id: "duplicate", label: t("taskDetail.duplicate.btn", "Duplicate"), onSelect: options.onDuplicate });
}
/*
FNXC:TaskContextMenu 2026-07-13-00:00:
Plan belongs only to pre-execution hold/intake cards and reuses the inline-create Planning Mode handoff. Omit it entirely unless the host injects `onPlan`, because Planning Mode creates a new task and unwired menu hosts must not show a disabled shell.
*/
if (options.onPlan && isPreExecutionHoldColumn(task.column, currentColumnFlags)) {
actions.push({ id: "plan", label: t("taskDetail.plan.openPlanningBtn", "Plan"), onSelect: options.onPlan });
}
if (isDoneOrReview(task.column, currentColumnFlags) && options.onOpenRefine) {
actions.push({ id: "refine", label: t("taskDetail.refine.btn", "Refine"), onSelect: options.onOpenRefine });
}
/*
FNXC:TaskContextMenu 2026-07-16-12:00:
Archived is an unsupported Respecify source: the rebuild route rejects it rather than
resurrecting intentionally archived work into a planner lane. Check both the semantic
workflow trait and legacy id so every menu host omits this dead affordance.
*/
if (task.column !== "archived" && currentColumnFlags?.archived !== true) {
actions.push({ id: "respecify", label: t("taskDetail.respecify.btn", "Respecify"), onSelect: options.onRespecify });
}
if (canRetryTask && hasRetryHandler) {
actions.push({ id: "retry", label: t("taskDetail.retry.btn", "Retry"), onSelect: options.onRetry });
}
/*
FNXC:ReviewLaneBypass 2026-07-09-00:00:
Policy-gated escape hatch (FN-7720) for a card stranded in `in-review`
solely by a failed pre-merge review step (leading real-world cause:
Runfusion/Fusion#1946's no-verdict dispatch defect). Shown only when the
task is `in-review` and carries a failed pre-merge `WorkflowStepResult`, so
it never renders as an empty/dead affordance for tasks blocked by other
reasons or already recovered.
*/
if (hasBypassReviewHandler && task.column === "in-review" && hasFailedPreMergeReviewStep(task)) {
actions.push({
id: "bypass-review",
label: t("taskDetail.bypassReview.btn", "Bypass failed review"),
tone: "note",
onSelect: options.onBypassReview,
});
}
/*
FNXC:GitHubTracking 2026-07-01-00:00:
Board and List task menus mirror Task Detail's GitHub tracking enablement with one shared descriptor. Only hosts that can PATCH and refresh local task state inject the callback, so untracked tasks get a working shortcut and already-enabled/linked tasks never leave an empty disabled shell.
*/
if (options.onEnableGithubTracking && task.githubTracking?.enabled !== true) {
actions.push({
id: "enable-github-tracking",
label: t("taskDetail.githubTracking.enableCheckboxLabel", "Enable GitHub tracking"),
onSelect: options.onEnableGithubTracking,
});
}
if (hasResetHandler && isMutableLiveColumn(task.column, currentColumnFlags)) {
destructiveActions.push({ id: "reset", label: t("taskDetail.reset.btn", "Reset"), tone: "danger", onSelect: options.onReset });
}
if (isMutableLiveColumn(task.column, currentColumnFlags)) {
actions.push({
id: isTaskPaused ? "unpause" : "pause",
label: isTaskPaused ? t("taskDetail.pause.unpauseBtn", "Unpause") : t("taskDetail.pause.pauseBtn", "Pause"),
onSelect: options.onTogglePause,
});
}
if (isMutableLiveColumn(task.column, currentColumnFlags) && task.paused && task.pausedByAgentId) {
actions.push({ id: "paused-by-agent", label: t("taskDetail.pause.pausedByAgent", "Paused by agent"), tone: "note", disabled: true });
}
destructiveActions.push({
id: "delete",
label: t("taskDetail.delete.btn", "Delete"),
tone: "danger",
onSelect: options.onDelete,
});
/*
FNXC:TaskContextMenu 2026-07-01-00:00:
Popup context menus intentionally group destructive Reset and Delete actions at the bottom, with Delete last, so Board, List, and Detail hosts share the safer operator action order without forking availability or confirmation behavior.
*/
actions.push(...destructiveActions);
return {
actions,
moveTransitions: getTaskMoveTransitions(task, t, columnLabel, workflowMoveColumns),
reviewAction: getTaskReviewAction(task, options),
shouldShowActionsMenu:
task.column !== "triage" ||
task.status === "awaiting-approval" ||
canRetryTask ||
isTaskPaused ||
hasAssignedAgent ||
Boolean(options.onEnableGithubTracking && task.githubTracking?.enabled !== true),
isTaskPaused,
};
}
export interface TaskContextMenuProps {
actions: TaskMenuActionDescriptor[];
role?: "menu" | "list";
className?: string;
itemClassName?: string;
dangerItemClassName?: string;
noteItemClassName?: string;
onActionSelect?: (action: TaskMenuActionDescriptor) => void;
renderAction?: (action: TaskMenuActionDescriptor, defaultNode: ReactNode) => ReactNode;
autoFocusFirstItem?: boolean;
}
/*
FNXC:TaskContextMenu 2026-06-29-00:00:
Card, list, and detail task menus must share one action descriptor model so labels and lifecycle availability do not drift between surfaces. Keep destructive handlers injected by the host so existing confirmations, toasts, and API calls remain the source of truth.
*/
export function TaskContextMenu({
actions,
role = "menu",
className = "task-context-menu",
itemClassName = "task-context-menu__item",
dangerItemClassName = "task-context-menu__item--danger",
noteItemClassName = "task-context-menu__item--note",
onActionSelect,
renderAction,
autoFocusFirstItem = true,
}: TaskContextMenuProps) {
const menuRef = useRef<HTMLDivElement | null>(null);
const touchSelectedActionRef = useRef<{ id: string; at: number } | null>(null);
const selectAction = useCallback((action: TaskMenuActionDescriptor) => {
if (action.disabled || action.tone === "note" || !action.onSelect) return;
onActionSelect?.(action);
action.onSelect();
}, [onActionSelect]);
/*
FNXC:TaskContextMenu 2026-07-01-00:00:
Mobile task menus must commit the selected action on touch/pen pointer release before host popovers can be removed by outside-click or focus retargeting. Desktop mouse keeps click activation, while the click guard prevents synthesized mobile clicks from firing the same task action twice.
*/
const handleActionPointerUp = useCallback((event: ReactPointerEvent<HTMLButtonElement>, action: TaskMenuActionDescriptor) => {
if (event.pointerType === "mouse") return;
event.preventDefault();
event.stopPropagation();
touchSelectedActionRef.current = { id: action.id, at: Date.now() };
selectAction(action);
}, [selectAction]);
const handleActionClick = useCallback((event: ReactMouseEvent<HTMLButtonElement>, action: TaskMenuActionDescriptor) => {
const touchSelection = touchSelectedActionRef.current;
if (touchSelection?.id === action.id && Date.now() - touchSelection.at < 1000) {
event.preventDefault();
event.stopPropagation();
touchSelectedActionRef.current = null;
return;
}
touchSelectedActionRef.current = null;
selectAction(action);
}, [selectAction]);
/*
FNXC:TaskContextMenu 2026-07-16-20:50 (FN-8178):
Menus are portaled while their TaskCard/ListView hosts close on capture-phase board scroll. Focusing
the first action must not scroll a board ancestor, because that focus-created scroll is not an
explicit dismissal and previously closed the menu immediately. Preserve keyboard focus while
`preventScroll` leaves real user scrolling available to close the menu.
*/
useEffect(() => {
if (!autoFocusFirstItem) return;
const firstItem = menuRef.current?.querySelector<HTMLButtonElement>("button:not(:disabled)");
firstItem?.focus({ preventScroll: true });
}, [actions, autoFocusFirstItem]);
const handleKeyDown = (event: KeyboardEvent<HTMLDivElement>) => {
if (event.key !== "ArrowDown" && event.key !== "ArrowUp" && event.key !== "Home" && event.key !== "End") return;
const items = Array.from(menuRef.current?.querySelectorAll<HTMLButtonElement>("button:not(:disabled)") ?? []);
if (items.length === 0) return;
event.preventDefault();
const activeIndex = items.indexOf(document.activeElement as HTMLButtonElement);
const lastIndex = items.length - 1;
const nextIndex = event.key === "Home"
? 0
: event.key === "End"
? lastIndex
: event.key === "ArrowUp"
? (activeIndex <= 0 ? lastIndex : activeIndex - 1)
: (activeIndex >= lastIndex ? 0 : activeIndex + 1);
items[nextIndex]?.focus();
};
return (
<div ref={menuRef} className={className} role={role} onKeyDown={handleKeyDown}>
{actions.map((action) => {
const classes = [itemClassName];
if (action.tone === "danger") classes.push(dangerItemClassName);
if (action.tone === "note") classes.push(noteItemClassName);
const defaultNode = action.tone === "note" ? (
<span key={action.id} className={classes.join(" ")} role="note">
{action.label}
</span>
) : (
<button
key={action.id}
type="button"
className={classes.join(" ")}
role={role === "menu" ? "menuitem" : undefined}
disabled={action.disabled}
onPointerUp={(event) => handleActionPointerUp(event, action)}
onClick={(event) => handleActionClick(event, action)}
>
{action.label}
</button>
);
return <Fragment key={action.id}>{renderAction ? renderAction(action, defaultNode) : defaultNode}</Fragment>;
})}
</div>
);
}