cb57093d03
## Summary Wave 17 organizes Fusion into **domain folders** (stacks on #2397). ### Layout - **core/types/** — board, task, agents, settings, merge, workflow, mesh, … - **core/src/** — agents, ai, async-stores, workflows, tasks, config, db, … - **dashboard/app/api/** — client, tasks, agents, git, missions, planning, … - **engine/src/** — agents, auth, execution, merge, missions, overseer, worktree, … Root keepers retained for large entrypoints (`store.ts`, `executor.ts`, `merger.ts`, …). Public barrels (`@fusion/core`, `@fusion/engine`, `app/api.ts` → legacy) stay stable. ## Test plan - [x] `@fusion/core` typecheck - [x] `@fusion/engine` typecheck (pre-existing playwright-core noise only) - [ ] CI merge gate **Stack:** #2394 → #2397 → **this PR**
849 lines
34 KiB
TypeScript
849 lines
34 KiB
TypeScript
import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type {
|
|
Agent,
|
|
AgentHeartbeatRun,
|
|
AgentPerformanceSummary,
|
|
AgentReflection,
|
|
ReflectionMetrics,
|
|
Task,
|
|
} from "@fusion/core";
|
|
|
|
vi.mock("../pi.js", () => ({
|
|
createFnAgent: vi.fn(),
|
|
promptWithFallback: vi.fn(),
|
|
}));
|
|
|
|
import { createFnAgent, promptWithFallback } from "../pi.js";
|
|
import { AgentReflectionService } from "../agents/agent-reflection.js";
|
|
import { createReflectOnPerformanceTool, reflectOnPerformanceParams } from "../agent-tools.js";
|
|
|
|
const mockedCreateFnAgent = vi.mocked(createFnAgent);
|
|
const mockedPromptWithFallback = vi.mocked(promptWithFallback);
|
|
|
|
function makeAgent(overrides: Partial<Agent> = {}): Agent {
|
|
return {
|
|
id: "agent-1",
|
|
name: "Execution Agent",
|
|
role: "executor",
|
|
state: "active",
|
|
createdAt: "2026-04-08T00:00:00.000Z",
|
|
updatedAt: "2026-04-08T00:00:00.000Z",
|
|
metadata: {},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeTask(overrides: Partial<Task> = {}): Task {
|
|
return {
|
|
id: "FN-001",
|
|
description: "Test task",
|
|
column: "done",
|
|
dependencies: [],
|
|
steps: [],
|
|
currentStep: 0,
|
|
log: [],
|
|
createdAt: "2026-04-08T00:00:00.000Z",
|
|
updatedAt: "2026-04-08T01:00:00.000Z",
|
|
assignedAgentId: "agent-1",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeSummary(overrides: Partial<AgentPerformanceSummary> = {}): AgentPerformanceSummary {
|
|
return {
|
|
agentId: "agent-1",
|
|
totalTasksCompleted: 3,
|
|
totalTasksFailed: 1,
|
|
avgDurationMs: 120_000,
|
|
successRate: 0.75,
|
|
commonErrors: ["timeout"],
|
|
strengths: ["Clear commit boundaries"],
|
|
weaknesses: ["Improve test coverage"],
|
|
recentReflectionCount: 2,
|
|
computedAt: "2026-04-08T01:00:00.000Z",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeReflection(overrides: Partial<AgentReflection> = {}): AgentReflection {
|
|
return {
|
|
id: "reflection-1",
|
|
agentId: "agent-1",
|
|
timestamp: "2026-04-08T01:00:00.000Z",
|
|
trigger: "manual",
|
|
metrics: {
|
|
tasksCompleted: 2,
|
|
tasksFailed: 1,
|
|
avgDurationMs: 60_000,
|
|
commonErrors: ["timeout"],
|
|
},
|
|
insights: ["Tends to stall on testing"],
|
|
suggestedImprovements: ["Run targeted tests earlier"],
|
|
summary: "Performance is generally solid with room to tighten test feedback loops.",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function makeRun(overrides: Partial<AgentHeartbeatRun> = {}): AgentHeartbeatRun {
|
|
return {
|
|
id: "run-1",
|
|
agentId: "agent-1",
|
|
startedAt: "2026-04-08T00:00:00.000Z",
|
|
endedAt: "2026-04-08T00:05:00.000Z",
|
|
status: "completed",
|
|
contextSnapshot: { taskId: "FN-001" },
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createMockDeps() {
|
|
const agentStore = {
|
|
getAgent: vi.fn().mockResolvedValue(makeAgent()),
|
|
getRecentRuns: vi.fn().mockResolvedValue([makeRun()]),
|
|
} as any;
|
|
|
|
const taskStore = {
|
|
listTasks: vi.fn().mockResolvedValue([makeTask()]),
|
|
recordRunAuditEvent: vi.fn(),
|
|
getTask: vi.fn().mockResolvedValue(makeTask()),
|
|
} as any;
|
|
|
|
const reflectionStore = {
|
|
getPerformanceSummary: vi.fn().mockResolvedValue(makeSummary()),
|
|
getLatestReflection: vi.fn().mockResolvedValue(makeReflection()),
|
|
createReflection: vi.fn().mockImplementation(async ({
|
|
agentId,
|
|
trigger,
|
|
triggerDetail,
|
|
taskId,
|
|
metrics,
|
|
insights,
|
|
suggestedImprovements,
|
|
summary,
|
|
}: {
|
|
agentId: string;
|
|
trigger: AgentReflection["trigger"];
|
|
triggerDetail?: string;
|
|
taskId?: string;
|
|
metrics: ReflectionMetrics;
|
|
insights: string[];
|
|
suggestedImprovements: string[];
|
|
summary: string;
|
|
}) => makeReflection({
|
|
agentId,
|
|
trigger,
|
|
triggerDetail,
|
|
taskId,
|
|
metrics,
|
|
insights,
|
|
suggestedImprovements,
|
|
summary,
|
|
})),
|
|
} as any;
|
|
|
|
return { agentStore, taskStore, reflectionStore };
|
|
}
|
|
|
|
function createMockSession() {
|
|
return {
|
|
state: {},
|
|
dispose: vi.fn(),
|
|
} as any;
|
|
}
|
|
|
|
function expectNoReflectionProse(metadata: Record<string, unknown>) {
|
|
expect(metadata).not.toHaveProperty("summary");
|
|
expect(metadata).not.toHaveProperty("insights");
|
|
expect(metadata).not.toHaveProperty("suggestedImprovements");
|
|
expect(metadata).not.toHaveProperty("triggerDetail");
|
|
expect(Object.values(metadata)).not.toContain("Execution quality is strong with room to tighten feedback loops.");
|
|
expect(Object.values(metadata)).not.toContain("Strong execution on scoped changes");
|
|
expect(Object.values(metadata)).not.toContain("Run tests earlier in the cycle");
|
|
expect(Object.values(metadata)).not.toContain("manual check");
|
|
}
|
|
|
|
describe("AgentReflectionService", () => {
|
|
let tempRoot: string;
|
|
|
|
beforeEach(async () => {
|
|
vi.clearAllMocks();
|
|
tempRoot = await mkdtemp(join(tmpdir(), "agent-reflection-test-"));
|
|
});
|
|
|
|
describe("buildReflectionContext", () => {
|
|
it("returns context with recent outcomes, summary, and latest reflection", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
|
|
const context = await service.buildReflectionContext("agent-1");
|
|
|
|
expect(context.agent.id).toBe("agent-1");
|
|
expect(context.recentOutcomes).toHaveLength(1);
|
|
expect(context.performanceSummary?.successRate).toBe(0.75);
|
|
expect(context.latestReflection?.id).toBe("reflection-1");
|
|
});
|
|
|
|
it("returns empty recentOutcomes when no task history exists", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([]);
|
|
agentStore.getRecentRuns.mockResolvedValue([]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const context = await service.buildReflectionContext("agent-1");
|
|
|
|
expect(context.recentOutcomes).toEqual([]);
|
|
});
|
|
|
|
it("reads instructions from instructionsText when provided", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
agentStore.getAgent.mockResolvedValue(makeAgent({ instructionsText: "Always run tests before committing." }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const context = await service.buildReflectionContext("agent-1");
|
|
|
|
expect(context.instructions).toContain("Always run tests before committing.");
|
|
});
|
|
|
|
it("reads instructions from file when instructionsPath is set", async () => {
|
|
const instructionsDir = join(tempRoot, "agents");
|
|
const instructionsPath = join(instructionsDir, "executor.md");
|
|
await mkdir(instructionsDir, { recursive: true });
|
|
await writeFile(instructionsPath, "Prefer smaller commits with clear messages.", { encoding: "utf-8" });
|
|
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
agentStore.getAgent.mockResolvedValue(makeAgent({ instructionsPath: "agents/executor.md" }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const context = await service.buildReflectionContext("agent-1");
|
|
|
|
expect(context.instructions).toContain("Prefer smaller commits with clear messages.");
|
|
});
|
|
|
|
it("handles missing agent gracefully", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
agentStore.getAgent.mockResolvedValue(null);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const context = await service.buildReflectionContext("agent-missing");
|
|
|
|
expect(context.agent.id).toBe("agent-missing");
|
|
expect(context.agent.name).toContain("Unknown Agent");
|
|
});
|
|
|
|
it("includes latest reflection when available", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
reflectionStore.getLatestReflection.mockResolvedValue(makeReflection({ id: "reflection-latest" }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const context = await service.buildReflectionContext("agent-1");
|
|
|
|
expect(context.latestReflection?.id).toBe("reflection-latest");
|
|
});
|
|
});
|
|
|
|
describe("getRecentTaskOutcomes", () => {
|
|
it("returns completed outcomes for done and in-review tasks", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([
|
|
makeTask({ id: "FN-001", column: "done", assignedAgentId: "agent-1" }),
|
|
makeTask({ id: "FN-002", column: "in-review", assignedAgentId: "agent-1" }),
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const outcomes = await service.getRecentTaskOutcomes("agent-1", 10);
|
|
|
|
expect(outcomes.map((outcome) => outcome.outcome)).toEqual(["completed", "completed"]);
|
|
});
|
|
|
|
it("returns failed outcomes when status includes failed", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([
|
|
makeTask({ id: "FN-FAIL", column: "todo", status: "failed", assignedAgentId: "agent-1" }),
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const outcomes = await service.getRecentTaskOutcomes("agent-1", 10);
|
|
|
|
expect(outcomes).toHaveLength(1);
|
|
expect(outcomes[0]?.outcome).toBe("failed");
|
|
});
|
|
|
|
it("returns stuck outcomes when task was killed by stuck detector", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([
|
|
makeTask({
|
|
id: "FN-STUCK",
|
|
column: "todo",
|
|
status: "stuck-killed",
|
|
assignedAgentId: "agent-1",
|
|
log: [{ timestamp: "2026-04-08T00:00:00.000Z", action: "Task terminated due to stuck agent session" }],
|
|
}),
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const outcomes = await service.getRecentTaskOutcomes("agent-1", 10);
|
|
|
|
expect(outcomes).toHaveLength(1);
|
|
expect(outcomes[0]?.outcome).toBe("stuck");
|
|
});
|
|
|
|
it("respects limit parameter", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([
|
|
makeTask({ id: "FN-001", assignedAgentId: "agent-1" }),
|
|
makeTask({ id: "FN-002", assignedAgentId: "agent-1" }),
|
|
makeTask({ id: "FN-003", assignedAgentId: "agent-1" }),
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const outcomes = await service.getRecentTaskOutcomes("agent-1", 2);
|
|
|
|
expect(outcomes).toHaveLength(2);
|
|
});
|
|
|
|
it("returns empty array when agent has no tasks", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([makeTask({ assignedAgentId: "agent-2" })]);
|
|
agentStore.getRecentRuns.mockResolvedValue([]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const outcomes = await service.getRecentTaskOutcomes("agent-1", 10);
|
|
|
|
expect(outcomes).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("extractErrorPatterns", () => {
|
|
it("returns common errors from performance summary", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
reflectionStore.getPerformanceSummary.mockResolvedValue(makeSummary({ commonErrors: ["timeout", "merge conflict"] }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const errors = await service.extractErrorPatterns("agent-1");
|
|
|
|
expect(errors).toEqual(["timeout", "merge conflict"]);
|
|
});
|
|
|
|
it("returns empty array when no summary exists", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
reflectionStore.getPerformanceSummary.mockResolvedValue(makeSummary({
|
|
totalTasksCompleted: 0,
|
|
totalTasksFailed: 0,
|
|
avgDurationMs: 0,
|
|
successRate: 0,
|
|
commonErrors: [],
|
|
strengths: [],
|
|
weaknesses: [],
|
|
recentReflectionCount: 0,
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const errors = await service.extractErrorPatterns("agent-1");
|
|
|
|
expect(errors).toEqual([]);
|
|
});
|
|
|
|
it("returns empty array when summary has no errors", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
reflectionStore.getPerformanceSummary.mockResolvedValue(makeSummary({ commonErrors: [] }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const errors = await service.extractErrorPatterns("agent-1");
|
|
|
|
expect(errors).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("generateReflection", () => {
|
|
it("creates reflection when data is available", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
const session = createMockSession();
|
|
|
|
mockedCreateFnAgent.mockImplementation(async (options: any) => {
|
|
options.onText?.(JSON.stringify({
|
|
insights: ["Strong execution on scoped changes"],
|
|
suggestedImprovements: ["Run tests earlier in the cycle"],
|
|
summary: "Execution quality is strong with room to tighten feedback loops.",
|
|
}));
|
|
return { session };
|
|
});
|
|
mockedPromptWithFallback.mockResolvedValue(undefined);
|
|
|
|
const service = new AgentReflectionService({
|
|
agentStore,
|
|
taskStore,
|
|
reflectionStore,
|
|
rootDir: tempRoot,
|
|
});
|
|
|
|
const reflection = await service.generateReflection("agent-1", "manual", {
|
|
taskId: "FN-001",
|
|
triggerDetail: "manual check",
|
|
});
|
|
|
|
expect(reflection).not.toBeNull();
|
|
expect(reflectionStore.createReflection).toHaveBeenCalledTimes(1);
|
|
expect(reflectionStore.createReflection).toHaveBeenCalledWith(expect.objectContaining({
|
|
agentId: "agent-1",
|
|
trigger: "manual",
|
|
triggerDetail: "manual check",
|
|
taskId: "FN-001",
|
|
}));
|
|
expect(mockedCreateFnAgent).toHaveBeenCalledWith(expect.objectContaining({
|
|
tools: "readonly",
|
|
}));
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledTimes(1);
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
agentId: "agent-1",
|
|
taskId: "FN-001",
|
|
domain: "database",
|
|
mutationType: "reflection:generated",
|
|
target: "agent-1",
|
|
metadata: expect.objectContaining({
|
|
phase: "reflection",
|
|
source: "manual",
|
|
agentId: "agent-1",
|
|
trigger: "manual",
|
|
taskId: "FN-001",
|
|
reflectionId: "reflection-1",
|
|
tasksCompleted: 1,
|
|
tasksFailed: 0,
|
|
avgDurationMs: 3_600_000,
|
|
commonErrorCount: 1,
|
|
insightCount: 1,
|
|
suggestedImprovementCount: 1,
|
|
}),
|
|
}));
|
|
expectNoReflectionProse(taskStore.recordRunAuditEvent.mock.calls[0][0].metadata);
|
|
});
|
|
|
|
it("returns null when no meaningful data exists", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.listTasks.mockResolvedValue([]);
|
|
agentStore.getRecentRuns.mockResolvedValue([]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.generateReflection("agent-1", "manual");
|
|
|
|
expect(reflection).toBeNull();
|
|
expect(mockedCreateFnAgent).not.toHaveBeenCalled();
|
|
expect(reflectionStore.createReflection).not.toHaveBeenCalled();
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledTimes(1);
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
agentId: "agent-1",
|
|
domain: "database",
|
|
mutationType: "reflection:skipped",
|
|
target: "agent-1",
|
|
metadata: expect.objectContaining({
|
|
phase: "reflection",
|
|
source: "manual",
|
|
agentId: "agent-1",
|
|
trigger: "manual",
|
|
reason: "no-history",
|
|
}),
|
|
}));
|
|
expectNoReflectionProse(taskStore.recordRunAuditEvent.mock.calls[0][0].metadata);
|
|
});
|
|
|
|
it("returns null on AI session failure", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
mockedCreateFnAgent.mockRejectedValue(new Error("AI unavailable"));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.generateReflection("agent-1", "manual");
|
|
|
|
expect(reflection).toBeNull();
|
|
expect(reflectionStore.createReflection).not.toHaveBeenCalled();
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledTimes(1);
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
agentId: "agent-1",
|
|
domain: "database",
|
|
mutationType: "reflection:failed",
|
|
target: "agent-1",
|
|
metadata: expect.objectContaining({
|
|
phase: "reflection",
|
|
source: "manual",
|
|
agentId: "agent-1",
|
|
trigger: "manual",
|
|
errorClass: "Error",
|
|
}),
|
|
}));
|
|
expectNoReflectionProse(taskStore.recordRunAuditEvent.mock.calls[0][0].metadata);
|
|
});
|
|
|
|
it("persists reflection via reflectionStore.createReflection", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
const session = createMockSession();
|
|
|
|
mockedCreateFnAgent.mockImplementation(async (options: any) => {
|
|
options.onText?.(JSON.stringify({
|
|
insights: ["Insight A"],
|
|
suggestedImprovements: ["Improve B"],
|
|
summary: "Summary C",
|
|
}));
|
|
return { session };
|
|
});
|
|
mockedPromptWithFallback.mockResolvedValue(undefined);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
await service.generateReflection("agent-1", "post-task", {
|
|
taskId: "FN-777",
|
|
triggerDetail: "post-task reflection",
|
|
});
|
|
|
|
expect(reflectionStore.createReflection).toHaveBeenCalledWith(expect.objectContaining({
|
|
trigger: "post-task",
|
|
taskId: "FN-777",
|
|
triggerDetail: "post-task reflection",
|
|
}));
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
mutationType: "reflection:generated",
|
|
metadata: expect.objectContaining({
|
|
source: "post-task",
|
|
trigger: "post-task",
|
|
taskId: "FN-777",
|
|
}),
|
|
}));
|
|
});
|
|
|
|
it("keeps successful reflection generation best-effort when audit persistence fails", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
const session = createMockSession();
|
|
taskStore.recordRunAuditEvent.mockRejectedValue(new Error("audit unavailable"));
|
|
|
|
mockedCreateFnAgent.mockImplementation(async (options: any) => {
|
|
options.onText?.(JSON.stringify({
|
|
insights: ["Insight A"],
|
|
suggestedImprovements: ["Improve B"],
|
|
summary: "Summary C",
|
|
}));
|
|
return { session };
|
|
});
|
|
mockedPromptWithFallback.mockResolvedValue(undefined);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.generateReflection("agent-1", "user-requested", {
|
|
taskId: "FN-999",
|
|
});
|
|
|
|
expect(reflection).not.toBeNull();
|
|
expect(reflection?.trigger).toBe("user-requested");
|
|
expect(reflectionStore.createReflection).toHaveBeenCalledTimes(1);
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
// FNXC:AgentReflection 2026-07-04-00:00:
|
|
// FN-7528 exercises the deterministic, non-LLM post-task capture path: no createFnAgent/promptWithFallback
|
|
// call, a `post-task` record with structured metrics, and ids/counts/outcomes-only `reflection:captured`
|
|
// telemetry (never verificationScopeReason free-text, summary prose, or prompt text).
|
|
describe("captureTaskPerformance", () => {
|
|
it("persists a post-task record with structured fields sourced from the completed task, without calling the model provider", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7528",
|
|
column: "done",
|
|
assignedAgentId: "agent-1",
|
|
createdAt: "2026-04-08T00:00:00.000Z",
|
|
updatedAt: "2026-04-08T00:00:45.000Z",
|
|
recoveryRetryCount: 2,
|
|
modifiedFiles: ["packages/core/src/foo.ts", "packages/engine/src/bar.ts"],
|
|
log: [
|
|
{
|
|
timestamp: "2026-04-08T00:00:40.000Z",
|
|
action: "[verification] Running deterministic verification (test: pnpm --filter @fusion/core exec vitest run src/foo.test.ts, build: pnpm build)",
|
|
},
|
|
],
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7528");
|
|
|
|
expect(reflection).not.toBeNull();
|
|
expect(mockedCreateFnAgent).not.toHaveBeenCalled();
|
|
expect(mockedPromptWithFallback).not.toHaveBeenCalled();
|
|
expect(reflectionStore.createReflection).toHaveBeenCalledWith(expect.objectContaining({
|
|
agentId: "agent-1",
|
|
trigger: "post-task",
|
|
taskId: "FN-7528",
|
|
insights: [],
|
|
suggestedImprovements: [],
|
|
metrics: expect.objectContaining({
|
|
tasksCompleted: 1,
|
|
tasksFailed: 0,
|
|
durationMs: 45_000,
|
|
retryReworkCount: 2,
|
|
filesTouchedCount: 2,
|
|
packagesTouched: ["packages/core", "packages/engine"],
|
|
verificationCommands: [
|
|
"test: pnpm --filter @fusion/core exec vitest run src/foo.test.ts",
|
|
"build: pnpm build",
|
|
],
|
|
}),
|
|
}));
|
|
expect(reflection?.metrics.verificationFileScoped).toBe(true);
|
|
expect(reflection?.metrics.verificationScopeReason).toBeUndefined();
|
|
});
|
|
|
|
it("aggregates backend-persisted workflow rework under the resolved definition run id", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7528-rework",
|
|
column: "done",
|
|
recoveryRetryCount: 1,
|
|
}));
|
|
taskStore.getTaskWorkflowSelectionAsync = vi.fn().mockResolvedValue({
|
|
workflowId: "selected-workflow",
|
|
stepIds: [],
|
|
});
|
|
taskStore.getWorkflowDefinition = vi.fn().mockResolvedValue({ id: "resolved-definition" });
|
|
taskStore.loadWorkflowRunStepInstancesAsync = vi.fn().mockResolvedValue([
|
|
{ taskId: "FN-7528-rework", runId: "FN-7528-rework:resolved-definition", foreachNodeId: "n1", stepIndex: 0, reworkCount: 2 },
|
|
{ taskId: "FN-7528-rework", runId: "FN-7528-rework:resolved-definition", foreachNodeId: "n1", stepIndex: 1, reworkCount: 1 },
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7528-rework");
|
|
|
|
expect(taskStore.getWorkflowDefinition).toHaveBeenCalledWith("selected-workflow");
|
|
expect(taskStore.loadWorkflowRunStepInstancesAsync).toHaveBeenCalledWith("FN-7528-rework", "FN-7528-rework:resolved-definition");
|
|
expect(taskStore.loadWorkflowRunStepInstancesAsync).not.toHaveBeenCalledWith("FN-7528-rework", "FN-7528-rework:selected-workflow");
|
|
expect(taskStore.loadWorkflowRunStepInstancesAsync).not.toHaveBeenCalledWith("FN-7528-rework", "FN-7528-rework:run");
|
|
// recoveryRetryCount(1) + workflowReworkCount(2+1=3) = 4
|
|
expect(reflection?.metrics.retryReworkCount).toBe(4);
|
|
expect(reflection?.metrics.durationDrivers).toContain("retries:1");
|
|
expect(reflection?.metrics.durationDrivers).toContain("rework:3");
|
|
});
|
|
|
|
it("uses the synchronous step-instance fallback for legacy stores under the resolved run id", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({ id: "FN-7528-sync", column: "done" }));
|
|
taskStore.getTaskWorkflowSelection = vi.fn().mockReturnValue({ workflowId: "builtin:coding", stepIds: [] });
|
|
taskStore.loadWorkflowRunStepInstances = vi.fn().mockReturnValue([
|
|
{ taskId: "FN-7528-sync", runId: "FN-7528-sync:builtin:coding", foreachNodeId: "n1", stepIndex: 0, reworkCount: 2 },
|
|
]);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7528-sync");
|
|
|
|
expect(taskStore.loadWorkflowRunStepInstances).toHaveBeenCalledWith("FN-7528-sync", "FN-7528-sync:builtin:coding");
|
|
expect(reflection?.metrics.retryReworkCount).toBe(2);
|
|
expect(reflection?.metrics.durationDrivers).toContain("rework:2");
|
|
});
|
|
|
|
it("silently omits workflow rework when no selection or step-instance reader is available", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7528-degraded",
|
|
column: "done",
|
|
recoveryRetryCount: 1,
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7528-degraded");
|
|
|
|
expect(reflection).not.toBeNull();
|
|
expect(reflection?.metrics.retryReworkCount).toBe(1);
|
|
expect(reflection?.metrics.durationDrivers).toContain("retries:1");
|
|
expect(reflection?.metrics.durationDrivers).not.toContain("rework:0");
|
|
});
|
|
|
|
it("classifies a broad/whole-suite verification command as not file-scoped, with a reason", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7529",
|
|
column: "done",
|
|
log: [
|
|
{
|
|
timestamp: "2026-04-08T00:00:40.000Z",
|
|
action: "[verification] Running deterministic verification (test: pnpm test:full)",
|
|
},
|
|
],
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7529");
|
|
|
|
expect(reflection?.metrics.verificationFileScoped).toBe(false);
|
|
expect(reflection?.metrics.verificationScopeReason).toBeTruthy();
|
|
expect(reflection?.metrics.durationDrivers).toContain("verification-broad");
|
|
});
|
|
|
|
it("omits fields whose source is unavailable rather than fabricating values", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7530",
|
|
column: "done",
|
|
modifiedFiles: undefined,
|
|
log: [],
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7530");
|
|
|
|
expect(reflection).not.toBeNull();
|
|
expect(reflection?.metrics.packagesTouched).toBeUndefined();
|
|
expect(reflection?.metrics.filesTouchedCount).toBeUndefined();
|
|
expect(reflection?.metrics.verificationCommands).toBeUndefined();
|
|
expect(reflection?.metrics.verificationFileScoped).toBeUndefined();
|
|
expect(reflection?.metrics.verificationScopeReason).toBeUndefined();
|
|
expect(reflection?.metrics.retryReworkCount).toBeUndefined();
|
|
});
|
|
|
|
it("returns null and emits reflection:skipped with not-completed when the task is not resolvable to a terminal outcome", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({ id: "FN-7531", column: "in-progress" }));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7531");
|
|
|
|
expect(reflection).toBeNull();
|
|
expect(reflectionStore.createReflection).not.toHaveBeenCalled();
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
mutationType: "reflection:skipped",
|
|
metadata: expect.objectContaining({ reason: "not-completed" }),
|
|
}));
|
|
});
|
|
|
|
it("returns null and emits reflection:skipped with no-history when the task cannot be found", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(null);
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-missing");
|
|
|
|
expect(reflection).toBeNull();
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
mutationType: "reflection:skipped",
|
|
metadata: expect.objectContaining({ reason: "no-history" }),
|
|
}));
|
|
});
|
|
|
|
it("emits ids/counts/outcomes-only reflection:captured telemetry (no prose, reason free-text, or prompt text)", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({
|
|
id: "FN-7532",
|
|
column: "done",
|
|
recoveryRetryCount: 1,
|
|
modifiedFiles: ["packages/core/src/foo.ts"],
|
|
log: [
|
|
{
|
|
timestamp: "2026-04-08T00:00:40.000Z",
|
|
action: "[verification] Running deterministic verification (test: pnpm test:full)",
|
|
},
|
|
],
|
|
}));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
await service.captureTaskPerformance("agent-1", "FN-7532");
|
|
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
mutationType: "reflection:captured",
|
|
agentId: "agent-1",
|
|
taskId: "FN-7532",
|
|
metadata: expect.objectContaining({
|
|
agentId: "agent-1",
|
|
trigger: "post-task",
|
|
taskId: "FN-7532",
|
|
retryReworkCount: 1,
|
|
filesTouchedCount: 1,
|
|
packagesTouchedCount: 1,
|
|
verificationFileScoped: false,
|
|
}),
|
|
}));
|
|
|
|
const metadata = taskStore.recordRunAuditEvent.mock.calls[0][0].metadata;
|
|
expect(metadata).not.toHaveProperty("verificationScopeReason");
|
|
expect(metadata).not.toHaveProperty("summary");
|
|
expect(metadata).not.toHaveProperty("verificationCommands");
|
|
expectNoReflectionProse(metadata);
|
|
});
|
|
|
|
it("stays best-effort: emits reflection:failed and returns null when reflectionStore.createReflection throws", async () => {
|
|
const { agentStore, taskStore, reflectionStore } = createMockDeps();
|
|
taskStore.getTask.mockResolvedValue(makeTask({ id: "FN-7533", column: "done" }));
|
|
reflectionStore.createReflection.mockRejectedValue(new Error("disk unavailable"));
|
|
|
|
const service = new AgentReflectionService({ agentStore, taskStore, reflectionStore, rootDir: tempRoot });
|
|
const reflection = await service.captureTaskPerformance("agent-1", "FN-7533");
|
|
|
|
expect(reflection).toBeNull();
|
|
expect(taskStore.recordRunAuditEvent).toHaveBeenCalledWith(expect.objectContaining({
|
|
mutationType: "reflection:failed",
|
|
metadata: expect.objectContaining({ errorClass: "Error" }),
|
|
}));
|
|
});
|
|
});
|
|
|
|
describe("reflect_on_performance tool", () => {
|
|
it("returns formatted text when reflection succeeds", async () => {
|
|
const reflectionService = {
|
|
generateReflection: vi.fn().mockResolvedValue(makeReflection({
|
|
summary: "Reflection summary",
|
|
insights: ["Insight 1"],
|
|
suggestedImprovements: ["Improve 1"],
|
|
})),
|
|
} as any;
|
|
|
|
const tool = createReflectOnPerformanceTool(reflectionService, "agent-1");
|
|
const result = await (tool.execute as any)("tool-1", {}, {}, {}, undefined);
|
|
|
|
const content = result.content[0];
|
|
expect(content?.type).toBe("text");
|
|
if (!content || content.type !== "text") {
|
|
throw new Error("Expected text content");
|
|
}
|
|
|
|
expect(content.text).toContain("Summary: Reflection summary");
|
|
expect(content.text).toContain("Insights:");
|
|
expect(content.text).toContain("Suggested Improvements:");
|
|
});
|
|
|
|
it("returns no-data message when reflection returns null", async () => {
|
|
const reflectionService = {
|
|
generateReflection: vi.fn().mockResolvedValue(null),
|
|
} as any;
|
|
|
|
const tool = createReflectOnPerformanceTool(reflectionService, "agent-1");
|
|
const result = await (tool.execute as any)("tool-1", {}, {}, {}, undefined);
|
|
|
|
const content = result.content[0];
|
|
expect(content?.type).toBe("text");
|
|
if (!content || content.type !== "text") {
|
|
throw new Error("Expected text content");
|
|
}
|
|
|
|
expect(content.text).toBe("No reflection data available — not enough history yet.");
|
|
});
|
|
|
|
it("passes focus_area as triggerDetail", async () => {
|
|
const reflectionService = {
|
|
generateReflection: vi.fn().mockResolvedValue(makeReflection()),
|
|
} as any;
|
|
|
|
const tool = createReflectOnPerformanceTool(reflectionService, "agent-1");
|
|
await (tool.execute as any)("tool-1", { focus_area: "testing" }, {}, {}, undefined);
|
|
|
|
expect(reflectionService.generateReflection).toHaveBeenCalledWith(
|
|
"agent-1",
|
|
"manual",
|
|
{ triggerDetail: "Agent-initiated reflection focused on: testing" },
|
|
);
|
|
});
|
|
|
|
it("parameter schema accepts optional focus_area", () => {
|
|
const required = (reflectOnPerformanceParams as { required?: string[] }).required;
|
|
expect(required?.includes("focus_area") ?? false).toBe(false);
|
|
});
|
|
});
|
|
|
|
afterEach(async () => {
|
|
if (tempRoot) {
|
|
await rm(tempRoot, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|