- Add viewport-gated fetching to TaskCard component so only visible cards load their data - Implement lightweight memo comparison to prevent unnecessary re-renders - Add lazy enable gates to useSessionFiles and useTaskDiffStats hooks with caching - Add comprehensive tests for useSessionFiles and useTaskDiffStats hooks - Document viewport-gated loading patterns in memory and dashboard-load performance docs
143 lines
3.8 KiB
TypeScript
143 lines
3.8 KiB
TypeScript
import { useEffect, useState } from "react";
|
|
import { fetchTaskDiff } from "../api";
|
|
|
|
interface DiffStats {
|
|
filesChanged: number;
|
|
additions: number;
|
|
deletions: number;
|
|
}
|
|
|
|
interface UseTaskDiffStatsResult {
|
|
stats: DiffStats | null;
|
|
loading: boolean;
|
|
}
|
|
|
|
interface UseTaskDiffStatsOptions {
|
|
/** Enable fetching when true (default). Suppresses fetches for offscreen cards. */
|
|
enabled?: boolean;
|
|
}
|
|
|
|
/**
|
|
* Cache for diff stats to avoid repeated fetches during rerenders.
|
|
* Key format: "taskId:projectId"
|
|
* Entries expire after the TTL to ensure freshness.
|
|
*/
|
|
const diffStatsCache = new Map<string, { stats: DiffStats; expiresAt: number }>();
|
|
const CACHE_TTL_MS = 30_000; // 30 seconds
|
|
|
|
function getCacheKey(taskId: string, projectId?: string): string {
|
|
return `${taskId}:${projectId ?? ""}`;
|
|
}
|
|
|
|
function getCachedStats(taskId: string, projectId?: string): DiffStats | null {
|
|
const key = getCacheKey(taskId, projectId);
|
|
const entry = diffStatsCache.get(key);
|
|
|
|
if (!entry) return null;
|
|
|
|
// Check expiration
|
|
if (Date.now() > entry.expiresAt) {
|
|
diffStatsCache.delete(key);
|
|
return null;
|
|
}
|
|
|
|
return entry.stats;
|
|
}
|
|
|
|
function setCachedStats(taskId: string, projectId: string | undefined, stats: DiffStats): void {
|
|
const key = getCacheKey(taskId, projectId);
|
|
diffStatsCache.set(key, {
|
|
stats,
|
|
expiresAt: Date.now() + CACHE_TTL_MS,
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Clears all entries from the diff stats cache.
|
|
* Exported for testing purposes.
|
|
*/
|
|
export function __test_clearDiffStatsCache(): void {
|
|
diffStatsCache.clear();
|
|
}
|
|
|
|
/**
|
|
* Fetches diff stats for a done task that has a merge commit SHA.
|
|
*
|
|
* This ensures the TaskCard shows the same file-changed count as the
|
|
* TaskChangesTab (which fetches from `/api/tasks/:id/diff`). Without this
|
|
* hook the card falls back to `mergeDetails.filesChanged`, which is
|
|
* computed at merge time via `git show --shortstat` and can differ from the
|
|
* diff endpoint's count when the merge includes changes from multiple branches.
|
|
*
|
|
* @param taskId - Task identifier
|
|
* @param column - Current task column
|
|
* @param commitSha - Merge commit SHA (undefined = no merge yet)
|
|
* @param projectId - Optional project identifier
|
|
* @param options.enabled - When false, no fetch is made and returns empty/stable state
|
|
*/
|
|
export function useTaskDiffStats(
|
|
taskId: string,
|
|
column: string,
|
|
commitSha: string | undefined,
|
|
projectId?: string,
|
|
options: UseTaskDiffStatsOptions = {},
|
|
): UseTaskDiffStatsResult {
|
|
const enabled = options.enabled ?? true;
|
|
const [stats, setStats] = useState<DiffStats | null>(null);
|
|
const [loading, setLoading] = useState(false);
|
|
|
|
useEffect(() => {
|
|
// Disabled state: return stable empty state without fetching
|
|
if (!enabled) {
|
|
setStats(null);
|
|
setLoading(false);
|
|
return;
|
|
}
|
|
|
|
// Only fetch for done tasks with a recorded merge commit
|
|
if (!taskId || column !== "done" || !commitSha) {
|
|
setStats(null);
|
|
setLoading(false);
|
|
return;
|
|
}
|
|
|
|
// Check cache first - return immediately without loading flicker
|
|
const cached = getCachedStats(taskId, projectId);
|
|
if (cached) {
|
|
setStats(cached);
|
|
setLoading(false);
|
|
return;
|
|
}
|
|
|
|
let cancelled = false;
|
|
|
|
async function load() {
|
|
setLoading(true);
|
|
try {
|
|
const data = await fetchTaskDiff(taskId, undefined, projectId);
|
|
if (!cancelled) {
|
|
setStats(data.stats);
|
|
// Store in cache
|
|
setCachedStats(taskId, projectId, data.stats);
|
|
}
|
|
} catch {
|
|
if (!cancelled) {
|
|
setStats(null);
|
|
}
|
|
} finally {
|
|
if (!cancelled) {
|
|
setLoading(false);
|
|
}
|
|
}
|
|
}
|
|
|
|
void load();
|
|
|
|
return () => {
|
|
cancelled = true;
|
|
};
|
|
}, [taskId, column, commitSha, projectId, enabled]);
|
|
|
|
return { stats, loading };
|
|
}
|