Files
fusion/packages/dashboard/app/__tests__/versionCheck.test.ts
Fusion 8bc76ee52b feat(FN-3334): add auto-reload setting and fix worktree project resolution
Merged two features: FN-3334 introduces a new `autoReloadOnVersionChange` setting with a toggle in the Settings modal, version-check logic in the dashboard, and corresponding tests; FN-3335 fixes worktree project root resolution in `createFnAgent` and the skill resolver, with tests for both paths. S

Fusion-Task-Id: FN-3334
2026-05-03 16:26:47 -07:00

275 lines
8.8 KiB
TypeScript

/**
* @vitest-environment jsdom
*/
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
import {
isStaleChunkError,
handleChunkLoadError,
reloadOnce,
checkVersion,
consumeVersionUpdateFlag,
_resetCheckState,
_resetState,
setAutoReloadEnabled,
_isAutoReloadEnabled,
MIN_CHECK_INTERVAL_MS,
} from "../versionCheck";
// Mock __BUILD_VERSION__ (declared as const in the module)
vi.stubGlobal("__BUILD_VERSION__", "test-build-abc123");
describe("isStaleChunkError", () => {
it("returns true for known chunk error patterns", () => {
expect(isStaleChunkError(new Error("Failed to fetch dynamically imported module: ./foo.js"))).toBe(true);
expect(isStaleChunkError(new Error("error loading dynamically imported module"))).toBe(true);
expect(isStaleChunkError(new Error("Importing a module script failed"))).toBe(true);
expect(isStaleChunkError(new Error("text/html is not a valid JavaScript MIME type"))).toBe(true);
expect(isStaleChunkError(new Error("ChunkLoadError: loading chunk foo failed"))).toBe(true);
});
it("returns false for unrelated errors", () => {
expect(isStaleChunkError(new Error("Network request failed"))).toBe(false);
expect(isStaleChunkError(new Error("TypeError: Cannot read property"))).toBe(false);
expect(isStaleChunkError("some random string")).toBe(false);
expect(isStaleChunkError(null)).toBe(false);
expect(isStaleChunkError(undefined)).toBe(false);
});
});
describe("handleChunkLoadError", () => {
const reloadSpy = vi.fn();
beforeEach(() => {
vi.stubGlobal("location", { reload: reloadSpy });
window.sessionStorage.clear();
reloadSpy.mockClear();
});
it("returns true and calls reloadOnce for chunk errors", () => {
const result = handleChunkLoadError(new Error("Failed to fetch dynamically imported module: ./foo.js"));
expect(result).toBe(true);
expect(reloadSpy).toHaveBeenCalledTimes(1);
});
it("returns false for non-chunk errors", () => {
const result = handleChunkLoadError(new Error("Network error"));
expect(result).toBe(false);
expect(reloadSpy).not.toHaveBeenCalled();
});
});
describe("reloadOnce", () => {
const reloadSpy = vi.fn();
beforeEach(() => {
vi.stubGlobal("location", { reload: reloadSpy });
window.sessionStorage.clear();
reloadSpy.mockClear();
});
it("sets sessionStorage flag and calls window.location.reload()", () => {
reloadOnce("test reason");
expect(window.sessionStorage.getItem("fusion:version-reload")).toBe("1");
expect(reloadSpy).toHaveBeenCalledTimes(1);
});
it("suppresses duplicate calls", () => {
reloadOnce("first");
reloadOnce("second");
expect(reloadSpy).toHaveBeenCalledTimes(1);
});
});
describe("consumeVersionUpdateFlag", () => {
beforeEach(() => {
window.sessionStorage.clear();
});
it("returns true once then false (consumes the flag)", () => {
window.sessionStorage.setItem("fusion:version-update", "1");
expect(consumeVersionUpdateFlag()).toBe(true);
expect(consumeVersionUpdateFlag()).toBe(false);
});
it("returns false when flag is not set", () => {
expect(consumeVersionUpdateFlag()).toBe(false);
});
});
describe("checkVersion cooldown", () => {
const reloadSpy = vi.fn();
beforeEach(() => {
vi.stubGlobal("location", { reload: reloadSpy });
window.sessionStorage.clear();
reloadSpy.mockClear();
_resetCheckState();
// Ensure tab is visible
Object.defineProperty(document, "visibilityState", { value: "visible", configurable: true });
});
afterEach(() => {
vi.restoreAllMocks();
});
it("respects MIN_CHECK_INTERVAL_MS — second call within cooldown is suppressed", async () => {
const fetchSpy = vi.fn().mockResolvedValue({
ok: true,
headers: new Headers({ "content-type": "application/json" }),
json: () => Promise.resolve({ version: "different-version" }),
});
vi.stubGlobal("fetch", fetchSpy);
// First call should go through
await checkVersion();
expect(fetchSpy).toHaveBeenCalledTimes(1);
// Second call immediately after — should be suppressed by cooldown
await checkVersion();
expect(fetchSpy).toHaveBeenCalledTimes(1);
});
it("allows check after cooldown elapses", async () => {
vi.useFakeTimers();
const fetchSpy = vi.fn().mockResolvedValue({
ok: true,
headers: new Headers({ "content-type": "application/json" }),
json: () => Promise.resolve({ version: "different-version" }),
});
vi.stubGlobal("fetch", fetchSpy);
await checkVersion();
expect(fetchSpy).toHaveBeenCalledTimes(1);
// Advance time past cooldown
vi.advanceTimersByTime(MIN_CHECK_INTERVAL_MS + 1);
await checkVersion();
expect(fetchSpy).toHaveBeenCalledTimes(2);
vi.useRealTimers();
});
it("does not reload when remote version matches build version", async () => {
const fetchSpy = vi.fn().mockResolvedValue({
ok: true,
headers: new Headers({ "content-type": "application/json" }),
json: () => Promise.resolve({ version: "test-build-abc123" }), // matches stub __BUILD_VERSION__
});
vi.stubGlobal("fetch", fetchSpy);
await checkVersion();
expect(reloadSpy).not.toHaveBeenCalled();
});
it("does not reload when fetch returns null", async () => {
const fetchSpy = vi.fn().mockResolvedValue({
ok: false,
headers: new Headers(),
json: () => Promise.resolve({}),
});
vi.stubGlobal("fetch", fetchSpy);
await checkVersion();
expect(reloadSpy).not.toHaveBeenCalled();
});
});
describe("autoReloadOnVersionChange setting", () => {
const reloadSpy = vi.fn();
beforeEach(() => {
vi.stubGlobal("location", { reload: reloadSpy });
window.sessionStorage.clear();
reloadSpy.mockClear();
_resetState();
});
afterEach(() => {
_resetState();
vi.restoreAllMocks();
});
describe("reloadOnce with auto-reload setting", () => {
it("calls window.location.reload() when auto-reload is enabled (default)", () => {
expect(_isAutoReloadEnabled()).toBe(true);
reloadOnce("test reason");
expect(window.sessionStorage.getItem("fusion:version-reload")).toBe("1");
expect(reloadSpy).toHaveBeenCalledTimes(1);
});
it("does NOT call reload when auto-reload is disabled", () => {
const consoleInfoSpy = vi.spyOn(console, "info");
setAutoReloadEnabled(false);
expect(_isAutoReloadEnabled()).toBe(false);
reloadOnce("test reason");
// Should still set the flag to prevent retries
expect(window.sessionStorage.getItem("fusion:version-reload")).toBe("1");
expect(reloadSpy).not.toHaveBeenCalled();
expect(consoleInfoSpy).toHaveBeenCalledWith(
"[versionCheck] auto-reload disabled by setting, skipping reload:",
"test reason",
);
consoleInfoSpy.mockRestore();
});
it("re-enables reload after setAutoReloadEnabled(true)", () => {
setAutoReloadEnabled(false);
reloadOnce("suppressed");
expect(reloadSpy).not.toHaveBeenCalled();
// Reset for next call
window.sessionStorage.clear();
setAutoReloadEnabled(true);
reloadOnce("now enabled");
expect(reloadSpy).toHaveBeenCalledTimes(1);
});
});
describe("setAutoReloadEnabled", () => {
it("toggles the guard correctly", () => {
expect(_isAutoReloadEnabled()).toBe(true);
setAutoReloadEnabled(false);
expect(_isAutoReloadEnabled()).toBe(false);
setAutoReloadEnabled(true);
expect(_isAutoReloadEnabled()).toBe(true);
});
});
describe("bootstrap setting fetch", () => {
it("respects autoReloadOnVersionChange=false from settings API", async () => {
const fetchSpy = vi.fn().mockResolvedValue({
ok: true,
headers: new Headers({ "content-type": "application/json" }),
json: () => Promise.resolve({ autoReloadOnVersionChange: false }),
});
vi.stubGlobal("fetch", fetchSpy);
// Dynamically import to trigger bootstrap (we test the effect via setAutoReloadEnabled)
// Instead, directly test the fetch + setAutoReloadEnabled integration:
const res = await fetch("/api/settings", {
headers: { Accept: "application/json" },
});
const data = await res.json();
if (data.autoReloadOnVersionChange === false) {
setAutoReloadEnabled(false);
}
expect(_isAutoReloadEnabled()).toBe(false);
// Now reloadOnce should not actually reload
reloadOnce("bootstrap test");
expect(reloadSpy).not.toHaveBeenCalled();
});
it("keeps default (true) if settings fetch fails", async () => {
const fetchSpy = vi.fn().mockRejectedValue(new Error("Network error"));
vi.stubGlobal("fetch", fetchSpy);
try {
await fetch("/api/settings");
} catch {
// Expected — guard should remain true
}
expect(_isAutoReloadEnabled()).toBe(true);
});
});
});