The leak guard in scripts/check-test-isolation.mjs reported fusion-test-home-root-* dirs created by scripts/test-changed.mjs as leaks when transient EBUSY on /var/folders prevented cleanup or the baseline file got rotated. Track every HOME basename the script mints and pass it via FUSION_TEST_ISOLATION_IGNORE_NAMES so the check allow-lists them unconditionally. Surface cleanup rm failures via console.warn instead of swallowing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
146 lines
5.2 KiB
JavaScript
146 lines
5.2 KiB
JavaScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { spawnSync, spawn } from "node:child_process";
|
|
|
|
const scriptPath = path.resolve("scripts/check-test-isolation.mjs");
|
|
|
|
function withFixture(fn) {
|
|
const cwd = mkdtempSync(path.join(tmpdir(), "check-isolation-cwd-"));
|
|
const home = mkdtempSync(path.join(tmpdir(), "check-isolation-home-"));
|
|
mkdirSync(path.join(cwd, ".fusion"), { recursive: true });
|
|
mkdirSync(path.join(home, ".fusion"), { recursive: true });
|
|
try {
|
|
fn({ cwd, home });
|
|
} finally {
|
|
rmSync(cwd, { recursive: true, force: true });
|
|
rmSync(home, { recursive: true, force: true });
|
|
}
|
|
}
|
|
|
|
function runScript(args, options) {
|
|
return spawnSync(process.execPath, [scriptPath, ...args], {
|
|
cwd: options.cwd,
|
|
env: { ...process.env, HOME: options.home, USERPROFILE: options.home },
|
|
encoding: "utf8",
|
|
});
|
|
}
|
|
|
|
test("passes when baseline and current state match", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 0);
|
|
});
|
|
});
|
|
|
|
test("fails when a tracked temp leak appears after baseline", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
mkdirSync(path.join(tmpdir(), "fusion-test-leak-check-script"), { recursive: true });
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 1);
|
|
assert.match(after.stderr, /leaked temp director/i);
|
|
rmSync(path.join(tmpdir(), "fusion-test-leak-check-script"), { recursive: true, force: true });
|
|
});
|
|
});
|
|
|
|
test("ignores leaked temp dirs whose basenames appear in FUSION_TEST_ISOLATION_IGNORE_NAMES", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
|
|
// Simulate a fusion-test-home-root-* dir that survived cleanup. Without the
|
|
// env allow-list this would trip the leak guard; with it, the check passes.
|
|
const leakedName = `fusion-test-home-root-flake-${process.pid}`;
|
|
const leakedPath = path.join(tmpdir(), leakedName);
|
|
mkdirSync(leakedPath, { recursive: true });
|
|
try {
|
|
const result = spawnSync(process.execPath, [scriptPath], {
|
|
cwd,
|
|
env: {
|
|
...process.env,
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
FUSION_TEST_ISOLATION_IGNORE_NAMES: leakedName,
|
|
},
|
|
encoding: "utf8",
|
|
});
|
|
assert.equal(result.status, 0, result.stderr || result.stdout);
|
|
} finally {
|
|
rmSync(leakedPath, { recursive: true, force: true });
|
|
}
|
|
});
|
|
});
|
|
|
|
test("fails when protected repo .fusion data changes after baseline", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
writeFileSync(path.join(cwd, ".fusion", "mutated.txt"), "x");
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 1);
|
|
assert.match(after.stderr, /protected live \.fusion data changed/i);
|
|
});
|
|
});
|
|
|
|
test("fails when protected HOME .fusion data changes after baseline", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
writeFileSync(path.join(home, ".fusion", "home-mutated.txt"), "x");
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 1);
|
|
assert.match(after.stderr, /protected live \.fusion data changed/i);
|
|
});
|
|
});
|
|
|
|
test("fails when protected .fusion existence changes after baseline", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
rmSync(path.join(cwd, ".fusion"), { recursive: true, force: true });
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
mkdirSync(path.join(cwd, ".fusion"), { recursive: true });
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 1);
|
|
assert.match(after.stderr, /protected live \.fusion data changed/i);
|
|
});
|
|
});
|
|
|
|
test("passes when HOME .fusion is externally active during baseline and check", () => {
|
|
withFixture(({ cwd, home }) => {
|
|
const churnScript = `
|
|
const fs = require("node:fs");
|
|
const path = require("node:path");
|
|
const home = process.argv[2];
|
|
const target = path.join(home, ".fusion", "external-churn.txt");
|
|
let n = 0;
|
|
const timer = setInterval(() => {
|
|
fs.writeFileSync(target, String(n++));
|
|
}, 120);
|
|
setTimeout(() => {
|
|
clearInterval(timer);
|
|
process.exit(0);
|
|
}, 3500);
|
|
`;
|
|
|
|
const churn = spawn(process.execPath, ["-e", churnScript, home], {
|
|
cwd,
|
|
env: { ...process.env, HOME: home, USERPROFILE: home },
|
|
stdio: "ignore",
|
|
});
|
|
|
|
const before = runScript(["--before"], { cwd, home });
|
|
assert.equal(before.status, 0);
|
|
const after = runScript([], { cwd, home });
|
|
assert.equal(after.status, 0);
|
|
|
|
churn.kill("SIGTERM");
|
|
rmSync(path.join(home, ".fusion", "external-churn.txt"), { force: true });
|
|
});
|
|
});
|