Add an opt-in project setting that lets the workspace file browser use slash-prefixed absolute paths while preserving existing confined defaults. - Add the allowAbsoluteFileBrowserPaths project setting, docs, and changeset release note. - Thread absolute-path validation through workspace file-browser listing, editing, file operations, and downloads without widening other path APIs. - Add Settings UI controls and keep settings-specific file pickers project-relative. - Cover absolute-path browsing, percent-literal paths, root navigation, and settings picker behavior with tests. Files changed: .changeset/fn-7264-absolute-file-browser-paths.md | 7 + docs/settings-reference.md | 3 + .../core/src/__tests__/settings-parity.test.ts | 8 + packages/core/src/settings-schema.ts | 5 + packages/core/src/types.ts | 5 + .../app/__tests__/settings-sections.test.tsx | 41 +++++ packages/dashboard/app/components/FileBrowser.tsx | 26 ++- .../dashboard/app/components/FileBrowserModal.tsx | 7 + .../dashboard/app/components/SettingsModal.tsx | 34 +++- .../components/__tests__/FileBrowserModal.test.tsx | 18 ++ .../__tests__/SettingsModal.general.test.tsx | 17 ++ .../settings/sections/GeneralSection.tsx | 9 + .../__tests__/useWorkspaceFileBrowser.test.ts | 18 ++ .../dashboard/app/hooks/useWorkspaceFileBrowser.ts | 20 ++- .../dashboard/src/__tests__/file-service.test.ts | 199 ++++++++++++++++++++- packages/dashboard/src/file-service.ts | 129 ++++++++----- 16 files changed, 489 insertions(+), 57 deletions(-) Fusion-Task-Id: FN-7264 Fusion-Task-Lineage: ec71facd-0345-4490-a3df-244b98e24c2d Co-authored-by: Fusion (runfusion.ai) <noreply@runfusion.ai>
115 lines
4.3 KiB
TypeScript
115 lines
4.3 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
|
|
import { renderHook, act, waitFor } from "@testing-library/react";
|
|
import { useWorkspaceFileBrowser } from "../useWorkspaceFileBrowser";
|
|
import * as api from "../../api";
|
|
import type { FileListResponse } from "../../api";
|
|
|
|
vi.mock("../../api", () => ({
|
|
fetchWorkspaceFileList: vi.fn(),
|
|
}));
|
|
|
|
const mockFetchWorkspaceFileList = vi.mocked(api.fetchWorkspaceFileList);
|
|
|
|
describe("useWorkspaceFileBrowser", () => {
|
|
beforeEach(() => {
|
|
mockFetchWorkspaceFileList.mockReset();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("fetches workspace files when enabled", async () => {
|
|
const mockResponse: FileListResponse = {
|
|
path: ".",
|
|
entries: [{ name: "src", type: "directory", mtime: "2024-01-01T00:00:00Z" }],
|
|
};
|
|
mockFetchWorkspaceFileList.mockResolvedValueOnce(mockResponse);
|
|
|
|
const { result } = renderHook(() => useWorkspaceFileBrowser("FN-123", true));
|
|
|
|
expect(result.current.loading).toBe(true);
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
expect(result.current.entries).toEqual(mockResponse.entries);
|
|
expect(mockFetchWorkspaceFileList).toHaveBeenCalledWith("FN-123", undefined, undefined);
|
|
});
|
|
|
|
it("resets path when workspace changes", async () => {
|
|
mockFetchWorkspaceFileList
|
|
.mockResolvedValueOnce({ path: ".", entries: [{ name: "src", type: "directory", mtime: "2024-01-01T00:00:00Z" }] })
|
|
.mockResolvedValueOnce({ path: "src", entries: [{ name: "index.ts", type: "file", size: 1, mtime: "2024-01-01T00:00:00Z" }] })
|
|
.mockResolvedValueOnce({ path: ".", entries: [{ name: "README.md", type: "file", size: 5, mtime: "2024-01-01T00:00:00Z" }] });
|
|
|
|
const { result, rerender } = renderHook(
|
|
({ workspace }) => useWorkspaceFileBrowser(workspace, true),
|
|
{ initialProps: { workspace: "FN-123" } },
|
|
);
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
act(() => {
|
|
result.current.setPath("src");
|
|
});
|
|
|
|
await waitFor(() => expect(result.current.currentPath).toBe("src"));
|
|
await waitFor(() => expect(mockFetchWorkspaceFileList).toHaveBeenLastCalledWith("FN-123", "src", undefined));
|
|
|
|
rerender({ workspace: "project" });
|
|
|
|
await waitFor(() => expect(result.current.currentPath).toBe("."));
|
|
await waitFor(() => expect(mockFetchWorkspaceFileList).toHaveBeenLastCalledWith("project", undefined, undefined));
|
|
});
|
|
|
|
it("handles fetch errors", async () => {
|
|
mockFetchWorkspaceFileList.mockRejectedValueOnce(new Error("Failed to load files"));
|
|
|
|
const { result } = renderHook(() => useWorkspaceFileBrowser("FN-404", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
expect(result.current.error).toBe("Failed to load files");
|
|
expect(result.current.entries).toEqual([]);
|
|
});
|
|
|
|
it("keeps settings pickers project-relative when absolute browsing is disabled", async () => {
|
|
mockFetchWorkspaceFileList.mockResolvedValue({ path: ".", entries: [] });
|
|
|
|
const { result } = renderHook(() => (
|
|
useWorkspaceFileBrowser("project", true, undefined, { allowAbsolutePaths: false })
|
|
));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
act(() => {
|
|
result.current.setPath("/outside/project");
|
|
});
|
|
|
|
expect(result.current.currentPath).toBe(".");
|
|
expect(result.current.error).toBe("This picker only accepts project-relative paths");
|
|
expect(mockFetchWorkspaceFileList).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it("returns hidden files and directories from the API response", async () => {
|
|
const mockResponse: FileListResponse = {
|
|
path: ".",
|
|
entries: [
|
|
{ name: ".env.example", type: "file", size: 42, mtime: "2024-01-01T00:00:00Z" },
|
|
{ name: ".github", type: "directory", mtime: "2024-01-01T00:00:00Z" },
|
|
{ name: "src", type: "directory", mtime: "2024-01-01T00:00:00Z" },
|
|
],
|
|
};
|
|
mockFetchWorkspaceFileList.mockResolvedValueOnce(mockResponse);
|
|
|
|
const { result } = renderHook(() => useWorkspaceFileBrowser("project", true));
|
|
|
|
await waitFor(() => expect(result.current.loading).toBe(false));
|
|
|
|
expect(result.current.entries).toEqual(mockResponse.entries);
|
|
const names = result.current.entries.map((e) => e.name);
|
|
expect(names).toContain(".env.example");
|
|
expect(names).toContain(".github");
|
|
expect(names).toContain("src");
|
|
});
|
|
});
|