Files
fusion/packages/cli/src/commands/message.ts
gsxdsm c15c78feeb feat: migrate storage from SQLite to PostgreSQL (#1793)
# Migrate storage from SQLite to PostgreSQL — full dashboard cutover

Migrates Fusion's storage layer to the embedded PostgreSQL
`AsyncDataLayer` (the default backend) and **completes the
satellite-store + feature cutover** so every dashboard and Command
Center surface works in PG mode.

## Status — every surface works in embedded-PG mode

Verified live against a running embedded-Postgres dashboard (all
**200**, zero 5xx) and gate-tested (**23 files / 99 tests** on embedded
PG, plus engine-core 294 and ci-shape 63 in the blocking merge gate;
core/engine/cli/dashboard typecheck clean).

| Area | Surfaces | State |
|---|---|---|
| Satellite stores | workflows, todos, insights, research, missions,
goals, mailbox | ✅ |
| Views | artifacts, documents, evals | ✅ |
| Command Center | activity, productivity, team, tokens, tools,
**workflows**, **github**, **signals**, **plugin-activations**, **live**
(all 10) | ✅ |
| Run execution | insight generation, research run execution | ✅
(store-path; AI step needs a provider) |
| Live updates | SSE push for mission/research/insight events | ✅ |
| Workflow editing | create / update / delete / select (+ id counter) |
✅ |
| Engine | mission autopilot, incident-signal ingestion, regression
storm-guard, agent wake-on-message | ✅ |
| Core | tasks, agents, secrets, automations, memory, chat, usage, PRs,
git | ✅ |

## Approach

Each satellite store gets an `Async<Store>` wrapper exposing the sync
store's method names over the existing `async-*-store.ts` helpers;
`get<Store>Store()` returns a `Sync | Async` union; consumers `await`
(harmless on sync), and engine/CLI paths that can't convert use
`instanceof Sync` graceful fallback. Analytics aggregators branch on
`"ping" in dbOrLayer` to run schema-qualified raw SQL over `project.*`
(snake_case) in PG. Executors/orchestrators/autopilot are
await-converted to drive the union store; the async store wrappers
extend `EventEmitter` so SSE live-push fires in both backends.

Not-yet-ported capabilities degrade gracefully (never 500) and are
individually called out in commits.

## Sync with main

The branch is kept continuously merged with `main` (currently through
FN-7845, 2026-07-12); the earlier "final rebase deferred" note no longer
applies. Use **Create a merge commit** (or squash) to land it — GitHub's
rebase-merge cannot replay a merge-maintained branch.

## Residual Review Findings

Multi-agent code review of the PostgreSQL satellite-store ports (U1–U5)
applied 3 safe fixes (see `fix(review): apply autofix feedback`). The
following are **real but gated** — recorded here as follow-up work
rather than auto-applied. All are SQLite→PostgreSQL
**concurrency/atomicity regressions**: the sync stores were immune only
by SQLite's single-writer, single-threaded-handler execution; the async
ports open multi-await read-modify-write windows. **Reachability is low
today** because the execution engines that generate concurrent same-run
mutations (insight run executor, research orchestrator/dispatcher) are
`instanceof`-gated to sync mode in PG. No process-crash class survived
(all engine fallbacks correctly guard the sync store).

- **[P1] Research `appendResearchEvent` dual-write is non-atomic**
(`packages/core/src/async-research-store.ts`, corroborated: adversarial
+ reliability). The `research_run_events` insert (own transaction) and
the `run.events` jsonb update are separate writes — a crash between
them, or two concurrent appends, splits the table count from the jsonb
array. **Fix:** perform the seq-insert and the jsonb update in one
`layer.transactionImmediate`.
- **[P1] Research run terminal-reversion via stale full-row persist**
(`async-research-store.ts` `persistResearchRun`/`updateResearchStatus`).
Concurrent `PATCH /runs/:id/status` + `POST /runs/:id/events` can revert
a terminal run to `running` by overwriting the whole row, bypassing the
transition guard. **Fix:** scoped column `UPDATE`s with a `WHERE status
…` guard, or optimistic version column.
- **[P2] `updateResearchRun`/`updateInsightRun` read-then-write TOCTOU**
— concurrent PATCHes last-writer-wins on the lifecycle merge. **Fix:**
`SELECT … FOR UPDATE` / enclosing transaction.
- **[P2] `upsertRun`/`createRunOrThrowConflict` check-then-create race**
(`async-insight-store.ts`) — two callers can each create an "active"
run. **Fix:** partial unique index on `(projectId, trigger) WHERE status
IN ('pending','running')`.
- **[P3] `createResearchRetryRun` return-value divergence** — sync
returns the pre-update `queued` snapshot; async returns the reloaded
`retry_waiting` run (persisted state is identical). Pick one side for
cross-backend parity.
- **[P2/perf] Mission `getMissionWithHierarchy`/`getMissionHealth` N+1
fan-out** — O(milestones×slices) sequential round-trips hold one pool
slot per request; can starve the pool for large hierarchies. **Fix:**
batched/joined reads.
- **Testing gaps:** no PG-mode concurrency tests (interleaved
status/event mutations), no sync↔async parity assertion for the
lifecycle-error codes, and no mission status/health rollup parity test
vs the sync `MissionStore`.

~~Out of scope (deferred): AI run *execution* (insight/research) +
mission autopilot + live SSE mission events remain sync-gated/degraded
in PG mode.~~ **Since ported** — insight/research run execution, mission
autopilot, and SSE live push all run on the async layer now, which also
makes the concurrency findings above genuinely reachable; they remain
open follow-ups.







---

## Update — 2026-07-12: production-readiness hardening & live acceptance

Everything below landed on this branch since the description above was
written:

**Production blockers from review — fixed**
- `recoverStaleTransitionPending` ported to the async layer (backend
moves write + clear the crash-safe marker; startup/maintenance sweeps no
longer throw).
- Lost-update class fixed: `atomicWriteTaskJson`/`WithAudit` write
changed columns only (full-row upserts silently resurrected stale fields
across concurrent store instances — the "task stuck unplanned forever"
bug).
- First-boot **auto-migration**: booting the PG backend over a project
with a legacy `fusion.db` migrates it automatically (loud failure,
SQLite kept as backup), and the dashboard shows a one-time **"your data
was migrated" banner** with the backup paths and a Need-help Discord
link.
- `pg_dump`/`pg_restore` discovered from common install locations for
embedded-mode backups.
- The PG suite is part of the blocking merge gate (`test:pg-gate`).

**Multi-project isolation (PR #2007, merged into this branch)**
- `project_id` partition key on tasks / archived tasks / config,
`taskProjectScope` threaded through every scan/claim/count, per-project
config rows, layer bound to the project at startup.
- Review P1 follow-up: the shared cold-storage `archive.archived_tasks`
table is also partitioned and all archived-board reads/counts/searches
are scoped.
- Schema drift self-heal generalized to schema-qualified columns so
existing databases upgrade in place.

**Other changes**
- Node settings sync **removed** in PG mode (409
`settings-sync-disabled-postgres`) — nodes share state by connecting to
the same database; auth sync kept (per-machine file).
- Perf (review findings): `listTasks` pushes column filter + ORDER BY +
LIMIT/OFFSET into SQL; `getConversation` capped to the most recent 200
messages.
- Fixed a false "operator action required" pause-abort log fired on
every successfully auto-merged task.

**Live acceptance — PASSED (2026-07-12)**
A sandboxed instance (isolated HOME, embedded PG, real Opus executor)
ran a task through the complete cycle: create → triage (AI spec) →
execute → in-review → AI squash-merge landed on the project's `main` →
done. A write+read sweep of every data surface (settings, comments,
documents, attachments + artifact bridge + artifact edit, chat with real
generation, goals, missions, agent mail, secrets, workflows, memory, CC
analytics) was green on embedded PG.

**Known remaining work**
- The per-project `config` PK re-key has no upgrade path for
pre-isolation embedded-PG databases (needs a real `DROP
CONSTRAINT`/re-key migration; fresh databases are fine).
- `pg_dump`/`pg_restore` binaries are not yet bundled in release
artifacts (PATH/common-location discovery only).
- The satellite-store concurrency findings listed above.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Phil Larson <hello@phillarson.xyz>
Co-authored-by: fusion-merge <fusion-merge@local>
2026-07-13 19:07:58 -07:00

231 lines
7.1 KiB
TypeScript

import { MessageStore, createDatabase } from "@fusion/core";
import type { ParticipantType } from "@fusion/core";
import { resolveAgentStoreBase } from "../project-context.js";
/**
* Create a MessageStore for the given project.
* Returns the store plus a `db` cleanup handle callers close in `finally`.
*
* FNXC:PostgresCutover 2026-07-05-12:00:
* Borrow the PostgreSQL AsyncDataLayer from the resolved project store so the
* MessageStore runs in backend mode (the sync SQLite Database runtime was
* removed under VAL-REMOVAL-005). The legacy createDatabase path survives only
* for the FUSION_NO_EMBEDDED_PG=1 opt-out where no asyncLayer exists. The
* backend-mode `db` handle is a no-op closer: the AsyncDataLayer pool is owned
* by the resolved project store, not by this command.
*/
export async function createMessageStore(projectName?: string): Promise<{ store: MessageStore; db: { close: () => void } }> {
const { rootDir, asyncLayer } = await resolveAgentStoreBase(projectName);
if (asyncLayer) {
const store = new MessageStore(null, { asyncLayer });
return { store, db: { close: () => {} } };
}
const fusionDir = rootDir + "/.fusion";
const db = createDatabase(fusionDir);
db.init();
const store = new MessageStore(db);
return { store, db };
}
/** User ID for CLI-originated messages */
export const CLI_USER_ID = "cli";
/**
* List inbox messages.
*/
export async function runMessageInbox(projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
const mailbox = await store.getMailbox(CLI_USER_ID, "user");
const messages = await store.getInbox(CLI_USER_ID, "user", { limit: 20 });
console.log();
console.log(` 📬 Inbox (${mailbox.unreadCount} unread)`);
console.log();
if (messages.length === 0) {
console.log(" No messages");
console.log();
return;
}
for (const msg of messages) {
const readMarker = msg.read ? " " : "● ";
const fromLabel = msg.fromType === "agent" ? `Agent ${msg.fromId}` : msg.fromId;
const timeStr = formatTime(msg.createdAt);
const preview = msg.content.length > 80 ? msg.content.slice(0, 80) + "…" : msg.content;
console.log(` ${readMarker}${fromLabel} — ${timeStr}`);
console.log(` ${preview}`);
console.log();
}
} finally {
db.close();
}
}
/**
* List sent messages.
*/
export async function runMessageOutbox(projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
const messages = await store.getOutbox(CLI_USER_ID, "user", { limit: 20 });
console.log();
console.log(" 📤 Outbox");
console.log();
if (messages.length === 0) {
console.log(" No sent messages");
console.log();
return;
}
for (const msg of messages) {
const toLabel = msg.toType === "agent" ? `Agent ${msg.toId}` : msg.toId;
const timeStr = formatTime(msg.createdAt);
const preview = msg.content.length > 80 ? msg.content.slice(0, 80) + "…" : msg.content;
console.log(` To: ${toLabel} — ${timeStr}`);
console.log(` ${preview}`);
console.log();
}
} finally {
db.close();
}
}
/**
* Send a message to an agent.
*/
export async function runMessageSend(toId: string, content: string, projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
const message = await store.sendMessage({
fromId: CLI_USER_ID,
fromType: "user",
toId,
toType: "agent",
content,
type: "user-to-agent",
});
console.log();
console.log(` ✓ Message sent: ${message.id}`);
console.log(` To: Agent ${toId}`);
console.log();
} finally {
db.close();
}
}
/**
* Read and display a specific message.
*/
export async function runMessageRead(id: string, projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
const message = await store.getMessage(id);
if (!message) {
console.error(`Message ${id} not found`);
process.exit(1);
}
// Mark as read
if (!message.read) {
await store.markAsRead(id);
}
const fromLabel = formatParticipant(message.fromId, message.fromType);
const toLabel = formatParticipant(message.toId, message.toType);
const timeStr = new Date(message.createdAt).toLocaleString();
console.log();
console.log(` Message: ${message.id}`);
console.log(` Type: ${message.type}`);
console.log(` From: ${fromLabel}`);
console.log(` To: ${toLabel}`);
console.log(` Time: ${timeStr}`);
console.log();
console.log(` ${message.content}`);
console.log();
} finally {
db.close();
}
}
/**
* Delete a message.
*/
export async function runMessageDelete(id: string, projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
await store.deleteMessage(id);
console.log();
console.log(` ✓ Message ${id} deleted`);
console.log();
} finally {
db.close();
}
}
/**
* View an agent's mailbox.
*/
export async function runAgentMailbox(agentId: string, projectName?: string): Promise<void> {
const { store, db } = await createMessageStore(projectName);
try {
const mailbox = await store.getMailbox(agentId, "agent");
const messages = await store.getInbox(agentId, "agent", { limit: 20 });
console.log();
console.log(` 🤖 Agent Mailbox: ${agentId} (${mailbox.unreadCount} unread)`);
console.log();
if (messages.length === 0) {
console.log(" No messages");
console.log();
return;
}
for (const msg of messages) {
const readMarker = msg.read ? " " : "● ";
const fromLabel = formatParticipant(msg.fromId, msg.fromType);
const timeStr = formatTime(msg.createdAt);
const preview = msg.content.length > 80 ? msg.content.slice(0, 80) + "…" : msg.content;
console.log(` ${readMarker}From: ${fromLabel} — ${timeStr}`);
console.log(` ${preview}`);
console.log();
}
} finally {
db.close();
}
}
// ── Helpers ───────────────────────────────────────────────────────────────
export function formatParticipant(id: string, type: ParticipantType): string {
switch (type) {
case "agent": return `Agent ${id}`;
case "user": return id === "cli" ? "You (CLI)" : id === "dashboard" ? "You (Dashboard)" : `User ${id}`;
case "system": return "System";
}
}
export function formatTime(ts: string): string {
const date = new Date(ts);
const now = new Date();
const diffMs = now.getTime() - date.getTime();
const diffMins = Math.floor(diffMs / 60000);
const diffHours = Math.floor(diffMs / 3600000);
const diffDays = Math.floor(diffMs / 86400000);
if (diffMins < 1) return "just now";
if (diffMins < 60) return `${diffMins}m ago`;
if (diffHours < 24) return `${diffHours}h ago`;
if (diffDays < 7) return `${diffDays}d ago`;
return date.toLocaleDateString(undefined, { month: "short", day: "numeric" });
}